From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D8A0C433E2 for ; Wed, 9 Sep 2020 13:10:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7984821D7F for ; Wed, 9 Sep 2020 13:10:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NyQygaWr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7984821D7F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44054 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFzrQ-0005HX-Cu for qemu-devel@archiver.kernel.org; Wed, 09 Sep 2020 09:10:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57386) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFzqc-0004Q0-OX for qemu-devel@nongnu.org; Wed, 09 Sep 2020 09:09:14 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:55138 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kFzqb-0002eu-0s for qemu-devel@nongnu.org; Wed, 09 Sep 2020 09:09:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599656952; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n38YsItla2gAm/7AmbqvOS7RN7lM/51ex/2/AGTk+Bk=; b=NyQygaWrBL2ARndIaU3yZi16XDDjCn6ESDyPceTrLBZxgQjEjOQJoMpQlwnvnMlnGujcUk h+pPIeHy4/JhmutwhU8uxu9gVwv/HwcuY7cohXbmhbZ5E7ksYtYmguCnSQdzHqxcqZGNKF aOQIkAPMG7mG+MrP+Ryf/4A1rPPS09s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-146-ry5xuYq-NL-EFOTCQsoQ-w-1; Wed, 09 Sep 2020 09:09:10 -0400 X-MC-Unique: ry5xuYq-NL-EFOTCQsoQ-w-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 20CB11017DC7; Wed, 9 Sep 2020 13:09:08 +0000 (UTC) Received: from redhat.com (ovpn-113-81.ams2.redhat.com [10.36.113.81]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 59DF119936; Wed, 9 Sep 2020 13:08:53 +0000 (UTC) Date: Wed, 9 Sep 2020 14:08:50 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Yonggang Luo Subject: Re: [PATCH v2 17/21] tests: Fixes test-io-channel-socket.c tests under msys2/mingw Message-ID: <20200909130850.GH1011023@redhat.com> References: <20200909094617.1582-1-luoyonggang@gmail.com> <20200909094617.1582-18-luoyonggang@gmail.com> MIME-Version: 1.0 In-Reply-To: <20200909094617.1582-18-luoyonggang@gmail.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline Received-SPF: pass client-ip=205.139.110.120; envelope-from=berrange@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/09 03:13:17 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Kevin Wolf , Ed Maste , qemu-block@nongnu.org, Stefan Weil , Xie Changlong , Peter Lieven , qemu-devel@nongnu.org, Michael Roth , Richard Henderson , Gerd Hoffmann , Wen Congyang , Max Reitz , Li-Wen Hsu , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Sep 09, 2020 at 05:46:13PM +0800, Yonggang Luo wrote: > Currently test-io-channel-socket doesn't init with > qemu_init_main_loop > and that's cause the qemu_aio_context not inited, > and the following is the stack when null pointer accessed: > > qemu_fd_register (c:\work\xemu\qemu\util\main-loop.c:336) > qemu_try_set_nonblock (c:\work\xemu\qemu\util\oslib-win32.c:224) > qemu_set_nonblock (c:\work\xemu\qemu\util\oslib-win32.c:230) > socket_can_bind_connect (c:\work\xemu\qemu\tests\socket-helpers.c:93) > socket_check_protocol_support (c:\work\xemu\qemu\tests\socket-helpers.c:141) > main (c:\work\xemu\qemu\tests\test-io-channel-socket.c:568) > __tmainCRTStartup (@__tmainCRTStartup:142) > mainCRTStartup (@1400014f6..140001539:3) > BaseThreadInitThunk (@BaseThreadInitThunk:9) > RtlUserThreadStart (@RtlUserThreadStart:12) > > Signed-off-by: Yonggang Luo > --- > tests/test-io-channel-socket.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|