* [PATCH] ui/spice-input: Remove superfluous forward declaration
@ 2020-09-09 17:11 Philippe Mathieu-Daudé
2020-09-12 15:15 ` Laurent Vivier
2020-09-16 8:48 ` Laurent Vivier
0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-09-09 17:11 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Gerd Hoffmann, Philippe Mathieu-Daudé
We only need to forward-declare kbd_push_key() and kbd_get_leds()
which are used in kbd_interface, not kbd_leds(). Remove this
superfluous forward declaration.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
ui/spice-input.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/ui/spice-input.c b/ui/spice-input.c
index d5bba231c95..21990fa9962 100644
--- a/ui/spice-input.c
+++ b/ui/spice-input.c
@@ -36,7 +36,6 @@ typedef struct QemuSpiceKbd {
static void kbd_push_key(SpiceKbdInstance *sin, uint8_t frag);
static uint8_t kbd_get_leds(SpiceKbdInstance *sin);
-static void kbd_leds(void *opaque, int l);
static const SpiceKbdInterface kbd_interface = {
.base.type = SPICE_INTERFACE_KEYBOARD,
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ui/spice-input: Remove superfluous forward declaration
2020-09-09 17:11 [PATCH] ui/spice-input: Remove superfluous forward declaration Philippe Mathieu-Daudé
@ 2020-09-12 15:15 ` Laurent Vivier
2020-09-16 8:48 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2020-09-12 15:15 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: qemu-trivial, Gerd Hoffmann
Le 09/09/2020 à 19:11, Philippe Mathieu-Daudé a écrit :
> We only need to forward-declare kbd_push_key() and kbd_get_leds()
> which are used in kbd_interface, not kbd_leds(). Remove this
> superfluous forward declaration.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> ui/spice-input.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/ui/spice-input.c b/ui/spice-input.c
> index d5bba231c95..21990fa9962 100644
> --- a/ui/spice-input.c
> +++ b/ui/spice-input.c
> @@ -36,7 +36,6 @@ typedef struct QemuSpiceKbd {
>
> static void kbd_push_key(SpiceKbdInstance *sin, uint8_t frag);
> static uint8_t kbd_get_leds(SpiceKbdInstance *sin);
> -static void kbd_leds(void *opaque, int l);
>
> static const SpiceKbdInterface kbd_interface = {
> .base.type = SPICE_INTERFACE_KEYBOARD,
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ui/spice-input: Remove superfluous forward declaration
2020-09-09 17:11 [PATCH] ui/spice-input: Remove superfluous forward declaration Philippe Mathieu-Daudé
2020-09-12 15:15 ` Laurent Vivier
@ 2020-09-16 8:48 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2020-09-16 8:48 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: qemu-trivial, Gerd Hoffmann
Le 09/09/2020 à 19:11, Philippe Mathieu-Daudé a écrit :
> We only need to forward-declare kbd_push_key() and kbd_get_leds()
> which are used in kbd_interface, not kbd_leds(). Remove this
> superfluous forward declaration.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> ui/spice-input.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/ui/spice-input.c b/ui/spice-input.c
> index d5bba231c95..21990fa9962 100644
> --- a/ui/spice-input.c
> +++ b/ui/spice-input.c
> @@ -36,7 +36,6 @@ typedef struct QemuSpiceKbd {
>
> static void kbd_push_key(SpiceKbdInstance *sin, uint8_t frag);
> static uint8_t kbd_get_leds(SpiceKbdInstance *sin);
> -static void kbd_leds(void *opaque, int l);
>
> static const SpiceKbdInterface kbd_interface = {
> .base.type = SPICE_INTERFACE_KEYBOARD,
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-16 8:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-09 17:11 [PATCH] ui/spice-input: Remove superfluous forward declaration Philippe Mathieu-Daudé
2020-09-12 15:15 ` Laurent Vivier
2020-09-16 8:48 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).