From: Yonggang Luo <luoyonggang@gmail.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Ed Maste <emaste@freebsd.org>,
Michael Roth <mdroth@linux.vnet.ibm.com>,
qemu-block@nongnu.org, Stefan Weil <sw@weilnetz.de>,
Xie Changlong <xiechanglong.d@gmail.com>,
Peter Lieven <pl@kamp.de>, Markus Armbruster <armbru@redhat.com>,
Max Reitz <mreitz@redhat.com>,
Yonggang Luo <luoyonggang@gmail.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Wen Congyang <wencongyang2@huawei.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Li-Wen Hsu <lwhsu@freebsd.org>
Subject: [PATCH v6 08/25] tests: disable /char/stdio/* tests in test-char.c on win32
Date: Thu, 10 Sep 2020 02:42:35 +0800 [thread overview]
Message-ID: <20200909184237.765-1-luoyonggang@gmail.com> (raw)
These tests are blocking test-char to be finished.
Disable them by using variable is_win32, so we doesn't
need macro to open it. and easy recover those function
latter.
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
---
tests/test-char.c | 26 ++++++++++++++++----------
1 file changed, 16 insertions(+), 10 deletions(-)
diff --git a/tests/test-char.c b/tests/test-char.c
index d35cc839bc..184ddceab8 100644
--- a/tests/test-char.c
+++ b/tests/test-char.c
@@ -77,7 +77,6 @@ static void fe_event(void *opaque, QEMUChrEvent event)
}
}
-#ifdef _WIN32
static void char_console_test_subprocess(void)
{
QemuOpts *opts;
@@ -102,7 +101,7 @@ static void char_console_test(void)
g_test_trap_assert_passed();
g_test_trap_assert_stdout("CONSOLE");
}
-#endif
+
static void char_stdio_test_subprocess(void)
{
Chardev *chr;
@@ -1448,7 +1447,11 @@ static SocketAddress unixaddr = {
int main(int argc, char **argv)
{
- bool has_ipv4, has_ipv6;
+ bool has_ipv4, has_ipv6, is_win32 = false;
+
+#ifdef _WIN32
+ is_win32 = true;
+#endif
qemu_init_main_loop(&error_abort);
socket_init();
@@ -1467,12 +1470,15 @@ int main(int argc, char **argv)
g_test_add_func("/char/invalid", char_invalid_test);
g_test_add_func("/char/ringbuf", char_ringbuf_test);
g_test_add_func("/char/mux", char_mux_test);
-#ifdef _WIN32
- g_test_add_func("/char/console/subprocess", char_console_test_subprocess);
- g_test_add_func("/char/console", char_console_test);
-#endif
- g_test_add_func("/char/stdio/subprocess", char_stdio_test_subprocess);
- g_test_add_func("/char/stdio", char_stdio_test);
+ if (0) {
+ g_test_add_func("/char/console/subprocess", char_console_test_subprocess);
+ g_test_add_func("/char/console", char_console_test);
+ }
+
+ if (!is_win32) {
+ g_test_add_func("/char/stdio/subprocess", char_stdio_test_subprocess);
+ g_test_add_func("/char/stdio", char_stdio_test);
+ }
#ifndef _WIN32
g_test_add_func("/char/pipe", char_pipe_test);
#endif
@@ -1534,7 +1540,7 @@ int main(int argc, char **argv)
g_test_add_data_func("/char/socket/client/dupid-reconnect/" # name, \
&client8 ##name, char_socket_client_dupid_test)
- if (has_ipv4) {
+ if (has_ipv4 && !is_win32) {
SOCKET_SERVER_TEST(tcp, &tcpaddr);
SOCKET_CLIENT_TEST(tcp, &tcpaddr);
g_test_add_data_func("/char/socket/server/two-clients/tcp", &tcpaddr,
--
2.28.0.windows.1
next reply other threads:[~2020-09-09 18:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 18:42 Yonggang Luo [this message]
2020-09-09 18:42 ` [PATCH v6 24/25] ci: Enable msys2 ci in cirrus Yonggang Luo
2020-09-09 18:42 ` [PATCH v6 25/25] meson: guard the minimal meson version to 0.55.1 Yonggang Luo
2020-09-09 20:08 ` Paolo Bonzini
2020-09-09 20:10 ` 罗勇刚(Yonggang Luo)
2020-09-09 22:37 ` Paolo Bonzini
2020-09-10 7:43 ` Daniel P. Berrangé
2020-09-09 18:47 ` [PATCH v6 08/25] tests: disable /char/stdio/* tests in test-char.c on win32 Thomas Huth
2020-09-09 18:54 ` 罗勇刚(Yonggang Luo)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909184237.765-1-luoyonggang@gmail.com \
--to=luoyonggang@gmail.com \
--cc=armbru@redhat.com \
--cc=emaste@freebsd.org \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lwhsu@freebsd.org \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sw@weilnetz.de \
--cc=wencongyang2@huawei.com \
--cc=xiechanglong.d@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).