From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, armbru@redhat.com, berto@igalia.com,
vsementsov@virtuozzo.com, eblake@redhat.com, jsnow@redhat.com,
stefanha@redhat.com, pbonzini@redhat.com,
pavel.dovgaluk@ispras.ru, ari@tuxera.com, mreitz@redhat.com,
kwolf@redhat.com, groug@kaod.org
Subject: [PATCH 00/14] block: deal with errp: part I
Date: Wed, 9 Sep 2020 21:59:16 +0300 [thread overview]
Message-ID: <20200909185930.26524-1-vsementsov@virtuozzo.com> (raw)
Hi all!
I've start to apply scripts/coccinelle/errp-guard.cocci to block
subsystem, but it turned out that in most cases error propagation can be
simply avoided. So, here are some improvements to block layer error
reporting to avoid error propagation. It's not complete, so its called
part I, I don't want to create huge series.
Vladimir Sementsov-Ogievskiy (14):
block: return status from bdrv_append and friends
block: use return status of bdrv_append()
block: check return value of bdrv_open_child and drop error
propagation
blockdev: fix drive_backup_prepare() missed error
block: drop extra error propagation for bdrv_set_backing_hd
block/mirror: drop extra error propagation in commit_active_start()
block/blklogwrites: drop error propagation
blockjob: return status from block_job_set_speed()
block/qcow2: qcow2_get_specific_info(): drop error propagation
block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface
block/qcow2-bitmap: return startus from
qcow2_store_persistent_dirty_bitmaps
block/qcow2: read_cache_sizes: return status value
block/qcow2: qcow2_do_open: deal with errp
block/qed: bdrv_qed_do_open: deal with errp
block/qcow2.h | 9 +++---
include/block/block.h | 12 +++----
include/block/blockjob.h | 2 +-
block.c | 50 ++++++++++++++++--------------
block/backup-top.c | 20 +++++-------
block/blkdebug.c | 6 ++--
block/blklogwrites.c | 33 +++++++++-----------
block/blkreplay.c | 6 ++--
block/blkverify.c | 11 +++----
block/commit.c | 5 +--
block/mirror.c | 18 +++++------
block/qcow2-bitmap.c | 62 +++++++++++++++++--------------------
block/qcow2.c | 56 ++++++++++++++-------------------
block/qed.c | 24 ++++++++------
block/quorum.c | 6 ++--
blockdev.c | 7 ++---
blockjob.c | 18 +++++------
tests/test-bdrv-graph-mod.c | 6 ++--
18 files changed, 159 insertions(+), 192 deletions(-)
--
2.21.3
next reply other threads:[~2020-09-09 19:01 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 18:59 Vladimir Sementsov-Ogievskiy [this message]
2020-09-09 18:59 ` [PATCH 01/14] block: return status from bdrv_append and friends Vladimir Sementsov-Ogievskiy
2020-09-10 15:51 ` Greg Kurz
2020-09-17 14:13 ` Alberto Garcia
2020-09-09 18:59 ` [PATCH 02/14] block: use return status of bdrv_append() Vladimir Sementsov-Ogievskiy
2020-09-10 16:10 ` Greg Kurz
2020-09-17 19:21 ` Vladimir Sementsov-Ogievskiy
2020-09-17 13:59 ` Alberto Garcia
2020-09-09 18:59 ` [PATCH 03/14] block: check return value of bdrv_open_child and drop error propagation Vladimir Sementsov-Ogievskiy
2020-09-10 16:21 ` Greg Kurz
2020-09-17 14:47 ` Alberto Garcia
2020-09-09 18:59 ` [PATCH 04/14] blockdev: fix drive_backup_prepare() missed error Vladimir Sementsov-Ogievskiy
2020-09-10 16:26 ` Greg Kurz
2020-09-17 13:56 ` Alberto Garcia
2020-09-09 18:59 ` [PATCH 05/14] block: drop extra error propagation for bdrv_set_backing_hd Vladimir Sementsov-Ogievskiy
2020-09-10 16:30 ` Greg Kurz
2020-09-17 13:57 ` Alberto Garcia
2020-09-09 18:59 ` [PATCH 06/14] block/mirror: drop extra error propagation in commit_active_start() Vladimir Sementsov-Ogievskiy
2020-09-10 16:32 ` Greg Kurz
2020-09-17 14:48 ` Alberto Garcia
2020-09-09 18:59 ` [PATCH 07/14] block/blklogwrites: drop error propagation Vladimir Sementsov-Ogievskiy
2020-09-10 17:24 ` Greg Kurz
2020-09-11 5:23 ` Markus Armbruster
2020-09-11 5:30 ` Markus Armbruster
2020-09-11 6:19 ` Greg Kurz
2020-09-11 14:43 ` Markus Armbruster
2020-09-10 21:01 ` Ari Sundholm
2020-09-11 8:03 ` Markus Armbruster
2020-09-16 16:52 ` Ari Sundholm
2020-09-17 7:12 ` Markus Armbruster
2020-09-09 18:59 ` [PATCH 08/14] blockjob: return status from block_job_set_speed() Vladimir Sementsov-Ogievskiy
2020-09-11 8:34 ` Greg Kurz
2020-09-17 14:01 ` Alberto Garcia
2020-09-09 18:59 ` [PATCH 09/14] block/qcow2: qcow2_get_specific_info(): drop error propagation Vladimir Sementsov-Ogievskiy
2020-09-11 8:41 ` Greg Kurz
2020-09-17 16:32 ` Alberto Garcia
2020-09-17 18:52 ` Vladimir Sementsov-Ogievskiy
2020-09-09 18:59 ` [PATCH 10/14] block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface Vladimir Sementsov-Ogievskiy
2020-09-17 16:35 ` Alberto Garcia
2020-09-17 18:58 ` Vladimir Sementsov-Ogievskiy
2020-09-09 18:59 ` [PATCH 11/14] block/qcow2-bitmap: return startus from qcow2_store_persistent_dirty_bitmaps Vladimir Sementsov-Ogievskiy
2020-09-11 9:38 ` Greg Kurz
2020-09-11 10:18 ` Vladimir Sementsov-Ogievskiy
2020-09-11 11:21 ` Greg Kurz
2020-09-11 11:39 ` Vladimir Sementsov-Ogievskiy
2020-09-11 15:22 ` Markus Armbruster
2020-09-11 17:20 ` Vladimir Sementsov-Ogievskiy
2020-09-14 6:53 ` Markus Armbruster
2020-09-17 14:50 ` Alberto Garcia
2020-09-09 18:59 ` [PATCH 12/14] block/qcow2: read_cache_sizes: return status value Vladimir Sementsov-Ogievskiy
2020-09-11 9:40 ` Greg Kurz
2020-09-17 14:51 ` Alberto Garcia
2020-09-09 18:59 ` [PATCH 13/14] block/qcow2: qcow2_do_open: deal with errp Vladimir Sementsov-Ogievskiy
2020-09-17 16:23 ` Alberto Garcia
2020-09-17 17:44 ` Vladimir Sementsov-Ogievskiy
2020-09-09 18:59 ` [PATCH 14/14] block/qed: bdrv_qed_do_open: " Vladimir Sementsov-Ogievskiy
2020-09-17 16:25 ` Alberto Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909185930.26524-1-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=ari@tuxera.com \
--cc=armbru@redhat.com \
--cc=berto@igalia.com \
--cc=eblake@redhat.com \
--cc=groug@kaod.org \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).