From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Yonggang Luo <luoyonggang@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Ed Maste <emaste@freebsd.org>,
qemu-block@nongnu.org, Stefan Weil <sw@weilnetz.de>,
Xie Changlong <xiechanglong.d@gmail.com>,
Peter Lieven <pl@kamp.de>,
qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>,
Richard Henderson <richard.henderson@linaro.org>,
Gerd Hoffmann <kraxel@redhat.com>,
Wen Congyang <wencongyang2@huawei.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Max Reitz <mreitz@redhat.com>, Li-Wen Hsu <lwhsu@freebsd.org>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH v6 25/25] meson: guard the minimal meson version to 0.55.1
Date: Thu, 10 Sep 2020 08:43:33 +0100 [thread overview]
Message-ID: <20200910074333.GB1083348@redhat.com> (raw)
In-Reply-To: <20200909184237.765-3-luoyonggang@gmail.com>
On Thu, Sep 10, 2020 at 02:42:37AM +0800, Yonggang Luo wrote:
> So we can removal usage of unstable-keyval
>
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
> meson.build | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
This prevents the use on Fedora which has 0.55.0 only. This is not
desirable merely to remove a functionally harmless warning.
>
> diff --git a/meson.build b/meson.build
> index 0b1741557d..af34a85bec 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1,14 +1,11 @@
> -project('qemu', ['c'], meson_version: '>=0.55.0',
> +project('qemu', ['c'], meson_version: '>=0.55.1',
> default_options: ['warning_level=1', 'c_std=gnu99', 'cpp_std=gnu++11',
> 'b_colorout=auto'],
> version: run_command('head', meson.source_root() / 'VERSION').stdout().strip())
>
> not_found = dependency('', required: false)
> -if meson.version().version_compare('>=0.56.0')
> - keyval = import('keyval')
> -else
> - keyval = import('unstable-keyval')
> -endif
> +keyval = import('keyval')
> +
> ss = import('sourceset')
>
> sh = find_program('sh')
> --
> 2.28.0.windows.1
>
>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2020-09-10 7:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 18:42 [PATCH v6 08/25] tests: disable /char/stdio/* tests in test-char.c on win32 Yonggang Luo
2020-09-09 18:42 ` [PATCH v6 24/25] ci: Enable msys2 ci in cirrus Yonggang Luo
2020-09-09 18:42 ` [PATCH v6 25/25] meson: guard the minimal meson version to 0.55.1 Yonggang Luo
2020-09-09 20:08 ` Paolo Bonzini
2020-09-09 20:10 ` 罗勇刚(Yonggang Luo)
2020-09-09 22:37 ` Paolo Bonzini
2020-09-10 7:43 ` Daniel P. Berrangé [this message]
2020-09-09 18:47 ` [PATCH v6 08/25] tests: disable /char/stdio/* tests in test-char.c on win32 Thomas Huth
2020-09-09 18:54 ` 罗勇刚(Yonggang Luo)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910074333.GB1083348@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=emaste@freebsd.org \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=luoyonggang@gmail.com \
--cc=lwhsu@freebsd.org \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sw@weilnetz.de \
--cc=wencongyang2@huawei.com \
--cc=xiechanglong.d@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).