From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B1C5C43461 for ; Thu, 10 Sep 2020 07:44:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A120A20795 for ; Thu, 10 Sep 2020 07:44:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="L7t6buq3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A120A20795 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGHFv-00045m-DI for qemu-devel@archiver.kernel.org; Thu, 10 Sep 2020 03:44:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40676) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGHFJ-0003aD-HE for qemu-devel@nongnu.org; Thu, 10 Sep 2020 03:43:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:60762) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kGHFH-0006wK-Ni for qemu-devel@nongnu.org; Thu, 10 Sep 2020 03:43:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599723830; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=/hxQMNJVoN3uc/qUVqb2q6/+DdeatkOD5b8YpKFEfjg=; b=L7t6buq3h01E2KVHa+e+RUXu2thcAJynD0WzZP3zvZLg9wWtOMY9AeLerxs6soNqWGMd8Q YyTpuRE/59JCfXYeI/IOdzIflz9bVO8dZV1q1VfpvH5GEcL03qoZpnBNrT2ZJrEjbo64Al xdNY2hrqqw/0hAuHEw4rQENdwt+97P0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-450-f3B68lYGO6qSpBIVTWxM6Q-1; Thu, 10 Sep 2020 03:43:45 -0400 X-MC-Unique: f3B68lYGO6qSpBIVTWxM6Q-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D71C31882FB3; Thu, 10 Sep 2020 07:43:43 +0000 (UTC) Received: from redhat.com (ovpn-112-4.ams2.redhat.com [10.36.112.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A742986584; Thu, 10 Sep 2020 07:43:36 +0000 (UTC) Date: Thu, 10 Sep 2020 08:43:33 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Yonggang Luo Subject: Re: [PATCH v6 25/25] meson: guard the minimal meson version to 0.55.1 Message-ID: <20200910074333.GB1083348@redhat.com> References: <20200909184237.765-1-luoyonggang@gmail.com> <20200909184237.765-3-luoyonggang@gmail.com> MIME-Version: 1.0 In-Reply-To: <20200909184237.765-3-luoyonggang@gmail.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/10 02:38:59 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Kevin Wolf , Ed Maste , qemu-block@nongnu.org, Stefan Weil , Xie Changlong , Peter Lieven , qemu-devel@nongnu.org, Michael Roth , Richard Henderson , Gerd Hoffmann , Wen Congyang , Paolo Bonzini , Max Reitz , Li-Wen Hsu , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Sep 10, 2020 at 02:42:37AM +0800, Yonggang Luo wrote: > So we can removal usage of unstable-keyval > > Signed-off-by: Yonggang Luo > --- > meson.build | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) This prevents the use on Fedora which has 0.55.0 only. This is not desirable merely to remove a functionally harmless warning. > > diff --git a/meson.build b/meson.build > index 0b1741557d..af34a85bec 100644 > --- a/meson.build > +++ b/meson.build > @@ -1,14 +1,11 @@ > -project('qemu', ['c'], meson_version: '>=0.55.0', > +project('qemu', ['c'], meson_version: '>=0.55.1', > default_options: ['warning_level=1', 'c_std=gnu99', 'cpp_std=gnu++11', > 'b_colorout=auto'], > version: run_command('head', meson.source_root() / 'VERSION').stdout().strip()) > > not_found = dependency('', required: false) > -if meson.version().version_compare('>=0.56.0') > - keyval = import('keyval') > -else > - keyval = import('unstable-keyval') > -endif > +keyval = import('keyval') > + > ss = import('sourceset') > > sh = find_program('sh') > -- > 2.28.0.windows.1 > > Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|