qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: [PULL v2 3/8] scripts/tracetool: Use void pointer for vcpu
Date: Thu, 10 Sep 2020 09:10:44 +0100	[thread overview]
Message-ID: <20200910081049.38393-4-stefanha@redhat.com> (raw)
In-Reply-To: <20200910081049.38393-1-stefanha@redhat.com>

From: Roman Bolshakov <r.bolshakov@yadro.com>

dtrace on macOS complains that CPUState * is used for a few probes:

  dtrace: failed to compile script trace-dtrace-root.dtrace: line 130: syntax error near "CPUState"

A comment in scripts/tracetool/__init__.py mentions that:

  We only want to allow standard C types or fixed sized
  integer types. We don't want QEMU specific types
  as we can't assume trace backends can resolve all the
  typedefs

Fixes: 3d211d9f4dbee ("trace: Add 'vcpu' event property to trace guest vCPU")
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
Message-id: 20200717093517.73397-3-r.bolshakov@yadro.com
Cc: Cameron Esfahani <dirty@apple.com>
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 scripts/tracetool/vcpu.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/tracetool/vcpu.py b/scripts/tracetool/vcpu.py
index b54e4f4e7a..868b4cb04c 100644
--- a/scripts/tracetool/vcpu.py
+++ b/scripts/tracetool/vcpu.py
@@ -24,7 +24,7 @@ def transform_event(event):
         assert "tcg-trans" not in event.properties
         assert "tcg-exec" not in event.properties
 
-        event.args = Arguments([("CPUState *", "__cpu"), event.args])
+        event.args = Arguments([("void *", "__cpu"), event.args])
         if "tcg" in event.properties:
             fmt = "\"cpu=%p \""
             event.fmt = [fmt + event.fmt[0],
-- 
2.26.2


  parent reply	other threads:[~2020-09-10  8:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10  8:10 [PULL v2 0/8] Tracing patches Stefan Hajnoczi
2020-09-10  8:10 ` [PULL v2 1/8] softmmu: Add missing trace-events file Stefan Hajnoczi
2020-09-10  8:10 ` [PULL v2 2/8] scripts/tracetool: Fix dtrace generation for macOS Stefan Hajnoczi
2020-09-10  8:10 ` Stefan Hajnoczi [this message]
2020-09-10  8:10 ` [PULL v2 4/8] net/colo: Match is-enabled probe to tracepoint Stefan Hajnoczi
2020-09-10  8:10 ` [PULL v2 5/8] scripts/cleanup-trace-events: Fix for vcpu property Stefan Hajnoczi
2020-09-10  8:10 ` [PULL v2 6/8] scripts/cleanup-trace-events: Emit files in alphabetical order Stefan Hajnoczi
2020-09-10  8:10 ` [PULL v2 7/8] trace-events: Delete unused trace points Stefan Hajnoczi
2020-09-10  8:10 ` [PULL v2 8/8] trace-events: Fix attribution of trace points to source Stefan Hajnoczi
2020-09-11 13:47 ` [PULL v2 0/8] Tracing patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200910081049.38393-4-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).