qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: [PULL v2 6/8] scripts/cleanup-trace-events: Emit files in alphabetical order
Date: Thu, 10 Sep 2020 09:10:47 +0100	[thread overview]
Message-ID: <20200910081049.38393-7-stefanha@redhat.com> (raw)
In-Reply-To: <20200910081049.38393-1-stefanha@redhat.com>

From: Markus Armbruster <armbru@redhat.com>

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-id: 20200806141334.3646302-3-armbru@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 scripts/cleanup-trace-events.pl | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/scripts/cleanup-trace-events.pl b/scripts/cleanup-trace-events.pl
index 6c3767bd6a..c40d2fcc50 100755
--- a/scripts/cleanup-trace-events.pl
+++ b/scripts/cleanup-trace-events.pl
@@ -15,12 +15,15 @@ use warnings;
 use strict;
 use File::Basename;
 
-my $buf = '';
+my @files = ();
+my $events = '';
 my %seen = ();
 
 sub out {
-    print $buf;
-    $buf = '';
+    print sort @files;
+    print $events;
+    @files = ();
+    $events = '';
     %seen = ();
 }
 
@@ -42,7 +45,7 @@ while (<IN>) {
             chomp $fname;
             next if $seen{$fname} || $fname eq 'trace-events';
             $seen{$fname} = 1;
-            $buf = "# $fname\n" . $buf;
+            push @files, "# $fname\n";
         }
         unless (close GREP) {
             die "close git grep: $!"
@@ -55,7 +58,7 @@ while (<IN>) {
     } elsif (!/^#|^$/) {
         warn "unintelligible line";
     }
-    $buf .= $_;
+    $events .= $_;
 }
 
 out;
-- 
2.26.2


  parent reply	other threads:[~2020-09-10  8:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10  8:10 [PULL v2 0/8] Tracing patches Stefan Hajnoczi
2020-09-10  8:10 ` [PULL v2 1/8] softmmu: Add missing trace-events file Stefan Hajnoczi
2020-09-10  8:10 ` [PULL v2 2/8] scripts/tracetool: Fix dtrace generation for macOS Stefan Hajnoczi
2020-09-10  8:10 ` [PULL v2 3/8] scripts/tracetool: Use void pointer for vcpu Stefan Hajnoczi
2020-09-10  8:10 ` [PULL v2 4/8] net/colo: Match is-enabled probe to tracepoint Stefan Hajnoczi
2020-09-10  8:10 ` [PULL v2 5/8] scripts/cleanup-trace-events: Fix for vcpu property Stefan Hajnoczi
2020-09-10  8:10 ` Stefan Hajnoczi [this message]
2020-09-10  8:10 ` [PULL v2 7/8] trace-events: Delete unused trace points Stefan Hajnoczi
2020-09-10  8:10 ` [PULL v2 8/8] trace-events: Fix attribution of trace points to source Stefan Hajnoczi
2020-09-11 13:47 ` [PULL v2 0/8] Tracing patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200910081049.38393-7-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).