From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: [PULL 07/10] hw/i386: make explicit clearing of pch_rev_id
Date: Thu, 10 Sep 2020 14:15:01 +0100 [thread overview]
Message-ID: <20200910131504.11341-8-alex.bennee@linaro.org> (raw)
In-Reply-To: <20200910131504.11341-1-alex.bennee@linaro.org>
Some compilers (notably the Xenial gcc in Travis) fail to spot that
this will always be set if pch_dev_id != 0xffff. Given this is setup
code and using _Pragma to override is equally as ugly lets just remove
the doubt from the compilers mind.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200909112742.25730-8-alex.bennee@linaro.org>
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 32b1453e6a8..33fa035fb7f 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -930,7 +930,7 @@ void igd_passthrough_isa_bridge_create(PCIBus *bus, uint16_t gpu_dev_id)
struct PCIDevice *bridge_dev;
int i, num;
uint16_t pch_dev_id = 0xffff;
- uint8_t pch_rev_id;
+ uint8_t pch_rev_id = 0;
num = ARRAY_SIZE(igd_combo_id_infos);
for (i = 0; i < num; i++) {
--
2.20.1
next prev parent reply other threads:[~2020-09-10 13:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 13:14 [PULL 00/10] testing and other mix fixes Alex Bennée
2020-09-10 13:14 ` [PULL 01/10] CODING_STYLE.rst: flesh out our naming conventions Alex Bennée
2020-09-10 13:14 ` [PULL 02/10] usb-host: restrict workaround to new libusb versions Alex Bennée
2020-09-11 8:49 ` Igor Mammedov
2020-09-10 13:14 ` [PULL 03/10] tests/meson.build: fp tests don't need CONFIG_TCG Alex Bennée
2020-09-10 13:14 ` [PULL 04/10] target/mips: simplify gen_compute_imm_branch logic Alex Bennée
2020-09-10 13:14 ` [PULL 05/10] docs/system/deprecated: mark ppc64abi32-linux-user for deprecation Alex Bennée
2020-09-10 13:15 ` [PULL 06/10] configure: don't enable ppc64abi32-linux-user by default Alex Bennée
2020-09-10 20:33 ` Peter Maydell
2020-09-11 8:05 ` Alex Bennée
2020-09-10 13:15 ` Alex Bennée [this message]
2020-09-10 13:15 ` [PULL 08/10] tests: bump avocado version Alex Bennée
2020-09-10 13:15 ` [PULL 09/10] tests/acceptance: Add Test.fetch_asset(cancel_on_missing=True) Alex Bennée
2020-09-10 13:15 ` [PULL 10/10] plugins: move the more involved plugins to contrib Alex Bennée
2020-09-13 19:27 ` [PULL 00/10] testing and other mix fixes Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910131504.11341-8-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).