From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DD6DC433E2 for ; Thu, 10 Sep 2020 13:28:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63A01207FB for ; Thu, 10 Sep 2020 13:28:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QcKofVbx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63A01207FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45884 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGMck-00072z-6w for qemu-devel@archiver.kernel.org; Thu, 10 Sep 2020 09:28:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36676) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGMaT-000487-RE for qemu-devel@nongnu.org; Thu, 10 Sep 2020 09:26:06 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:54918 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kGMaQ-0007zh-A3 for qemu-devel@nongnu.org; Thu, 10 Sep 2020 09:26:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599744359; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x02Kpq5uNQIQ8Yywfi65sZksO1TUZy/tcSDDcjqrvyQ=; b=QcKofVbxQ1nSr//TWaJYweBZG/vBJ9niznP3oiOvZjS9KdbWbon8JdoZzq2n+pcsW1hysF qZGcuR9EThYkCM2rrRTgLLlQzE4QNpgM9JCJOAmvBMdwKoMBCcirUj7Zb3978SquZ6B7Rv LSyGzECDoMHKj7ZM+6yTTgXaOs8Mzgo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-467-jTcfLOIjPxS_CP3S1dLuKA-1; Thu, 10 Sep 2020 09:25:58 -0400 X-MC-Unique: jTcfLOIjPxS_CP3S1dLuKA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A65BA80EDA1; Thu, 10 Sep 2020 13:25:56 +0000 (UTC) Received: from redhat.com (ovpn-112-4.ams2.redhat.com [10.36.112.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D9E927E8C1; Thu, 10 Sep 2020 13:25:53 +0000 (UTC) Date: Thu, 10 Sep 2020 14:25:50 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Chuan Zheng Subject: Re: [PATCH v1 6/7] migration/tls: add support for multifd tls-handshake Message-ID: <20200910132550.GV1083348@redhat.com> References: <1599663177-53993-1-git-send-email-zhengchuan@huawei.com> <1599663177-53993-7-git-send-email-zhengchuan@huawei.com> MIME-Version: 1.0 In-Reply-To: <1599663177-53993-7-git-send-email-zhengchuan@huawei.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.81; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/10 08:38:09 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: zhang.zhanghailiang@huawei.com, quintela@redhat.com, yuxiating@huawei.com, dgilbert@redhat.com, xiexiangyou@huawei.com, qemu-devel@nongnu.org, alex.chen@huawei.com, jinyan12@huawei.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Sep 09, 2020 at 10:52:56PM +0800, Chuan Zheng wrote: > add support for multifd tls-handshake > > Signed-off-by: Chuan Zheng > Signed-off-by: Yan Jin > --- > migration/multifd.c | 32 +++++++++++++++++++++++++++++++- > 1 file changed, 31 insertions(+), 1 deletion(-) > > diff --git a/migration/multifd.c b/migration/multifd.c > index b2076d7..2509187 100644 > --- a/migration/multifd.c > +++ b/migration/multifd.c > @@ -719,11 +719,41 @@ out: > return NULL; > } > > +static bool multifd_channel_connect(MultiFDSendParams *p, > + QIOChannel *ioc, > + Error *error); > + > +static void multifd_tls_outgoing_handshake(QIOTask *task, > + gpointer opaque) > +{ > + MultiFDSendParams *p = opaque; > + QIOChannel *ioc = QIO_CHANNEL(qio_task_get_source(task)); > + Error *err = NULL; > + > + qio_task_propagate_error(task, &err); > + multifd_channel_connect(p, ioc, err); > +} > + > static void multifd_tls_channel_connect(MultiFDSendParams *p, > QIOChannel *ioc, > Error **errp) > { > - /* TODO */ > + MigrationState *s = p->s; > + const char *hostname = s->hostname; > + QIOChannelTLS *tioc; > + > + tioc = migration_tls_client_create(s, ioc, hostname, errp); > + if (!tioc) { > + return; > + } > + > + qio_channel_set_name(QIO_CHANNEL(tioc), "multifd-tls-outgoing"); > + qio_channel_tls_handshake(tioc, > + multifd_tls_outgoing_handshake, > + p, > + NULL, > + NULL); > + > } Please squash this back into the previous patch, and both are inter-dependant on each other, and thus don't make sense to split Assuming it is squashed in Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|