qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, "Laurent Vivier" <laurent@vivier.eu>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [PULL 05/18] hw/gpio/max7310: Replace disabled printf() by qemu_log_mask(UNIMP)
Date: Fri, 11 Sep 2020 21:33:17 +0200	[thread overview]
Message-ID: <20200911193330.1148942-6-laurent@vivier.eu> (raw)
In-Reply-To: <20200911193330.1148942-1-laurent@vivier.eu>

From: Philippe Mathieu-Daudé <f4bug@amsat.org>

Replace disabled printf() by qemu_log_mask(UNIMP).

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20200901104234.92159-3-f4bug@amsat.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 hw/gpio/max7310.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/hw/gpio/max7310.c b/hw/gpio/max7310.c
index 4f78774dc8f2..3e298c2d349c 100644
--- a/hw/gpio/max7310.c
+++ b/hw/gpio/max7310.c
@@ -13,6 +13,7 @@
 #include "hw/hw.h"
 #include "hw/irq.h"
 #include "migration/vmstate.h"
+#include "qemu/log.h"
 #include "qemu/module.h"
 
 #define TYPE_MAX7310 "max7310"
@@ -68,9 +69,8 @@ static uint8_t max7310_rx(I2CSlave *i2c)
         return 0xff;
 
     default:
-#ifdef VERBOSE
-        printf("%s: unknown register %02x\n", __func__, s->command);
-#endif
+        qemu_log_mask(LOG_UNIMP, "%s: Unsupported register 0x02%" PRIx8 "\n",
+                      __func__, s->command);
         break;
     }
     return 0xff;
@@ -122,9 +122,8 @@ static int max7310_tx(I2CSlave *i2c, uint8_t data)
     case 0x00:	/* Input port - ignore writes */
         break;
     default:
-#ifdef VERBOSE
-        printf("%s: unknown register %02x\n", __func__, s->command);
-#endif
+        qemu_log_mask(LOG_UNIMP, "%s: Unsupported register 0x02%" PRIx8 "\n",
+                      __func__, s->command);
         return 1;
     }
 
-- 
2.26.2



  parent reply	other threads:[~2020-09-11 19:35 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-11 19:33 [PULL 00/18] Trivial branch for 5.2 patches Laurent Vivier
2020-09-11 19:33 ` [PULL 01/18] hw/mips/fuloong2e: Convert pointless error message to an assert() Laurent Vivier
2020-09-11 19:33 ` [PULL 02/18] hw/isa/isa-bus: Replace hw_error() by assert() Laurent Vivier
2020-09-11 19:33 ` [PULL 03/18] hw/acpi/tco: Remove unused definitions Laurent Vivier
2020-09-11 19:33 ` [PULL 04/18] hw/gpio/omap_gpio: Replace fprintf() by qemu_log_mask(GUEST_ERROR) Laurent Vivier
2020-09-11 19:33 ` Laurent Vivier [this message]
2020-09-11 19:33 ` [PULL 06/18] Makefile: Drop extra phony cscope Laurent Vivier
2020-09-11 19:33 ` [PULL 07/18] Makefile: Skip the meson subdir in cscope/TAGS/ctags Laurent Vivier
2020-09-11 19:33 ` [PULL 08/18] hw/net/e1000e: Remove overwritten read handler for STATUS register Laurent Vivier
2020-09-11 19:33 ` [PULL 09/18] hw/net/e1000e: Remove duplicated write handler for FLSWDATA register Laurent Vivier
2020-09-11 19:33 ` [PULL 10/18] meson.build: tweak sdl-image error message Laurent Vivier
2020-09-11 19:33 ` [PULL 11/18] kconfig: fix comment referring to old Makefiles Laurent Vivier
2020-09-11 19:33 ` [PULL 12/18] hw: hyperv: vmbus: Fix 32bit compilation Laurent Vivier
2020-09-11 19:33 ` [PULL 13/18] test-vmstate: remove unnecessary code in match_interval_mapping_node Laurent Vivier
2020-09-11 19:33 ` [PULL 14/18] target/i386/kvm: Rename host_tsx_blacklisted() as host_tsx_broken() Laurent Vivier
2020-09-11 19:33 ` [PULL 15/18] hw/arm/pxa2xx: Add missing fallthrough comment Laurent Vivier
2020-09-11 19:33 ` [PULL 16/18] util/hexdump: Convert to take a void pointer argument Laurent Vivier
2020-09-11 19:33 ` [PULL 17/18] util/hexdump: Reorder qemu_hexdump() arguments Laurent Vivier
2020-09-11 19:33 ` [PULL 18/18] target/i386/kvm: Add missing fallthrough comment Laurent Vivier
2020-09-12 20:16 ` [PULL 00/18] Trivial branch for 5.2 patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200911193330.1148942-6-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).