From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: marcandre.lureau@redhat.com, berrange@redhat.com,
peter.maydell@linaro.org
Subject: [RFC PATCH 0/3] Automatically convert configure options to meson build options
Date: Sun, 13 Sep 2020 12:05:31 +0200 [thread overview]
Message-ID: <20200913100534.22084-1-pbonzini@redhat.com> (raw)
Right now meson_options.txt lists less than a dozen options, but about
40 more could come as configure tests are converted and moved to
meson.build. Each option needs code in configure to parse it and pass
the option down to Meson as a -D command-line argument; in addition the
default must be duplicated between configure and meson_options.txt.
This series tries to remove the code duplication by passing unknown
--enable and --disable options to a Python program, and using
Meson's introspection support to match those to meson_options.txt
The disadvantages are:
- because we parse command-line options before meson is available,
the introspection output is stored in the source tree. The output
is slightly modified using the "jq" tool in order to ensure that it's
stable and that modifications to meson_buildoptions.txt do not cause
horrible conflicts. This is the main reason for the unattractive
diffstat (the number of JSON lines added is higher than the number
of configure lines removed, though of course the latter are code
that must be maintained manually and the former is not).
- we now need Python to generate the full help, so if Python is
missing we can only print a partial message and direct the user
to specify the interpreter with --python. It would be possible to fix
this by rewriting the script in Perl (at least on Fedora, JSON::PP is
always installed if Perl is, because it's a dependency for CPAN; I'd
have to check Ubuntu and the BSDs), or if we want to write it as a
Bourne shell script, to further massage the introspection output into
for example TAB-separated values.
Opinions are welcome on whether this is worthwhile and how to solve
the above doubts.
Paolo
Paolo Bonzini (3):
configure: quote command line arguments in config.status
configure: early test for Python
configure: automatically parse command line for meson -D options
Makefile | 6 ++
configure | 107 ++++++++-----------
docs/devel/build-system.rst | 35 +------
meson-buildoptions.json | 130 ++++++++++++++++++++++++
scripts/configure-parse-buildoptions.py | 94 +++++++++++++++++
5 files changed, 280 insertions(+), 92 deletions(-)
create mode 100644 meson-buildoptions.json
create mode 100644 scripts/configure-parse-buildoptions.py
--
2.26.2
next reply other threads:[~2020-09-13 10:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-13 10:05 Paolo Bonzini [this message]
2020-09-13 10:05 ` [PATCH 1/3] configure: quote command line arguments in config.status Paolo Bonzini
2020-09-14 19:17 ` Eric Blake
2020-09-13 10:05 ` [PATCH 2/3] configure: early test for Python Paolo Bonzini
2020-09-13 10:05 ` [PATCH 3/3] configure: automatically parse command line for meson -D options Paolo Bonzini
2020-09-14 19:20 ` Eric Blake
2020-09-13 10:15 ` [RFC PATCH 0/3] Automatically convert configure options to meson build options 罗勇刚(Yonggang Luo)
2020-09-13 13:57 ` Paolo Bonzini
2020-09-14 9:12 ` Daniel P. Berrangé
2020-09-14 10:49 ` Paolo Bonzini
2020-09-14 9:57 ` Stefan Hajnoczi
2020-09-14 10:00 ` 罗勇刚(Yonggang Luo)
2020-09-16 11:24 ` Stefan Hajnoczi
2020-09-14 10:27 ` Paolo Bonzini
2020-09-16 11:25 ` Stefan Hajnoczi
2020-09-16 13:15 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200913100534.22084-1-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).