* [PATCH] ui: Fix default window_id value
@ 2020-09-14 10:06 Samuel Thibault
2020-09-14 10:29 ` Philippe Mathieu-Daudé
2020-09-22 20:10 ` Samuel Thibault
0 siblings, 2 replies; 3+ messages in thread
From: Samuel Thibault @ 2020-09-14 10:06 UTC (permalink / raw)
To: qemu-devel, Gerd Hoffmann
./chardev/baum.c expects the default window_id value to be -1, and not 0
which could be confused with a proper window id (when numbered from 0 by
the ui backend).
This fixes getting Braille output with the curses and gtk frontends.
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
It would be useful to backport this to stable trees.
diff --git a/ui/console.c b/ui/console.c
index f8d7643fe4..beb733c833 100644
--- a/ui/console.c
+++ b/ui/console.c
@@ -1310,6 +1310,7 @@ static QemuConsole *new_console(DisplayState *ds, console_type_t console_type,
}
s->ds = ds;
s->console_type = console_type;
+ s->window_id = -1;
if (QTAILQ_EMPTY(&consoles)) {
s->index = 0;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ui: Fix default window_id value
2020-09-14 10:06 [PATCH] ui: Fix default window_id value Samuel Thibault
@ 2020-09-14 10:29 ` Philippe Mathieu-Daudé
2020-09-22 20:10 ` Samuel Thibault
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-09-14 10:29 UTC (permalink / raw)
To: Samuel Thibault, qemu-devel, Gerd Hoffmann
On 9/14/20 12:06 PM, Samuel Thibault wrote:
> ./chardev/baum.c expects the default window_id value to be -1, and not 0
> which could be confused with a proper window id (when numbered from 0 by
> the ui backend).
>
> This fixes getting Braille output with the curses and gtk frontends.
>
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Fixes: f29b3431f62 ("console: move window ID code from baum to sdl")
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> ---
> It would be useful to backport this to stable trees.
>
> diff --git a/ui/console.c b/ui/console.c
> index f8d7643fe4..beb733c833 100644
> --- a/ui/console.c
> +++ b/ui/console.c
> @@ -1310,6 +1310,7 @@ static QemuConsole *new_console(DisplayState *ds, console_type_t console_type,
> }
> s->ds = ds;
> s->console_type = console_type;
> + s->window_id = -1;
>
> if (QTAILQ_EMPTY(&consoles)) {
> s->index = 0;
>
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] ui: Fix default window_id value
2020-09-14 10:06 [PATCH] ui: Fix default window_id value Samuel Thibault
2020-09-14 10:29 ` Philippe Mathieu-Daudé
@ 2020-09-22 20:10 ` Samuel Thibault
1 sibling, 0 replies; 3+ messages in thread
From: Samuel Thibault @ 2020-09-22 20:10 UTC (permalink / raw)
To: qemu-devel, Gerd Hoffmann
./chardev/baum.c expects the default window_id value to be -1, and not 0
which could be confused with a proper window id (when numbered from 0 by
the ui backend).
This fixes getting Braille output with the curses and gtk frontends.
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Fixes: f29b3431f62 ("console: move window ID code from baum to sdl")
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
It would be useful to backport this to stable trees.
diff --git a/ui/console.c b/ui/console.c
index f8d7643fe4..beb733c833 100644
--- a/ui/console.c
+++ b/ui/console.c
@@ -1310,6 +1310,7 @@ static QemuConsole *new_console(DisplayState *ds, console_type_t console_type,
}
s->ds = ds;
s->console_type = console_type;
+ s->window_id = -1;
if (QTAILQ_EMPTY(&consoles)) {
s->index = 0;
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-22 20:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-14 10:06 [PATCH] ui: Fix default window_id value Samuel Thibault
2020-09-14 10:29 ` Philippe Mathieu-Daudé
2020-09-22 20:10 ` Samuel Thibault
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).