From: Klaus Jensen <its@irrelevant.dk>
To: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Cc: "Fam Zheng" <fam@euphon.net>, "Kevin Wolf" <kwolf@redhat.com>,
"Damien Le Moal" <damien.lemoal@wdc.com>,
qemu-block@nongnu.org, "Niklas Cassel" <niklas.cassel@wdc.com>,
"Klaus Jensen" <k.jensen@samsung.com>,
qemu-devel@nongnu.org, "Maxim Levitsky" <mlevitsk@redhat.com>,
"Alistair Francis" <alistair.francis@wdc.com>,
"Keith Busch" <kbusch@kernel.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Matias Bjorling" <matias.bjorling@wdc.com>
Subject: Re: [PATCH v3 02/15] hw/block/nvme: Report actual LBA data shift in LBAF
Date: Tue, 15 Sep 2020 09:34:21 +0200 [thread overview]
Message-ID: <20200915073421.GA499689@apples.localdomain> (raw)
In-Reply-To: <20200913221436.22844-3-dmitry.fomichev@wdc.com>
[-- Attachment #1: Type: text/plain, Size: 1432 bytes --]
On Sep 14 07:14, Dmitry Fomichev wrote:
> Calculate the data shift value to report based on the set value of
> logical_block_size device property.
>
> In the process, use a local variable to calculate the LBA format
> index instead of the hardcoded value 0. This makes the code more
> readable and it will make it easier to add support for multiple LBA
> formats in the future.
>
> Signed-off-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
> ---
> hw/block/nvme.c | 4 +++-
> hw/block/nvme.h | 11 +++++++++++
> 2 files changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> index 3a90d80694..1cfc136042 100644
> --- a/hw/block/nvme.c
> +++ b/hw/block/nvme.c
> @@ -2203,6 +2203,7 @@ static void nvme_init_namespace(NvmeCtrl *n, NvmeNamespace *ns, Error **errp)
> {
> int64_t bs_size;
> NvmeIdNs *id_ns = &ns->id_ns;
> + int lba_index;
>
> bs_size = blk_getlength(n->conf.blk);
> if (bs_size < 0) {
> @@ -2212,7 +2213,8 @@ static void nvme_init_namespace(NvmeCtrl *n, NvmeNamespace *ns, Error **errp)
>
> n->ns_size = bs_size;
>
> - id_ns->lbaf[0].ds = BDRV_SECTOR_BITS;
> + lba_index = NVME_ID_NS_FLBAS_INDEX(ns->id_ns.flbas);
> + id_ns->lbaf[lba_index].ds = nvme_ilog2(n->conf.logical_block_size);
Instead of defining a new function, we can directly use clz32().
31 - clz32(n->conf.logical_block_size)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-09-15 7:38 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-13 22:14 [PATCH v3 00/15] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set Dmitry Fomichev
2020-09-13 22:14 ` [PATCH v3 01/15] hw/block/nvme: Define 64 bit cqe.result Dmitry Fomichev
2020-09-15 7:37 ` Klaus Jensen
2020-09-15 18:56 ` Dmitry Fomichev
2020-09-15 19:55 ` Klaus Jensen
2020-09-15 20:44 ` Dmitry Fomichev
2020-09-15 20:48 ` Klaus Jensen
2020-09-18 21:10 ` Keith Busch
2020-09-21 21:39 ` Dmitry Fomichev
2020-09-13 22:14 ` [PATCH v3 02/15] hw/block/nvme: Report actual LBA data shift in LBAF Dmitry Fomichev
2020-09-15 7:34 ` Klaus Jensen [this message]
2020-09-15 18:57 ` Dmitry Fomichev
2020-09-13 22:14 ` [PATCH v3 03/15] hw/block/nvme: Add Commands Supported and Effects log Dmitry Fomichev
2020-09-13 22:14 ` [PATCH v3 04/15] hw/block/nvme: Introduce the Namespace Types definitions Dmitry Fomichev
2020-09-13 22:14 ` [PATCH v3 05/15] hw/block/nvme: Define trace events related to NS Types Dmitry Fomichev
2020-09-14 6:35 ` Philippe Mathieu-Daudé
2020-09-13 22:14 ` [PATCH v3 06/15] hw/block/nvme: Add support for Namespace Types Dmitry Fomichev
2020-09-18 21:29 ` Klaus Jensen
2020-09-18 22:22 ` Dmitry Fomichev
2020-09-13 22:14 ` [PATCH v3 07/15] hw/block/nvme: Add support for active/inactive namespaces Dmitry Fomichev
2020-09-13 22:14 ` [PATCH v3 08/15] hw/block/nvme: Make Zoned NS Command Set definitions Dmitry Fomichev
2020-09-13 22:14 ` [PATCH v3 09/15] hw/block/nvme: Define Zoned NS Command Set trace events Dmitry Fomichev
2020-09-13 22:14 ` [PATCH v3 10/15] hw/block/nvme: Support Zoned Namespace Command Set Dmitry Fomichev
2020-09-18 21:20 ` Klaus Jensen
2020-09-18 22:07 ` Dmitry Fomichev
2020-09-13 22:14 ` [PATCH v3 11/15] hw/block/nvme: Introduce max active and open zone limits Dmitry Fomichev
2020-09-13 22:14 ` [PATCH v3 12/15] hw/block/nvme: Support Zone Descriptor Extensions Dmitry Fomichev
2020-09-13 22:14 ` [PATCH v3 13/15] hw/block/nvme: Add injection of Offline/Read-Only zones Dmitry Fomichev
2020-09-13 22:14 ` [PATCH v3 14/15] hw/block/nvme: Use zone metadata file for persistence Dmitry Fomichev
2020-09-15 19:09 ` Klaus Jensen
2020-09-15 20:44 ` Dmitry Fomichev
2020-09-15 20:46 ` Klaus Jensen
2020-09-13 22:14 ` [PATCH v3 15/15] hw/block/nvme: Document zoned parameters in usage text Dmitry Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915073421.GA499689@apples.localdomain \
--to=its@irrelevant.dk \
--cc=alistair.francis@wdc.com \
--cc=damien.lemoal@wdc.com \
--cc=dmitry.fomichev@wdc.com \
--cc=fam@euphon.net \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=matias.bjorling@wdc.com \
--cc=mlevitsk@redhat.com \
--cc=niklas.cassel@wdc.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).