qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Yonggang Luo <luoyonggang@gmail.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Ed Maste <emaste@freebsd.org>,
	Michael Roth <mdroth@linux.vnet.ibm.com>,
	qemu-block@nongnu.org, Stefan Weil <sw@weilnetz.de>,
	Xie Changlong <xiechanglong.d@gmail.com>,
	Peter Lieven <pl@kamp.de>, Markus Armbruster <armbru@redhat.com>,
	Max Reitz <mreitz@redhat.com>,
	Yonggang Luo <luoyonggang@gmail.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Wen Congyang <wencongyang2@huawei.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	Li-Wen Hsu <lwhsu@freebsd.org>
Subject: [PATCH v9 19/26] tests: Fixes test-io-channel-file by mask only owner file state mask bits
Date: Tue, 15 Sep 2020 20:13:11 +0800	[thread overview]
Message-ID: <20200915121318.247-20-luoyonggang@gmail.com> (raw)
In-Reply-To: <20200915121318.247-1-luoyonggang@gmail.com>

This is the error on msys2/mingw
Running test test-io-channel-file
**
ERROR:../tests/test-io-channel-file.c:59:test_io_channel_file_helper: assertion failed (TEST_MASK & ~mask == st.st_mode & 0777): (384 == 438)
ERROR test-io-channel-file - Bail out! ERROR:../tests/test-io-channel-file.c:59:test_io_channel_file_helper: assertion failed (TEST_MASK & ~mask == st.st_mode & 0777): (384 == 438)

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
---
 tests/test-io-channel-file.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/tests/test-io-channel-file.c b/tests/test-io-channel-file.c
index bac2b07562..1b0e8d7c1b 100644
--- a/tests/test-io-channel-file.c
+++ b/tests/test-io-channel-file.c
@@ -28,6 +28,12 @@
 #define TEST_FILE "tests/test-io-channel-file.txt"
 #define TEST_MASK 0600
 
+#ifdef _WIN32
+#define TEST_MASK_EXPECT 0700
+#else
+#define TEST_MASK_EXPECT 0777
+#endif
+
 static void test_io_channel_file_helper(int flags)
 {
     QIOChannel *src, *dst;
@@ -56,7 +62,9 @@ static void test_io_channel_file_helper(int flags)
     umask(mask);
     ret = stat(TEST_FILE, &st);
     g_assert_cmpint(ret, >, -1);
-    g_assert_cmpuint(TEST_MASK & ~mask, ==, st.st_mode & 0777);
+    /* On Windows the stat() function in the C library checks only
+     the FAT-style READONLY attribute and does not look at the ACL at all. */
+    g_assert_cmpuint(TEST_MASK & ~mask, ==, st.st_mode & TEST_MASK_EXPECT);
 
     unlink(TEST_FILE);
     object_unref(OBJECT(src));
-- 
2.28.0.windows.1



  parent reply	other threads:[~2020-09-15 12:35 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-15 12:12 [PATCH v9 00/26] W32, W64 msys2/mingw patches Yonggang Luo
2020-09-15 12:12 ` [PATCH v9 01/26] rcu: Implement drain_call_rcu Yonggang Luo
2020-09-15 12:12 ` [PATCH v9 02/26] ci: fixes msys2 build by upgrading capstone to 4.0.2 Yonggang Luo
2020-09-15 12:12 ` [PATCH v9 03/26] configure: Fixes ncursesw detection under msys2/mingw and enable curses Yonggang Luo
2020-09-15 12:12 ` [PATCH v9 04/26] win32: Simplify gmtime_r detection direct base on _POSIX_THREAD_SAFE_FUNCTIONS Yonggang Luo
2020-09-15 13:00   ` Daniel P. Berrangé
2020-09-15 13:23     ` 罗勇刚(Yonggang Luo)
2020-09-15 12:12 ` [PATCH v9 05/26] curses: Fixes curses compiling errors Yonggang Luo
2020-09-15 12:12 ` [PATCH v9 06/26] tests: disable /char/stdio/* tests in test-char.c on win32 Yonggang Luo
2020-09-15 12:12 ` [PATCH v9 07/26] tests: Fixes test-replication.c on msys2/mingw Yonggang Luo
2020-09-15 12:13 ` [PATCH v9 08/26] tests: test-replication disable /replication/secondary/* " Yonggang Luo
2020-09-15 12:13 ` [PATCH v9 09/26] osdep: file locking functions are not available on Win32 Yonggang Luo
2020-09-15 12:13 ` [PATCH v9 10/26] meson: Use -b to ignore CR vs. CR-LF issues on Windows Yonggang Luo
2020-09-15 12:13 ` [PATCH v9 11/26] gcrypt: test_tls_psk_init should write binary file instead text file Yonggang Luo
2020-09-15 12:13 ` [PATCH v9 12/26] tests: Enable crypto tests under msys2/mingw Yonggang Luo
2020-09-15 13:11   ` Daniel P. Berrangé
2020-09-15 12:13 ` [PATCH v9 13/26] meson: remove empty else and duplicated gio deps Yonggang Luo
2020-09-15 12:13 ` [PATCH v9 14/26] vmstate: Fixes test-vmstate.c on msys2/mingw Yonggang Luo
2020-09-15 12:13 ` [PATCH v9 15/26] cirrus: Building freebsd in a single short Yonggang Luo
2020-09-15 12:13 ` [PATCH v9 16/26] tests: Convert g_free to g_autofree macro in test-logging.c Yonggang Luo
2020-09-15 12:13 ` [PATCH v9 17/26] tests: Fixes test-io-channel-socket.c tests under msys2/mingw Yonggang Luo
2020-09-15 12:13 ` [PATCH v9 18/26] tests: fixes aio-win32 about aio_remove_fd_handler, get it consistence with aio-posix.c Yonggang Luo
2020-09-15 12:13 ` Yonggang Luo [this message]
2020-09-15 13:15   ` [PATCH v9 19/26] tests: Fixes test-io-channel-file by mask only owner file state mask bits Daniel P. Berrangé
2020-09-15 12:13 ` [PATCH v9 20/26] tests: fix test-util-sockets.c Yonggang Luo
2020-09-15 12:13 ` [PATCH v9 21/26] tests: Fixes test-qdev-global-props.c Yonggang Luo
2020-09-15 12:13 ` [PATCH v9 22/26] rcu: fixes test-logging.c by call drain_call_rcu before rmdir_full Yonggang Luo
2020-09-15 12:13 ` [PATCH v9 23/26] meson: upgrade meson for execute custom ninjatool under msys2 properly Yonggang Luo
2020-09-15 12:13 ` [PATCH v9 24/26] ci: Enable msys2 ci in cirrus Yonggang Luo
2020-09-15 12:13 ` [PATCH v9 25/26] block: Fixes nfs compiling error on msys2/mingw Yonggang Luo
2020-09-15 12:13 ` [PATCH v9 26/26] block: enable libnfs on msys2/mingw in cirrus.yml Yonggang Luo
2020-09-15 13:00 ` [PATCH v9 00/26] W32, W64 msys2/mingw patches no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200915121318.247-20-luoyonggang@gmail.com \
    --to=luoyonggang@gmail.com \
    --cc=armbru@redhat.com \
    --cc=emaste@freebsd.org \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lwhsu@freebsd.org \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=pl@kamp.de \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=sw@weilnetz.de \
    --cc=wencongyang2@huawei.com \
    --cc=xiechanglong.d@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).