From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56ACEC43461 for ; Tue, 15 Sep 2020 11:09:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC86E21D43 for ; Tue, 15 Sep 2020 11:09:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC86E21D43 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48226 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kI8pZ-000410-TS for qemu-devel@archiver.kernel.org; Tue, 15 Sep 2020 07:09:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55290) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kI8he-0004Ew-Ll; Tue, 15 Sep 2020 07:00:51 -0400 Received: from smtpout1.mo529.mail-out.ovh.net ([178.32.125.2]:35591) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kI8hV-0006Mt-Te; Tue, 15 Sep 2020 07:00:50 -0400 Received: from mxplan5.mail.ovh.net (unknown [10.109.146.173]) by mo529.mail-out.ovh.net (Postfix) with ESMTPS id E5BEE5B47973; Tue, 15 Sep 2020 13:00:34 +0200 (CEST) Received: from kaod.org (37.59.142.100) by DAG8EX1.mxp5.local (172.16.2.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Tue, 15 Sep 2020 13:00:34 +0200 Authentication-Results: garm.ovh; auth=pass (GARM-100R00310b41507-9e73-4985-8e1d-1d30655ef92b, DB33878D1665C97D8818E18A24225F630DB8C599) smtp.auth=groug@kaod.org Date: Tue, 15 Sep 2020 13:00:33 +0200 From: Greg Kurz To: Vladimir Sementsov-Ogievskiy Subject: Re: [SPAM] Re: [PATCH 05/15] spapr: Get rid of cas_check_pvr() error reporting Message-ID: <20200915130033.0b5f5abd@bahia.lan> In-Reply-To: <1255830e-1be0-86d3-f830-a48bb9bd87b2@virtuozzo.com> References: <20200914123505.612812-1-groug@kaod.org> <20200914123505.612812-6-groug@kaod.org> <1255830e-1be0-86d3-f830-a48bb9bd87b2@virtuozzo.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [37.59.142.100] X-ClientProxiedBy: DAG9EX1.mxp5.local (172.16.2.81) To DAG8EX1.mxp5.local (172.16.2.71) X-Ovh-Tracer-GUID: 30bbdd67-5f6f-4dc8-830f-34820513ea9a X-Ovh-Tracer-Id: 11444209603587447203 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedujedrtddtgddtgecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvuffkjghfofggtgfgihesthejredtredtvdenucfhrhhomhepifhrvghgucfmuhhriicuoehgrhhouhhgsehkrghougdrohhrgheqnecuggftrfgrthhtvghrnhepfedutdeijeejveehkeeileetgfelteekteehtedtieefffevhffflefftdefleejnecukfhppedtrddtrddtrddtpdefjedrheelrddugedvrddutddtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepmhigphhlrghnhedrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehgrhhouhhgsehkrghougdrohhrghdprhgtphhtthhopegurghvihgusehgihgsshhonhdrughrohhpsggvrghrrdhiugdrrghu Received-SPF: pass client-ip=178.32.125.2; envelope-from=groug@kaod.org; helo=smtpout1.mo529.mail-out.ovh.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/15 05:34:57 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Gibson , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 15 Sep 2020 13:03:13 +0300 Vladimir Sementsov-Ogievskiy wrote: > 14.09.2020 15:34, Greg Kurz wrote: > > The cas_check_pvr() function has two purposes: > > - finding the "best" logical PVR, ie. the most recent one supported by > > the guest for this CPU type > > - checking if the guest supports the real PVR of this CPU type, which > > is just an optional extra information to workaround the lack of > > support for "compat" mode in PR KVM > > > > This logic doesn't need error reporting, really. If we don't find a > > suitable logical PVR, we return the special value 0 which is definitely > > not a valid PVR. Let the caller decide on whether it should error out > > or not. > > maybe then rename it s/cas_check_pvr/cas_find_compat_pvr/ or something like this? > Ah yes, since this function doesn't do an actual check anymore, it may be worth changing its name. > > > > This doesn't change the behavior. > > > > Signed-off-by: Greg Kurz > > Reviewed-by: Vladimir Sementsov-Ogievskiy > > >