From: Klaus Jensen <its@irrelevant.dk>
To: Dmitry Fomichev <Dmitry.Fomichev@wdc.com>
Cc: "Fam Zheng" <fam@euphon.net>, "Kevin Wolf" <kwolf@redhat.com>,
"Damien Le Moal" <Damien.LeMoal@wdc.com>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>,
"Niklas Cassel" <Niklas.Cassel@wdc.com>,
"Klaus Jensen" <k.jensen@samsung.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Alistair Francis" <Alistair.Francis@wdc.com>,
"Keith Busch" <kbusch@kernel.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Matias Bjorling" <Matias.Bjorling@wdc.com>
Subject: Re: [PATCH v3 01/15] hw/block/nvme: Define 64 bit cqe.result
Date: Tue, 15 Sep 2020 21:55:46 +0200 [thread overview]
Message-ID: <20200915195546.GA14485@apples.localdomain> (raw)
In-Reply-To: <MN2PR04MB5951ED0FD5633E8144459A28E1200@MN2PR04MB5951.namprd04.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 2006 bytes --]
On Sep 15 18:56, Dmitry Fomichev wrote:
> > -----Original Message-----
> > From: Klaus Jensen <its@irrelevant.dk>
> > Sent: Tuesday, September 15, 2020 3:37 AM
> > To: Dmitry Fomichev <Dmitry.Fomichev@wdc.com>
> > Cc: Keith Busch <kbusch@kernel.org>; Klaus Jensen
> > <k.jensen@samsung.com>; Kevin Wolf <kwolf@redhat.com>; Philippe
> > Mathieu-Daudé <philmd@redhat.com>; Maxim Levitsky
> > <mlevitsk@redhat.com>; Fam Zheng <fam@euphon.net>; Niklas Cassel
> > <Niklas.Cassel@wdc.com>; Damien Le Moal <Damien.LeMoal@wdc.com>;
> > qemu-block@nongnu.org; qemu-devel@nongnu.org; Alistair Francis
> > <Alistair.Francis@wdc.com>; Matias Bjorling <Matias.Bjorling@wdc.com>
> > Subject: Re: [PATCH v3 01/15] hw/block/nvme: Define 64 bit cqe.result
> >
> > On Sep 14 07:14, Dmitry Fomichev wrote:
> > > From: Ajay Joshi <ajay.joshi@wdc.com>
> > >
> > > A new write command, Zone Append, is added as a part of Zoned
> > > Namespace Command Set. Upon successful completion of this command,
> > > the controller returns the start LBA of the performed write operation
> > > in cqe.result field. Therefore, the maximum size of this variable
> > > needs to be changed from 32 to 64 bit, consuming the reserved 32 bit
> > > field that follows the result in CQE struct. Since the existing
> > > commands are expected to return a 32 bit LE value, two separate
> > > variables, result32 and result64, are now kept in a union.
> > >
> > > Signed-off-by: Ajay Joshi <ajay.joshi@wdc.com>
> > > Signed-off-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
> > > Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
> >
> > I know that I R-b'ed this, but can this be moved to the namespace types
> > patch, since that is the TP that changes this.
>
> You probably meant the ZNS patch since result64 is first used there to return
> ZA starting data LBA. Sure, I can move this stuff to that patch.
>
No, I actually did mean the NST patch since TP 4056 is the TP that
"unreserves" dw1 in the CQE.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-09-15 19:59 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-13 22:14 [PATCH v3 00/15] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set Dmitry Fomichev
2020-09-13 22:14 ` [PATCH v3 01/15] hw/block/nvme: Define 64 bit cqe.result Dmitry Fomichev
2020-09-15 7:37 ` Klaus Jensen
2020-09-15 18:56 ` Dmitry Fomichev
2020-09-15 19:55 ` Klaus Jensen [this message]
2020-09-15 20:44 ` Dmitry Fomichev
2020-09-15 20:48 ` Klaus Jensen
2020-09-18 21:10 ` Keith Busch
2020-09-21 21:39 ` Dmitry Fomichev
2020-09-13 22:14 ` [PATCH v3 02/15] hw/block/nvme: Report actual LBA data shift in LBAF Dmitry Fomichev
2020-09-15 7:34 ` Klaus Jensen
2020-09-15 18:57 ` Dmitry Fomichev
2020-09-13 22:14 ` [PATCH v3 03/15] hw/block/nvme: Add Commands Supported and Effects log Dmitry Fomichev
2020-09-13 22:14 ` [PATCH v3 04/15] hw/block/nvme: Introduce the Namespace Types definitions Dmitry Fomichev
2020-09-13 22:14 ` [PATCH v3 05/15] hw/block/nvme: Define trace events related to NS Types Dmitry Fomichev
2020-09-14 6:35 ` Philippe Mathieu-Daudé
2020-09-13 22:14 ` [PATCH v3 06/15] hw/block/nvme: Add support for Namespace Types Dmitry Fomichev
2020-09-18 21:29 ` Klaus Jensen
2020-09-18 22:22 ` Dmitry Fomichev
2020-09-13 22:14 ` [PATCH v3 07/15] hw/block/nvme: Add support for active/inactive namespaces Dmitry Fomichev
2020-09-13 22:14 ` [PATCH v3 08/15] hw/block/nvme: Make Zoned NS Command Set definitions Dmitry Fomichev
2020-09-13 22:14 ` [PATCH v3 09/15] hw/block/nvme: Define Zoned NS Command Set trace events Dmitry Fomichev
2020-09-13 22:14 ` [PATCH v3 10/15] hw/block/nvme: Support Zoned Namespace Command Set Dmitry Fomichev
2020-09-18 21:20 ` Klaus Jensen
2020-09-18 22:07 ` Dmitry Fomichev
2020-09-13 22:14 ` [PATCH v3 11/15] hw/block/nvme: Introduce max active and open zone limits Dmitry Fomichev
2020-09-13 22:14 ` [PATCH v3 12/15] hw/block/nvme: Support Zone Descriptor Extensions Dmitry Fomichev
2020-09-13 22:14 ` [PATCH v3 13/15] hw/block/nvme: Add injection of Offline/Read-Only zones Dmitry Fomichev
2020-09-13 22:14 ` [PATCH v3 14/15] hw/block/nvme: Use zone metadata file for persistence Dmitry Fomichev
2020-09-15 19:09 ` Klaus Jensen
2020-09-15 20:44 ` Dmitry Fomichev
2020-09-15 20:46 ` Klaus Jensen
2020-09-13 22:14 ` [PATCH v3 15/15] hw/block/nvme: Document zoned parameters in usage text Dmitry Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915195546.GA14485@apples.localdomain \
--to=its@irrelevant.dk \
--cc=Alistair.Francis@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=Dmitry.Fomichev@wdc.com \
--cc=Matias.Bjorling@wdc.com \
--cc=Niklas.Cassel@wdc.com \
--cc=fam@euphon.net \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).