From: David Gibson <david@gibson.dropbear.id.au>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH v2 4/6] target/ppc: Set instance_align on PowerPCCPU TypeInfo
Date: Wed, 16 Sep 2020 12:18:04 +1000 [thread overview]
Message-ID: <20200916021804.GB5258@yekko.fritz.box> (raw)
In-Reply-To: <20200916004638.2444147-5-richard.henderson@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1172 bytes --]
On Tue, Sep 15, 2020 at 05:46:36PM -0700, Richard Henderson wrote:
> Fix alignment of CPUPPCState.vsr.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
LGTM
Acked-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> Cc: David Gibson <david@gibson.dropbear.id.au>
> Cc: qemu-ppc@nongnu.org
> ---
> target/ppc/translate_init.c.inc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/ppc/translate_init.c.inc b/target/ppc/translate_init.c.inc
> index 230a062d29..accb4f2fae 100644
> --- a/target/ppc/translate_init.c.inc
> +++ b/target/ppc/translate_init.c.inc
> @@ -10960,6 +10960,7 @@ static const TypeInfo ppc_cpu_type_info = {
> .name = TYPE_POWERPC_CPU,
> .parent = TYPE_CPU,
> .instance_size = sizeof(PowerPCCPU),
> + .instance_align = __alignof__(PowerPCCPU),
> .instance_init = ppc_cpu_instance_init,
> .instance_finalize = ppc_cpu_instance_finalize,
> .abstract = true,
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-09-16 8:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 0:46 [PATCH v2 0/6] qom: Allow object to be aligned Richard Henderson
2020-09-16 0:46 ` [PATCH v2 1/6] util/oslib-win32: Use _aligned_malloc for qemu_try_memalign Richard Henderson
2020-09-16 3:39 ` Stefan Weil
2020-09-17 18:43 ` Eduardo Habkost
2020-09-17 20:34 ` Richard Henderson
2020-09-16 0:46 ` [PATCH v2 2/6] qom: Allow objects to be allocated with increased alignment Richard Henderson
2020-09-16 0:46 ` [PATCH v2 3/6] target/arm: Set instance_align on CPUARM TypeInfo Richard Henderson
2020-09-16 0:46 ` [PATCH v2 4/6] target/ppc: Set instance_align on PowerPCCPU TypeInfo Richard Henderson
2020-09-16 2:18 ` David Gibson [this message]
2020-09-16 0:46 ` [PATCH v2 5/6] target/riscv: Set instance_align on RISCVCPU TypeInfo Richard Henderson
2020-09-16 14:58 ` Alistair Francis
2020-09-16 0:46 ` [PATCH v2 6/6] target/s390x: Set instance_align on S390CPU TypeInfo Richard Henderson
2020-09-18 18:00 ` [PATCH v2 0/6] qom: Allow object to be aligned Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916021804.GB5258@yekko.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).