From: Igor Mammedov <imammedo@redhat.com>
To: Ani Sinha <ani@anisinha.ca>
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
jusual@redhat.com, qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH v4 00/11] i440fx/acpi: addition of feature and bug fixes.
Date: Wed, 16 Sep 2020 09:15:54 +0200 [thread overview]
Message-ID: <20200916091554.5c695601@redhat.com> (raw)
In-Reply-To: <20200916061335.14045-1-ani@anisinha.ca>
On Wed, 16 Sep 2020 11:43:24 +0530
Ani Sinha <ani@anisinha.ca> wrote:
> In v4 I have made the following changes:
>
> - a cosmetic change for patch #4. Commit log was updated as per Igor's suggestion.
> - patches #10 and #11 were added to unit test patch #9.
>
> The DSDT table after disabling hotplug on the root bus and the pci bridges is shown here:
>
> https://pastebin.ubuntu.com/p/WvpYYjpPN8/
>
> This was generated by disassembling the newly added DSDT golden master binary table blob
> DSDT.hpbrroot.
>
> I sincerely hope this is the final iteration of the set of patches. The patches has been
> unit tested on top of latest qemu upstream master branch.
usually one includes Reviewed|...|-by tags from previous version,
unless there was a functional change in a reviewed patch or you
feel that trivial changes (if any) deserve review.
> Ani Sinha (11):
> tests/acpi: document addition of table DSDT.roothp for unit testing
> root pci hotplug on/off
> tests/acpi: add a new unit test to test hotplug off/on feature on the
> root pci bus
> tests/acpi: add a new ACPI table in order to test root pci hotplug
> on/off
> Fix a gap where acpi_pcihp_find_hotplug_bus() returns a
> non-hotpluggable bus
> i440fx/acpi: do not add hotplug related amls for cold plugged bridges
> tests/acpi: list added acpi table binary file for pci bridge hotplug
> test
> tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support'
> bridge flag
> tests/acpi: add newly added acpi DSDT table blob for pci bridge
> hotplug flag
> piix4: don't reserve hw resources when hotplug is off globally
> tests/acpi: unit test exercizing hotplug off for pci root bus & bridge
> in i440fx
> tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx
> hotplug
>
> hw/acpi/pcihp.c | 15 ++++++++++
> hw/acpi/piix4.c | 6 ++--
> hw/i386/acpi-build.c | 37 ++++++++++++++---------
> tests/data/acpi/pc/DSDT.hpbridge | Bin 0 -> 4895 bytes
> tests/data/acpi/pc/DSDT.hpbrroot | Bin 0 -> 2953 bytes
> tests/data/acpi/pc/DSDT.roothp | Bin 0 -> 5130 bytes
> tests/data/acpi/q35/DSDT | Bin 7678 -> 7670 bytes
> tests/data/acpi/q35/DSDT.acpihmat | Bin 9002 -> 8994 bytes
> tests/data/acpi/q35/DSDT.bridge | Bin 7695 -> 7688 bytes
> tests/data/acpi/q35/DSDT.cphp | Bin 8141 -> 8133 bytes
> tests/data/acpi/q35/DSDT.dimmpxm | Bin 9331 -> 9323 bytes
> tests/data/acpi/q35/DSDT.ipmibt | Bin 7753 -> 7745 bytes
> tests/data/acpi/q35/DSDT.memhp | Bin 9037 -> 9029 bytes
> tests/data/acpi/q35/DSDT.mmio64 | Bin 8808 -> 8801 bytes
> tests/data/acpi/q35/DSDT.numamem | Bin 7684 -> 7676 bytes
> tests/data/acpi/q35/DSDT.tis | Bin 8283 -> 8276 bytes
> tests/qtest/bios-tables-test.c | 47 ++++++++++++++++++++++++++++++
> 17 files changed, 90 insertions(+), 15 deletions(-)
> create mode 100644 tests/data/acpi/pc/DSDT.hpbridge
> create mode 100644 tests/data/acpi/pc/DSDT.hpbrroot
> create mode 100644 tests/data/acpi/pc/DSDT.roothp
>
next prev parent reply other threads:[~2020-09-16 7:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 6:13 [PATCH v4 00/11] i440fx/acpi: addition of feature and bug fixes Ani Sinha
2020-09-16 6:13 ` [PATCH v4 01/11] tests/acpi: document addition of table DSDT.roothp for unit testing root pci hotplug on/off Ani Sinha
2020-09-16 6:13 ` [PATCH v4 02/11] tests/acpi: add a new unit test to test hotplug off/on feature on the root pci bus Ani Sinha
2020-09-16 6:35 ` Igor Mammedov
2020-09-16 6:13 ` [PATCH v4 03/11] tests/acpi: add a new ACPI table in order to test root pci hotplug on/off Ani Sinha
2020-09-16 6:36 ` Igor Mammedov
2020-09-16 6:13 ` [PATCH v4 04/11] Fix a gap where acpi_pcihp_find_hotplug_bus() returns a non-hotpluggable bus Ani Sinha
2020-09-16 6:41 ` Igor Mammedov
2020-09-16 6:13 ` [PATCH v4 05/11] i440fx/acpi: do not add hotplug related amls for cold plugged bridges Ani Sinha
2020-09-16 6:55 ` Igor Mammedov
2020-09-16 6:13 ` [PATCH v4 06/11] tests/acpi: list added acpi table binary file for pci bridge hotplug test Ani Sinha
2020-09-16 6:13 ` [PATCH v4 07/11] tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag Ani Sinha
2020-09-16 7:01 ` Igor Mammedov
2020-09-16 6:13 ` [PATCH v4 08/11] tests/acpi: add newly added acpi DSDT table blob for pci bridge hotplug flag Ani Sinha
2020-09-16 7:02 ` Igor Mammedov
2020-09-16 6:13 ` [PATCH v4 09/11] piix4: don't reserve hw resources when hotplug is off globally Ani Sinha
2020-09-16 6:13 ` [PATCH v4 10/11] tests/acpi: unit test exercizing hotplug off for pci root bus & bridge in i440fx Ani Sinha
2020-09-16 7:11 ` Igor Mammedov
2020-09-16 7:36 ` Igor Mammedov
2020-09-16 7:41 ` Thomas Huth
2020-09-16 10:57 ` Ani Sinha
2020-09-16 6:13 ` [PATCH v4 11/11] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug Ani Sinha
2020-09-16 7:15 ` Igor Mammedov [this message]
2020-09-16 7:18 ` [PATCH v4 00/11] i440fx/acpi: addition of feature and bug fixes Ani Sinha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916091554.5c695601@redhat.com \
--to=imammedo@redhat.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=ani@anisinha.ca \
--cc=aurelien@aurel32.net \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=jusual@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).