From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Cc: Yonggang Luo <luoyonggang@gmail.com>
Subject: [PULL 12/24] tests: Fixes test-replication.c on msys2/mingw.
Date: Wed, 16 Sep 2020 13:47:19 +0200 [thread overview]
Message-ID: <20200916114731.102080-13-thuth@redhat.com> (raw)
In-Reply-To: <20200916114731.102080-1-thuth@redhat.com>
From: Yonggang Luo <luoyonggang@gmail.com>
On Windows there is no path like /tmp/s_local_disk.XXXXXX
Use g_get_tmp_dir instead of /tmp.
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20200915121318.247-8-luoyonggang@gmail.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/test-replication.c | 18 ++++++++++++++----
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/tests/test-replication.c b/tests/test-replication.c
index 9ab3666a90..e7cbd6b144 100644
--- a/tests/test-replication.c
+++ b/tests/test-replication.c
@@ -23,14 +23,14 @@
/* primary */
#define P_ID "primary-id"
-static char p_local_disk[] = "/tmp/p_local_disk.XXXXXX";
+static char *p_local_disk;
/* secondary */
#define S_ID "secondary-id"
#define S_LOCAL_DISK_ID "secondary-local-disk-id"
-static char s_local_disk[] = "/tmp/s_local_disk.XXXXXX";
-static char s_active_disk[] = "/tmp/s_active_disk.XXXXXX";
-static char s_hidden_disk[] = "/tmp/s_hidden_disk.XXXXXX";
+static char *s_local_disk;
+static char *s_active_disk;
+static char *s_hidden_disk;
/* FIXME: steal from blockdev.c */
QemuOptsList qemu_drive_opts = {
@@ -571,6 +571,11 @@ static void setup_sigabrt_handler(void)
int main(int argc, char **argv)
{
int ret;
+ const char *tmpdir = g_get_tmp_dir();
+ p_local_disk = g_strdup_printf("%s/p_local_disk.XXXXXX", tmpdir);
+ s_local_disk = g_strdup_printf("%s/s_local_disk.XXXXXX", tmpdir);
+ s_active_disk = g_strdup_printf("%s/s_active_disk.XXXXXX", tmpdir);
+ s_hidden_disk = g_strdup_printf("%s/s_hidden_disk.XXXXXX", tmpdir);
qemu_init_main_loop(&error_fatal);
bdrv_init();
@@ -605,5 +610,10 @@ int main(int argc, char **argv)
cleanup_imgs();
+ g_free(p_local_disk);
+ g_free(s_local_disk);
+ g_free(s_active_disk);
+ g_free(s_hidden_disk);
+
return ret;
}
--
2.18.2
next prev parent reply other threads:[~2020-09-16 11:57 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 11:47 [PULL 00/24] qtests, unit tests and Cirrus-CI fixes / improvements Thomas Huth
2020-09-16 11:47 ` [PULL 01/24] iotests: Drop readlink -f Thomas Huth
2020-09-16 11:47 ` [PULL 02/24] fuzz: Change the way we write qtest log to stderr Thomas Huth
2020-09-16 11:47 ` [PULL 03/24] tests/qtest/qmp-cmd-test: Use inclusive language Thomas Huth
2020-09-16 11:47 ` [PULL 04/24] tests/socket-helpers: Treat EAI_NONAME as EADDRNOTAVAIL Thomas Huth
2020-09-16 11:47 ` [PULL 05/24] Simplify the .gitignore file Thomas Huth
2020-09-18 17:33 ` Peter Maydell
2020-09-19 10:12 ` Thomas Huth
2020-09-16 11:47 ` [PULL 06/24] qga/commands-win32: Fix problem with redundant protype declaration Thomas Huth
2020-09-16 11:47 ` [PULL 07/24] rcu: Implement drain_call_rcu Thomas Huth
2020-09-16 11:47 ` [PULL 08/24] tests: Convert g_free to g_autofree macro in test-logging.c Thomas Huth
2020-09-16 11:47 ` [PULL 09/24] rcu: fixes test-logging.c by call drain_call_rcu before rmdir_full Thomas Huth
2020-09-16 11:47 ` [PULL 10/24] meson: Disable test-char on msys2/mingw for fixing tests stuck Thomas Huth
2020-09-16 11:47 ` [PULL 11/24] meson: disable crypto tests are empty under win32 Thomas Huth
2020-09-16 11:47 ` Thomas Huth [this message]
2020-09-16 11:47 ` [PULL 13/24] tests: test-replication disable /replication/secondary/* on msys2/mingw Thomas Huth
2020-09-16 11:47 ` [PULL 14/24] osdep: file locking functions are not available on Win32 Thomas Huth
2020-09-16 11:47 ` [PULL 15/24] meson: Use -b to ignore CR vs. CR-LF issues on Windows Thomas Huth
2020-09-16 11:47 ` [PULL 16/24] meson: remove empty else and duplicated gio deps Thomas Huth
2020-09-16 11:47 ` [PULL 17/24] vmstate: Fixes test-vmstate.c on msys2/mingw Thomas Huth
2020-09-16 11:47 ` [PULL 18/24] tests: Fixes test-io-channel-socket.c tests under msys2/mingw Thomas Huth
2020-09-16 11:47 ` [PULL 19/24] tests: fixes aio-win32 about aio_remove_fd_handler, get it consistence with aio-posix.c Thomas Huth
2020-09-16 11:47 ` [PULL 20/24] tests: Fixes test-io-channel-file by mask only owner file state mask bits Thomas Huth
2020-09-16 11:47 ` [PULL 21/24] tests: fix test-util-sockets.c Thomas Huth
2020-09-16 11:47 ` [PULL 22/24] tests: Fixes test-qdev-global-props.c Thomas Huth
2020-09-16 11:47 ` [PULL 23/24] ci: Enable msys2 ci in cirrus Thomas Huth
2020-09-16 11:47 ` [PULL 24/24] cirrus: Building freebsd in a single shot Thomas Huth
2020-09-17 13:46 ` [PULL 00/24] qtests, unit tests and Cirrus-CI fixes / improvements Peter Maydell
2020-09-17 14:40 ` 罗勇刚(Yonggang Luo)
2020-09-17 15:12 ` Thomas Huth
2020-09-17 15:14 ` Peter Maydell
2020-09-17 15:28 ` Thomas Huth
2020-09-17 15:30 ` Peter Maydell
2020-09-18 11:32 ` Thomas Huth
2020-09-17 16:33 ` 罗勇刚(Yonggang Luo)
2020-09-17 16:40 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916114731.102080-13-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=luoyonggang@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).