From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Cc: Yonggang Luo <luoyonggang@gmail.com>
Subject: [PULL 18/24] tests: Fixes test-io-channel-socket.c tests under msys2/mingw
Date: Wed, 16 Sep 2020 13:47:25 +0200 [thread overview]
Message-ID: <20200916114731.102080-19-thuth@redhat.com> (raw)
In-Reply-To: <20200916114731.102080-1-thuth@redhat.com>
From: Yonggang Luo <luoyonggang@gmail.com>
Currently test-io-channel-socket doesn't init with
qemu_init_main_loop
and that's cause the qemu_aio_context not inited,
and the following is the stack when null pointer accessed:
qemu_fd_register (c:\work\xemu\qemu\util\main-loop.c:336)
qemu_try_set_nonblock (c:\work\xemu\qemu\util\oslib-win32.c:224)
qemu_set_nonblock (c:\work\xemu\qemu\util\oslib-win32.c:230)
socket_can_bind_connect (c:\work\xemu\qemu\tests\socket-helpers.c:93)
socket_check_protocol_support (c:\work\xemu\qemu\tests\socket-helpers.c:141)
main (c:\work\xemu\qemu\tests\test-io-channel-socket.c:568)
__tmainCRTStartup (@__tmainCRTStartup:142)
mainCRTStartup (@1400014f6..140001539:3)
BaseThreadInitThunk (@BaseThreadInitThunk:9)
RtlUserThreadStart (@RtlUserThreadStart:12)
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20200915121318.247-18-luoyonggang@gmail.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/test-io-channel-socket.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/test-io-channel-socket.c b/tests/test-io-channel-socket.c
index d43083a766..743577d744 100644
--- a/tests/test-io-channel-socket.c
+++ b/tests/test-io-channel-socket.c
@@ -25,6 +25,7 @@
#include "socket-helpers.h"
#include "qapi/error.h"
#include "qemu/module.h"
+#include "qemu/main-loop.h"
static void test_io_channel_set_socket_bufs(QIOChannel *src,
@@ -556,6 +557,7 @@ int main(int argc, char **argv)
bool has_ipv4, has_ipv6;
module_call_init(MODULE_INIT_QOM);
+ qemu_init_main_loop(&error_abort);
socket_init();
g_test_init(&argc, &argv, NULL);
--
2.18.2
next prev parent reply other threads:[~2020-09-16 11:52 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 11:47 [PULL 00/24] qtests, unit tests and Cirrus-CI fixes / improvements Thomas Huth
2020-09-16 11:47 ` [PULL 01/24] iotests: Drop readlink -f Thomas Huth
2020-09-16 11:47 ` [PULL 02/24] fuzz: Change the way we write qtest log to stderr Thomas Huth
2020-09-16 11:47 ` [PULL 03/24] tests/qtest/qmp-cmd-test: Use inclusive language Thomas Huth
2020-09-16 11:47 ` [PULL 04/24] tests/socket-helpers: Treat EAI_NONAME as EADDRNOTAVAIL Thomas Huth
2020-09-16 11:47 ` [PULL 05/24] Simplify the .gitignore file Thomas Huth
2020-09-18 17:33 ` Peter Maydell
2020-09-19 10:12 ` Thomas Huth
2020-09-16 11:47 ` [PULL 06/24] qga/commands-win32: Fix problem with redundant protype declaration Thomas Huth
2020-09-16 11:47 ` [PULL 07/24] rcu: Implement drain_call_rcu Thomas Huth
2020-09-16 11:47 ` [PULL 08/24] tests: Convert g_free to g_autofree macro in test-logging.c Thomas Huth
2020-09-16 11:47 ` [PULL 09/24] rcu: fixes test-logging.c by call drain_call_rcu before rmdir_full Thomas Huth
2020-09-16 11:47 ` [PULL 10/24] meson: Disable test-char on msys2/mingw for fixing tests stuck Thomas Huth
2020-09-16 11:47 ` [PULL 11/24] meson: disable crypto tests are empty under win32 Thomas Huth
2020-09-16 11:47 ` [PULL 12/24] tests: Fixes test-replication.c on msys2/mingw Thomas Huth
2020-09-16 11:47 ` [PULL 13/24] tests: test-replication disable /replication/secondary/* " Thomas Huth
2020-09-16 11:47 ` [PULL 14/24] osdep: file locking functions are not available on Win32 Thomas Huth
2020-09-16 11:47 ` [PULL 15/24] meson: Use -b to ignore CR vs. CR-LF issues on Windows Thomas Huth
2020-09-16 11:47 ` [PULL 16/24] meson: remove empty else and duplicated gio deps Thomas Huth
2020-09-16 11:47 ` [PULL 17/24] vmstate: Fixes test-vmstate.c on msys2/mingw Thomas Huth
2020-09-16 11:47 ` Thomas Huth [this message]
2020-09-16 11:47 ` [PULL 19/24] tests: fixes aio-win32 about aio_remove_fd_handler, get it consistence with aio-posix.c Thomas Huth
2020-09-16 11:47 ` [PULL 20/24] tests: Fixes test-io-channel-file by mask only owner file state mask bits Thomas Huth
2020-09-16 11:47 ` [PULL 21/24] tests: fix test-util-sockets.c Thomas Huth
2020-09-16 11:47 ` [PULL 22/24] tests: Fixes test-qdev-global-props.c Thomas Huth
2020-09-16 11:47 ` [PULL 23/24] ci: Enable msys2 ci in cirrus Thomas Huth
2020-09-16 11:47 ` [PULL 24/24] cirrus: Building freebsd in a single shot Thomas Huth
2020-09-17 13:46 ` [PULL 00/24] qtests, unit tests and Cirrus-CI fixes / improvements Peter Maydell
2020-09-17 14:40 ` 罗勇刚(Yonggang Luo)
2020-09-17 15:12 ` Thomas Huth
2020-09-17 15:14 ` Peter Maydell
2020-09-17 15:28 ` Thomas Huth
2020-09-17 15:30 ` Peter Maydell
2020-09-18 11:32 ` Thomas Huth
2020-09-17 16:33 ` 罗勇刚(Yonggang Luo)
2020-09-17 16:40 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916114731.102080-19-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=luoyonggang@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).