From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99033C433E2 for ; Thu, 17 Sep 2020 09:39:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 407782076D for ; Thu, 17 Sep 2020 09:39:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="C/kRQYWK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 407782076D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37580 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIqNX-0006mB-AT for qemu-devel@archiver.kernel.org; Thu, 17 Sep 2020 05:38:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51412) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIqMo-0006Ki-Gf for qemu-devel@nongnu.org; Thu, 17 Sep 2020 05:38:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:46364) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kIqMi-0007WP-18 for qemu-devel@nongnu.org; Thu, 17 Sep 2020 05:38:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600335487; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cTDXyBM6kDc0Fk7doLQSjsRo4EWnmIGY+mAh8+vEQk8=; b=C/kRQYWK9/eP6D6h1yVX/MjqIwzKaHF/9xbatqmkEhvT4FhfUUdjqnPRFdxWSTg6cwCwo/ by33yk8QM1ttbiQ2XKtTBlrZuVmLY+muTVO75o0l2CmJFGESazr9rYcfhOCCDGEFAJZutM alVoeyporozmWK1R/eixUsHgFNxoxEw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-223-It1_qH4DPr2wH340MNU6eg-1; Thu, 17 Sep 2020 05:38:03 -0400 X-MC-Unique: It1_qH4DPr2wH340MNU6eg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CF200195D563; Thu, 17 Sep 2020 09:38:01 +0000 (UTC) Received: from redhat.com (ovpn-114-29.ams2.redhat.com [10.36.114.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5D1BA1002D41; Thu, 17 Sep 2020 09:37:59 +0000 (UTC) Date: Thu, 17 Sep 2020 10:37:56 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: QEMU policy for real file tests Message-ID: <20200917093756.GC1568038@redhat.com> References: <1836935.RIYQIvKipu@silver> <87y2l8ycs3.fsf@linaro.org> MIME-Version: 1.0 In-Reply-To: <87y2l8ycs3.fsf@linaro.org> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/17 02:01:40 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -50 X-Spam_score: -5.1 X-Spam_bar: ----- X-Spam_report: (-5.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.999, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Kevin Wolf , Peter Maydell , Thomas Huth , Laurent Vivier , Christian Schoenebeck , qemu-devel@nongnu.org, Greg Kurz , Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Sep 17, 2020 at 10:26:36AM +0100, Alex Bennée wrote: > > Christian Schoenebeck writes: > > > Hi, > > > > is there a QEMU policy for test cases that create/write/read/delete real files > > and directories? E.g. should they be situated at a certain location and is any > > measure of sandboxing required? > > I don't think we have a hard and fast policy. It also depends on what > you are doing the test in - but ideally you should use a secure mktempd > (that can't clash) and clean-up after you are finished. This is a bit > easier in python than shell I think. mktempd will end up on /tmp usually which can be tmpfs and size limited, so be mindful of the size of files you create. Don't assume you can create multi-GB sized files ! Creating a temp dir underneath the build dir (effectively CWD of the test) is a reasonable alternative. > For example iotests end up in $BUILD_DIR/scratch (driven by TEST_DIR > being set somewhere) whereas the gdb stub tests use socket_dir = > TemporaryDirectory("qemu-gdbstub") which get auto-cleaned when it > finishes. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|