From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1498BC433E2 for ; Thu, 17 Sep 2020 07:51:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9760321973 for ; Thu, 17 Sep 2020 07:51:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VXzL1pER" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9760321973 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47698 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIohA-0003xK-JP for qemu-devel@archiver.kernel.org; Thu, 17 Sep 2020 03:51:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50500) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIodn-0007Ok-Rn for qemu-devel@nongnu.org; Thu, 17 Sep 2020 03:47:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:29572) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kIodk-0004km-Fa for qemu-devel@nongnu.org; Thu, 17 Sep 2020 03:47:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600328855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/1lurTq5n5TI0TwpvZGZbnQLRV2vILXZ/Cw0++RY9UM=; b=VXzL1pERhFFoayQYzJ2F8OivYo40cH4tvYGVqlc7PwBcr6uzSvnz8gv4nyd292sfrvXfx+ 9GAzuFxKnpWjkWAYVKLNNIO0LIgmvnIPsEWw2VqLs2FJQVwtlE+B69ke81Yv3QM5GPBUa7 LYKElH2gC0qQbKz9Jjd7EsrSOvptQTE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-289-723UZI3VOhWnD206aaQuRA-1; Thu, 17 Sep 2020 03:47:33 -0400 X-MC-Unique: 723UZI3VOhWnD206aaQuRA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1C9371084C96; Thu, 17 Sep 2020 07:47:28 +0000 (UTC) Received: from gondolin (ovpn-113-19.ams2.redhat.com [10.36.113.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id C694C5DEBF; Thu, 17 Sep 2020 07:46:59 +0000 (UTC) Date: Thu, 17 Sep 2020 09:46:57 +0200 From: Cornelia Huck To: Eduardo Habkost Subject: Re: [PATCH 3/5] qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros Message-ID: <20200917094657.392c341d.cohuck@redhat.com> In-Reply-To: <20200916182519.415636-4-ehabkost@redhat.com> References: <20200916182519.415636-1-ehabkost@redhat.com> <20200916182519.415636-4-ehabkost@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/17 02:01:40 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -50 X-Spam_score: -5.1 X-Spam_bar: ----- X-Spam_report: (-5.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.999, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , Sarah Harris , Sagar Karandikar , "Michael S. Tsirkin" , Anthony Green , Mark Cave-Ayland , qemu-devel@nongnu.org, Jiaxun Yang , Max Filippov , Gerd Hoffmann , "Edgar E. Iglesias" , Guan Xuetao , Marek Vasut , Stefano Stabellini , xen-devel@lists.xenproject.org, Yoshinori Sato , David Hildenbrand , Halil Pasic , Christian Borntraeger , Aleksandar Markovic , "Gonglei \(Arei\)" , Anthony Perard , =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau , Richard Henderson , Artyom Tarasenko , Laurent Vivier , Thomas Huth , Amit Shah , Alistair Francis , Paul Durrant , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Michael Rolnik , =?UTF-8?B?Q8OpZHJpYw==?= Le Goater , Igor Mammedov , qemu-ppc@nongnu.org, Stafford Horne , Palmer Dabbelt , David Gibson , "Daniel P. Berrange" , qemu-block@nongnu.org, qemu-riscv@nongnu.org, Bastian Koppelmann , Chris Wulff , Philippe =?UTF-8?B?TWF0aGlldS1EYXVk?= =?UTF-8?B?w6k=?= , Michael Walle , Corey Minyard , Paolo Bonzini , Aleksandar Rikalo , Aurelien Jarno , Stefan Berger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 16 Sep 2020 14:25:17 -0400 Eduardo Habkost wrote: > One of the goals of having less boilerplate on QOM declarations > is to avoid human error. Requiring an extra argument that is > never used is an opportunity for mistakes. > > Remove the unused argument from OBJECT_DECLARE_TYPE and > OBJECT_DECLARE_SIMPLE_TYPE. > > Coccinelle patch used to convert all users of the macros: > > @@ > declarer name OBJECT_DECLARE_TYPE; > identifier InstanceType, ClassType, lowercase, UPPERCASE; > @@ > OBJECT_DECLARE_TYPE(InstanceType, ClassType, > - lowercase, > UPPERCASE); > > @@ > declarer name OBJECT_DECLARE_SIMPLE_TYPE; > identifier InstanceType, lowercase, UPPERCASE; > @@ > OBJECT_DECLARE_SIMPLE_TYPE(InstanceType, > - lowercase, > UPPERCASE); > > Signed-off-by: Eduardo Habkost Acked-by: Cornelia Huck