From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: pbonzini@redhat.com, groug@kaod.org, qemu-devel@nongnu.org,
ehabkost@redhat.com
Subject: Re: [PATCH 2/2] qom: Correct error values in two contracts
Date: Thu, 17 Sep 2020 13:59:24 +0100 [thread overview]
Message-ID: <20200917125924.GD1597829@redhat.com> (raw)
In-Reply-To: <20200917125540.597786-3-armbru@redhat.com>
On Thu, Sep 17, 2020 at 02:55:40PM +0200, Markus Armbruster wrote:
> object_property_get_bool()'s contract claims it returns NULL on error.
> Pasto; it returns false.
>
> object_property_get_int()'s contract claims it returns "negative". It
> actually returns -1. All the other object_property_get_FOO()
> contracts specify the exact error value, so do the same here.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> include/qom/object.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2020-09-17 13:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 12:55 [PATCH 0/2] qpm: Minor error value corrections Markus Armbruster
2020-09-17 12:55 ` [PATCH 1/2] qom: Clean up object_property_get_enum()'s error value Markus Armbruster
2020-09-17 12:59 ` Daniel P. Berrangé
2020-09-17 13:25 ` Greg Kurz
2020-09-17 12:55 ` [PATCH 2/2] qom: Correct error values in two contracts Markus Armbruster
2020-09-17 12:59 ` Daniel P. Berrangé [this message]
2020-09-17 13:31 ` Greg Kurz
2020-09-17 13:03 ` [PATCH 0/2] qpm: Minor error value corrections no-reply
2020-09-17 13:06 ` no-reply
2020-09-17 17:28 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917125924.GD1597829@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=groug@kaod.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).