From: Cornelia Huck <cohuck@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v2] virtio: skip legacy support check on machine types less than 5.1
Date: Thu, 17 Sep 2020 13:00:08 +0200 [thread overview]
Message-ID: <20200917130008.79a1637b.cohuck@redhat.com> (raw)
In-Reply-To: <20200917104721.pbfik4t6zszflama@steredhat>
On Thu, 17 Sep 2020 12:47:21 +0200
Stefano Garzarella <sgarzare@redhat.com> wrote:
> Okay, so I'll leave the device property.
>
>
> I also need to update a series [1] that I sent to force virtio version 1
> on vhost-vsock devices.
> Also in this case I need to care about migration and force it only on new
> machine types.
>
> Do you think I can reuse the same property also in vhost-vsock-pci and
> vhost-vsock-ccw to force virtio version 1, or it is better to add a new
> property for each device.
>
> The two things (disable legacy check and force version 1) are related,
> so maybe I can use a single property in the virtio-device class,
So, 'x-disable-legacy-check==false' -> 'we need to force version 1'?
Seems reasonable to me.
>
> Thanks,
> Stefano
>
> [1] https://lists.nongnu.org/archive/html/qemu-devel/2020-08/msg04437.html
>
next prev parent reply other threads:[~2020-09-17 11:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 13:05 [PATCH v2] virtio: skip legacy support check on machine types less than 5.1 Stefano Garzarella
2020-09-16 7:32 ` Stefano Garzarella
2020-09-16 9:08 ` Cornelia Huck
2020-09-17 8:48 ` Stefano Garzarella
2020-09-17 9:22 ` Cornelia Huck
2020-09-17 10:00 ` Dr. David Alan Gilbert
2020-09-17 10:47 ` Stefano Garzarella
2020-09-17 11:00 ` Cornelia Huck [this message]
2020-09-17 12:09 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917130008.79a1637b.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).