qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Laurent Vivier" <lvivier@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Sergio Lopez" <slp@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Shannon Zhao" <shannon.zhaosl@gmail.com>,
	qemu-arm@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>
Subject: [PULL 01/21] microvm: name qboot binary qboot.rom
Date: Thu, 17 Sep 2020 15:53:03 +0200	[thread overview]
Message-ID: <20200917135323.18022-2-kraxel@redhat.com> (raw)
In-Reply-To: <20200917135323.18022-1-kraxel@redhat.com>

qboot isn't a bios and shouldnt be named that way.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Sergio Lopez <slp@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20200915120909.20838-2-kraxel@redhat.com
---
 hw/i386/microvm.c                       |   4 ++--
 pc-bios/meson.build                     |   2 +-
 pc-bios/{bios-microvm.bin => qboot.rom} | Bin
 roms/Makefile                           |   6 +++---
 4 files changed, 6 insertions(+), 6 deletions(-)
 rename pc-bios/{bios-microvm.bin => qboot.rom} (100%)

diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c
index 81d0888930d1..b1dc7e49c159 100644
--- a/hw/i386/microvm.c
+++ b/hw/i386/microvm.c
@@ -47,7 +47,7 @@
 #include "kvm_i386.h"
 #include "hw/xen/start_info.h"
 
-#define MICROVM_BIOS_FILENAME "bios-microvm.bin"
+#define MICROVM_QBOOT_FILENAME "qboot.rom"
 
 static void microvm_set_rtc(MicrovmMachineState *mms, ISADevice *s)
 {
@@ -158,7 +158,7 @@ static void microvm_devices_init(MicrovmMachineState *mms)
     }
 
     if (bios_name == NULL) {
-        bios_name = MICROVM_BIOS_FILENAME;
+        bios_name = MICROVM_QBOOT_FILENAME;
     }
     x86_bios_rom_init(get_system_memory(), true);
 }
diff --git a/pc-bios/meson.build b/pc-bios/meson.build
index 182d5ebb35de..9759dba09714 100644
--- a/pc-bios/meson.build
+++ b/pc-bios/meson.build
@@ -27,7 +27,7 @@ endif
 blobs = files(
   'bios.bin',
   'bios-256k.bin',
-  'bios-microvm.bin',
+  'qboot.rom',
   'sgabios.bin',
   'vgabios.bin',
   'vgabios-cirrus.bin',
diff --git a/pc-bios/bios-microvm.bin b/pc-bios/qboot.rom
similarity index 100%
rename from pc-bios/bios-microvm.bin
rename to pc-bios/qboot.rom
diff --git a/roms/Makefile b/roms/Makefile
index 3726f06fe7eb..1395a46695be 100644
--- a/roms/Makefile
+++ b/roms/Makefile
@@ -68,7 +68,7 @@ default help:
 	@echo "  efi                -- update UEFI (edk2) platform firmware"
 	@echo "  opensbi32-generic  -- update OpenSBI for 32-bit generic machine"
 	@echo "  opensbi64-generic  -- update OpenSBI for 64-bit generic machine"
-	@echo "  bios-microvm       -- update bios-microvm.bin (qboot)"
+	@echo "  qboot              -- update qboot"
 	@echo "  clean              -- delete the files generated by the previous" \
 	                              "build targets"
 
@@ -183,9 +183,9 @@ opensbi64-generic:
 	cp opensbi/build/platform/generic/firmware/fw_dynamic.bin ../pc-bios/opensbi-riscv64-generic-fw_dynamic.bin
 	cp opensbi/build/platform/generic/firmware/fw_dynamic.elf ../pc-bios/opensbi-riscv64-generic-fw_dynamic.elf
 
-bios-microvm:
+qboot:
 	$(MAKE) -C qboot
-	cp qboot/bios.bin ../pc-bios/bios-microvm.bin
+	cp qboot/bios.bin ../pc-bios/qboot.rom
 
 npcm7xx_bootrom:
 	$(MAKE) -C vbootrom CROSS_COMPILE=$(arm_cross_prefix)
-- 
2.27.0



  reply	other threads:[~2020-09-17 13:55 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-17 13:53 [PULL 00/21] Microvm 20200917 patches Gerd Hoffmann
2020-09-17 13:53 ` Gerd Hoffmann [this message]
2020-09-17 13:53 ` [PULL 02/21] seabios: add microvm config, update build rules Gerd Hoffmann
2020-09-17 13:53 ` [PULL 03/21] seabios: add bios-microvm.bin binary Gerd Hoffmann
2020-09-17 13:53 ` [PULL 04/21] acpi: ged: add control regs Gerd Hoffmann
2021-06-24  9:17   ` Peter Maydell
2021-06-24  9:42     ` Gerd Hoffmann
2020-09-17 13:53 ` [PULL 05/21] acpi: ged: add x86 device variant Gerd Hoffmann
2020-09-17 13:53 ` [PULL 06/21] acpi: move acpi_dsdt_add_power_button() to ged Gerd Hoffmann
2020-09-17 13:53 ` [PULL 07/21] microvm: make virtio irq base runtime configurable Gerd Hoffmann
2020-09-17 13:53 ` [PULL 08/21] microvm/acpi: add minimal acpi support Gerd Hoffmann
2020-09-17 13:53 ` [PULL 09/21] microvm/acpi: add acpi_dsdt_add_virtio() for x86 Gerd Hoffmann
2020-09-17 13:53 ` [PULL 10/21] microvm/acpi: use GSI 16-23 for virtio Gerd Hoffmann
2020-09-17 13:53 ` [PULL 11/21] microvm/acpi: use seabios with acpi=on Gerd Hoffmann
2020-09-17 13:53 ` [PULL 12/21] microvm/acpi: disable virtio-mmio cmdline hack Gerd Hoffmann
2020-09-17 13:53 ` [PULL 13/21] x86: constify x86_machine_is_*_enabled Gerd Hoffmann
2020-09-17 13:53 ` [PULL 14/21] x86: move acpi_dev from pc/microvm Gerd Hoffmann
2020-09-17 13:53 ` [PULL 15/21] x86: move cpu hotplug from pc to x86 Gerd Hoffmann
2020-09-17 13:53 ` [PULL 16/21] microvm: wire up hotplug Gerd Hoffmann
2020-09-17 13:53 ` [PULL 17/21] tests/acpi: allow microvm test data updates Gerd Hoffmann
2020-09-17 13:53 ` [PULL 18/21] tests/acpi: allow override blkdev Gerd Hoffmann
2020-09-17 13:53 ` [PULL 19/21] tests/acpi: add microvm test Gerd Hoffmann
2020-09-17 13:53 ` [PULL 20/21] tests/acpi: update expected data files for microvm Gerd Hoffmann
2020-09-17 13:53 ` [PULL 21/21] microvm: enable ramfb Gerd Hoffmann
2020-09-18  9:35 ` [PULL 00/21] Microvm 20200917 patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200917135323.18022-2-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=shannon.zhaosl@gmail.com \
    --cc=slp@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).