* [PATCH] meson: fix static flag summary
@ 2020-09-17 14:07 Laurent Vivier
2020-09-17 14:25 ` Paolo Bonzini
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Laurent Vivier @ 2020-09-17 14:07 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Paolo Bonzini, Laurent Vivier
'static build:' must display value of CONFIG_STATIC rather than value of
CONFIG_TOOLS.
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 5421eca66a02..c174f0ab0948 100644
--- a/meson.build
+++ b/meson.build
@@ -1374,7 +1374,7 @@ summary_info += {'gprof enabled': config_host.has_key('CONFIG_GPROF')}
summary_info += {'sparse enabled': meson.get_compiler('c').cmd_array().contains('cgcc')}
summary_info += {'strip binaries': get_option('strip')}
summary_info += {'profiler': config_host.has_key('CONFIG_PROFILER')}
-summary_info += {'static build': config_host.has_key('CONFIG_TOOLS')}
+summary_info += {'static build': config_host.has_key('CONFIG_STATIC')}
if targetos == 'darwin'
summary_info += {'Cocoa support': config_host.has_key('CONFIG_COCOA')}
endif
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] meson: fix static flag summary
2020-09-17 14:07 [PATCH] meson: fix static flag summary Laurent Vivier
@ 2020-09-17 14:25 ` Paolo Bonzini
2020-09-17 14:43 ` Philippe Mathieu-Daudé
2020-09-23 17:07 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2020-09-17 14:25 UTC (permalink / raw)
To: Laurent Vivier; +Cc: qemu-trivial, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]
Oops. :)
Paolo
Il gio 17 set 2020, 16:07 Laurent Vivier <lvivier@redhat.com> ha scritto:
> 'static build:' must display value of CONFIG_STATIC rather than value of
> CONFIG_TOOLS.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 5421eca66a02..c174f0ab0948 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1374,7 +1374,7 @@ summary_info += {'gprof enabled':
> config_host.has_key('CONFIG_GPROF')}
> summary_info += {'sparse enabled':
> meson.get_compiler('c').cmd_array().contains('cgcc')}
> summary_info += {'strip binaries': get_option('strip')}
> summary_info += {'profiler':
> config_host.has_key('CONFIG_PROFILER')}
> -summary_info += {'static build': config_host.has_key('CONFIG_TOOLS')}
> +summary_info += {'static build':
> config_host.has_key('CONFIG_STATIC')}
> if targetos == 'darwin'
> summary_info += {'Cocoa support': config_host.has_key('CONFIG_COCOA')}
> endif
> --
> 2.26.2
>
>
[-- Attachment #2: Type: text/html, Size: 1686 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] meson: fix static flag summary
2020-09-17 14:07 [PATCH] meson: fix static flag summary Laurent Vivier
2020-09-17 14:25 ` Paolo Bonzini
@ 2020-09-17 14:43 ` Philippe Mathieu-Daudé
2020-09-23 17:07 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-09-17 14:43 UTC (permalink / raw)
To: Laurent Vivier, qemu-devel; +Cc: qemu-trivial, Paolo Bonzini
On 9/17/20 4:07 PM, Laurent Vivier wrote:
> 'static build:' must display value of CONFIG_STATIC rather than value of
> CONFIG_TOOLS.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 5421eca66a02..c174f0ab0948 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1374,7 +1374,7 @@ summary_info += {'gprof enabled': config_host.has_key('CONFIG_GPROF')}
> summary_info += {'sparse enabled': meson.get_compiler('c').cmd_array().contains('cgcc')}
> summary_info += {'strip binaries': get_option('strip')}
> summary_info += {'profiler': config_host.has_key('CONFIG_PROFILER')}
> -summary_info += {'static build': config_host.has_key('CONFIG_TOOLS')}
> +summary_info += {'static build': config_host.has_key('CONFIG_STATIC')}
> if targetos == 'darwin'
> summary_info += {'Cocoa support': config_host.has_key('CONFIG_COCOA')}
> endif
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] meson: fix static flag summary
2020-09-17 14:07 [PATCH] meson: fix static flag summary Laurent Vivier
2020-09-17 14:25 ` Paolo Bonzini
2020-09-17 14:43 ` Philippe Mathieu-Daudé
@ 2020-09-23 17:07 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2020-09-23 17:07 UTC (permalink / raw)
To: Laurent Vivier, qemu-devel; +Cc: qemu-trivial, Paolo Bonzini
Le 17/09/2020 à 16:07, Laurent Vivier a écrit :
> 'static build:' must display value of CONFIG_STATIC rather than value of
> CONFIG_TOOLS.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 5421eca66a02..c174f0ab0948 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1374,7 +1374,7 @@ summary_info += {'gprof enabled': config_host.has_key('CONFIG_GPROF')}
> summary_info += {'sparse enabled': meson.get_compiler('c').cmd_array().contains('cgcc')}
> summary_info += {'strip binaries': get_option('strip')}
> summary_info += {'profiler': config_host.has_key('CONFIG_PROFILER')}
> -summary_info += {'static build': config_host.has_key('CONFIG_TOOLS')}
> +summary_info += {'static build': config_host.has_key('CONFIG_STATIC')}
> if targetos == 'darwin'
> summary_info += {'Cocoa support': config_host.has_key('CONFIG_COCOA')}
> endif
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-23 17:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-17 14:07 [PATCH] meson: fix static flag summary Laurent Vivier
2020-09-17 14:25 ` Paolo Bonzini
2020-09-17 14:43 ` Philippe Mathieu-Daudé
2020-09-23 17:07 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).