qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Ani Sinha <ani@anisinha.ca>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
	Thomas Huth <thuth@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	jusual@redhat.com, Paolo Bonzini <pbonzini@redhat.com>,
	Ani Sinha <ani@anisinha.ca>, Igor Mammedov <imammedo@redhat.com>
Subject: [PATCH v8 07/12] tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag
Date: Thu, 17 Sep 2020 20:30:39 +0530	[thread overview]
Message-ID: <20200917150044.23159-8-ani@anisinha.ca> (raw)
In-Reply-To: <20200917150044.23159-1-ani@anisinha.ca>

This change adds a new unit test for the global flag
'acpi-pci-hotplug-with-bridge-support' which is available for cold plugged pci
bridges in i440fx. The flag can be used to turn off ACPI based hotplug support
on all pci bridges.

Signed-off-by: Ani Sinha <ani@anisinha.ca>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
---
 tests/qtest/bios-tables-test.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index ad157ef05d..c970556795 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -754,6 +754,20 @@ static void test_acpi_piix4_no_root_hotplug(void)
     free_test_data(&data);
 }
 
+static void test_acpi_piix4_no_bridge_hotplug(void)
+{
+    test_data data;
+
+    memset(&data, 0, sizeof(data));
+    data.machine = MACHINE_PC;
+    data.variant = ".hpbridge";
+    data.required_struct_types = base_required_struct_types;
+    data.required_struct_types_len = ARRAY_SIZE(base_required_struct_types);
+    test_acpi_one("-global PIIX4_PM.acpi-pci-hotplug-with-bridge-support=off "
+                  "-device pci-bridge,chassis_nr=1", &data);
+    free_test_data(&data);
+}
+
 static void test_acpi_q35_tcg(void)
 {
     test_data data;
@@ -1160,6 +1174,8 @@ int main(int argc, char *argv[])
         qtest_add_func("acpi/piix4/bridge", test_acpi_piix4_tcg_bridge);
         qtest_add_func("acpi/piix4/pci-hotplug/no_root_hotplug",
                        test_acpi_piix4_no_root_hotplug);
+        qtest_add_func("acpi/piix4/pci-hotplug/no_bridge_hotplug",
+                       test_acpi_piix4_no_bridge_hotplug);
         qtest_add_func("acpi/q35", test_acpi_q35_tcg);
         qtest_add_func("acpi/q35/bridge", test_acpi_q35_tcg_bridge);
         qtest_add_func("acpi/q35/mmio64", test_acpi_q35_tcg_mmio64);
-- 
2.17.1



  parent reply	other threads:[~2020-09-17 15:11 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-17 15:00 [PATCH v8 00/12] i440fx/acpi: addition of feature and bug fixes Ani Sinha
2020-09-17 15:00 ` [PATCH v8 01/12] tests/acpi: mark addition of table DSDT.roothp for unit testing root pci hotplug Ani Sinha
2020-09-17 15:00 ` [PATCH v8 02/12] tests/acpi: add new unit test to test hotplug off/on feature on the root pci bus Ani Sinha
2020-09-17 15:00 ` [PATCH v8 03/12] tests/acpi: add a new ACPI table in order to test root pci hotplug on/off Ani Sinha
2020-09-17 15:00 ` [PATCH v8 04/12] Fix a gap where acpi_pcihp_find_hotplug_bus() returns a non-hotpluggable bus Ani Sinha
2020-09-17 15:00 ` [PATCH v8 05/12] i440fx/acpi: do not add hotplug related amls for cold plugged bridges Ani Sinha
2020-09-17 15:00 ` [PATCH v8 06/12] tests/acpi: list added acpi table binary file for pci bridge hotplug test Ani Sinha
2020-09-17 15:00 ` Ani Sinha [this message]
2020-09-17 15:00 ` [PATCH v8 08/12] tests/acpi: add newly added acpi DSDT table blob for pci bridge hotplug flag Ani Sinha
2020-09-17 15:00 ` [PATCH v8 09/12] piix4: don't reserve hw resources when hotplug is off globally Ani Sinha
2020-09-18  6:24   ` Igor Mammedov
2020-09-18  6:36     ` Ani Sinha
2020-09-18  6:46       ` Igor Mammedov
2020-09-18  6:50         ` Ani Sinha
2020-09-17 15:00 ` [PATCH v8 10/12] tests/acpi: update golden master DSDT binary table blobs for q35 Ani Sinha
2020-09-17 15:00 ` [PATCH v8 11/12] tests/acpi: unit test exercising global pci hotplug off for i440fx Ani Sinha
2020-09-17 15:00 ` [PATCH v8 12/12] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug Ani Sinha
2020-09-17 15:30 ` [PATCH v8 00/12] i440fx/acpi: addition of feature and bug fixes no-reply
2020-09-18  6:31 ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200917150044.23159-8-ani@anisinha.ca \
    --to=ani@anisinha.ca \
    --cc=imammedo@redhat.com \
    --cc=jusual@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).