From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FCACC2BBD1 for ; Thu, 17 Sep 2020 15:40:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D07E82223C for ; Thu, 17 Sep 2020 15:40:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="jMHbJ0EC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D07E82223C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIw1n-00066W-OZ for qemu-devel@archiver.kernel.org; Thu, 17 Sep 2020 11:40:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36278) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIvvq-0007BV-4t for qemu-devel@nongnu.org; Thu, 17 Sep 2020 11:34:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:41765) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kIvvn-0007ZK-1z for qemu-devel@nongnu.org; Thu, 17 Sep 2020 11:34:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600356880; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QZn2aqmg1A+suffaM7wkH0DkVQInOkiyhNGywhMsggA=; b=jMHbJ0ECRqPMi8Q5c5qN3jn8P4tU78yxzP6BCxxaiStQgRXaG3Eik0JYKQIEoTduQnNiFt 8lhv2GL0444NVd70uDkwr4wePWIHC9g39sZ04+JqcVksu5lDj65GPxCiJDA5ZB9A1Fji74 2KviTpwrUdp20hqjf207y7HTks24B84= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-326-JaTsOvK6OsaXYeb0XxPFkw-1; Thu, 17 Sep 2020 11:34:39 -0400 X-MC-Unique: JaTsOvK6OsaXYeb0XxPFkw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B6F756408F; Thu, 17 Sep 2020 15:34:37 +0000 (UTC) Received: from work-vm (ovpn-114-108.ams2.redhat.com [10.36.114.108]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3B89D73662; Thu, 17 Sep 2020 15:34:32 +0000 (UTC) Date: Thu, 17 Sep 2020 16:34:29 +0100 From: "Dr. David Alan Gilbert" To: Tom Lendacky Subject: Re: [PATCH v3 5/5] sev/i386: Enable an SEV-ES guest based on SEV policy Message-ID: <20200917153429.GL2793@work-vm> References: <8e560a8577066c07b5bf1e5993fbd6d697702384.1600205384.git.thomas.lendacky@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8e560a8577066c07b5bf1e5993fbd6d697702384.1600205384.git.thomas.lendacky@amd.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Received-SPF: pass client-ip=63.128.21.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/16 20:51:18 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -50 X-Spam_score: -5.1 X-Spam_bar: ----- X-Spam_report: (-5.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.997, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Brijesh Singh , Eduardo Habkost , kvm@vger.kernel.org, "Michael S. Tsirkin" , Connor Kuehl , Marcelo Tosatti , qemu-devel@nongnu.org, Paolo Bonzini , Jiri Slaby , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Tom Lendacky (thomas.lendacky@amd.com) wrote: > From: Tom Lendacky > > Update the sev_es_enabled() function return value to be based on the SEV > policy that has been specified. SEV-ES is enabled if SEV is enabled and > the SEV-ES policy bit is set in the policy object. > > Signed-off-by: Tom Lendacky > --- > target/i386/sev.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/target/i386/sev.c b/target/i386/sev.c > index 6ddefc65fa..bcaadaa2f9 100644 > --- a/target/i386/sev.c > +++ b/target/i386/sev.c > @@ -70,6 +70,8 @@ struct SevGuestState { > #define DEFAULT_GUEST_POLICY 0x1 /* disable debug */ > #define DEFAULT_SEV_DEVICE "/dev/sev" > > +#define GUEST_POLICY_SEV_ES_BIT (1 << 2) > + I'm surprised that all the policy bits aren't defined in a header somewhere. But other than that, Reviewed-by: Dr. David Alan Gilbert > /* SEV Information Block GUID = 00f771de-1a7e-4fcb-890e-68c77e2fb44e */ > #define SEV_INFO_BLOCK_GUID \ > "\xde\x71\xf7\x00\x7e\x1a\xcb\x4f\x89\x0e\x68\xc7\x7e\x2f\xb4\x4e" > @@ -375,7 +377,7 @@ sev_enabled(void) > bool > sev_es_enabled(void) > { > - return false; > + return sev_enabled() && (sev_guest->policy & GUEST_POLICY_SEV_ES_BIT); > } > > uint64_t > -- > 2.28.0 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK