qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Ani Sinha <ani@anisinha.ca>
To: mst@redhat.com, qemu-devel@nongnu.org
Cc: "Laurent Vivier" <lvivier@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	jusual@redhat.com, "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Ani Sinha" <ani@anisinha.ca>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH v10 02/13] tests/acpi: add new unit test to test hotplug off/on feature on the root pci bus
Date: Fri, 18 Sep 2020 14:11:00 +0530	[thread overview]
Message-ID: <20200918084111.15339-3-ani@anisinha.ca> (raw)
In-Reply-To: <20200918084111.15339-1-ani@anisinha.ca>

Ability to turn hotplug off on the pci root bus for i440fx was added in commit:
3d7e78aa7777f0 ("Introduce a new flag for i440fx to disable PCI hotplug on the
root bus")

This change adds a unit test in order to test this feature.

Signed-off-by: Ani Sinha <ani@anisinha.ca>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
---
 tests/qtest/bios-tables-test.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index 504b810af5..ad157ef05d 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -740,6 +740,20 @@ static void test_acpi_piix4_tcg_bridge(void)
     free_test_data(&data);
 }
 
+static void test_acpi_piix4_no_root_hotplug(void)
+{
+    test_data data;
+
+    memset(&data, 0, sizeof(data));
+    data.machine = MACHINE_PC;
+    data.variant = ".roothp";
+    data.required_struct_types = base_required_struct_types;
+    data.required_struct_types_len = ARRAY_SIZE(base_required_struct_types);
+    test_acpi_one("-global PIIX4_PM.acpi-root-pci-hotplug=off "
+                  "-device pci-bridge,chassis_nr=1", &data);
+    free_test_data(&data);
+}
+
 static void test_acpi_q35_tcg(void)
 {
     test_data data;
@@ -1144,6 +1158,8 @@ int main(int argc, char *argv[])
         qtest_add_func("acpi/q35/tpm-tis", test_acpi_q35_tcg_tpm_tis);
         qtest_add_func("acpi/piix4", test_acpi_piix4_tcg);
         qtest_add_func("acpi/piix4/bridge", test_acpi_piix4_tcg_bridge);
+        qtest_add_func("acpi/piix4/pci-hotplug/no_root_hotplug",
+                       test_acpi_piix4_no_root_hotplug);
         qtest_add_func("acpi/q35", test_acpi_q35_tcg);
         qtest_add_func("acpi/q35/bridge", test_acpi_q35_tcg_bridge);
         qtest_add_func("acpi/q35/mmio64", test_acpi_q35_tcg_mmio64);
-- 
2.17.1



  parent reply	other threads:[~2020-09-18  8:46 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-18  8:40 [PATCH v10 00/13] i440fx/acpi: addition of feature and bug fixes Ani Sinha
2020-09-18  8:40 ` [PATCH v10 01/13] tests/acpi: mark addition of table DSDT.roothp for unit testing root pci hotplug Ani Sinha
2020-09-18  8:41 ` Ani Sinha [this message]
2020-09-18  8:41 ` [PATCH v10 03/13] tests/acpi: add a new ACPI table in order to test root pci hotplug on/off Ani Sinha
2020-09-18  8:41 ` [PATCH v10 04/13] Fix a gap where acpi_pcihp_find_hotplug_bus() returns a non-hotpluggable bus Ani Sinha
2020-09-18  8:41 ` [PATCH v10 05/13] i440fx/acpi: do not add hotplug related amls for cold plugged bridges Ani Sinha
2020-09-18  8:41 ` [PATCH v10 06/13] tests/acpi: list added acpi table binary file for pci bridge hotplug test Ani Sinha
2020-09-18  8:41 ` [PATCH v10 07/13] tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag Ani Sinha
2020-09-18  8:41 ` [PATCH v10 08/13] tests/acpi: add newly added acpi DSDT table blob for pci bridge hotplug flag Ani Sinha
2020-09-18  8:41 ` [PATCH v10 09/13] Add ACPI DSDT tables for q35 that are being updated by the next patch Ani Sinha
2020-09-18  8:41 ` [PATCH v10 10/13] piix4: don't reserve hw resources when hotplug is off globally Ani Sinha
2020-09-18  8:41 ` [PATCH v10 11/13] tests/acpi: update golden master DSDT binary table blobs for q35 Ani Sinha
2020-09-18  8:41 ` [PATCH v10 12/13] tests/acpi: unit test exercising global pci hotplug off for i440fx Ani Sinha
2020-09-18  8:41 ` [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug Ani Sinha
2020-09-29  7:11   ` Michael S. Tsirkin
2020-09-29  7:23     ` Ani Sinha
2020-09-29  7:26       ` Michael S. Tsirkin
2020-09-29  8:23         ` Ani Sinha
2020-09-29  8:51           ` Ani Sinha
2020-09-29  9:37             ` Ani Sinha
2020-09-29  9:42             ` Michael S. Tsirkin
2020-09-29  9:50               ` Ani Sinha
2020-09-29 10:30                 ` Ani Sinha
2020-09-29 10:32                   ` Ani Sinha
2020-09-29 10:36                     ` Ani Sinha
2020-09-29 10:37                     ` Michael S. Tsirkin
2020-09-29 10:41                       ` Ani Sinha
2020-09-29 10:50                         ` Ani Sinha
2020-09-29 10:57                           ` Michael S. Tsirkin
2020-09-29 11:10                             ` Ani Sinha
2020-09-29 10:55                         ` Michael S. Tsirkin
2020-09-29 11:05                           ` Ani Sinha
2020-09-29 11:14                             ` Michael S. Tsirkin
2020-09-29 11:28                               ` Ani Sinha
2020-09-29 11:35                                 ` Michael S. Tsirkin
2020-09-29 12:33                                   ` Ani Sinha
2020-09-30  7:36                                     ` Michael S. Tsirkin
2020-09-30  7:39                                       ` Ani Sinha
2020-09-30  7:43                                         ` Michael S. Tsirkin
2020-09-30  7:47                                           ` Ani Sinha
2020-09-30  8:04                                             ` Michael S. Tsirkin
2020-09-30  8:07                                               ` Ani Sinha
2020-09-30  9:30                                                 ` Ani Sinha
2020-09-30 15:28                                                   ` Michael S. Tsirkin
2020-09-30 15:45                                                     ` Ani Sinha
2020-09-18  9:55 ` [PATCH v10 00/13] i440fx/acpi: addition of feature and bug fixes Philippe Mathieu-Daudé
2020-09-18 13:12   ` Ani Sinha
2020-09-18 14:51   ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200918084111.15339-3-ani@anisinha.ca \
    --to=ani@anisinha.ca \
    --cc=aleksandar.qemu.devel@gmail.com \
    --cc=aurelien@aurel32.net \
    --cc=ehabkost@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=imammedo@redhat.com \
    --cc=jusual@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).