[PATCH] virtio-gpu-3d: fix abnormal display after a warm reboot

[PATCH] virtio-gpu-3d: fix abnormal display after a warm reboot

[Guoqing Zhang]

When resetting virtio-gpu, virgl_renderer_reset() should be
called to ensure that the virglrenderer status is correct.

Signed-off-by: Guoqing Zhang <zhangguoqing.kernel@bytedance.com>
Reviewed-by: Qi Liu<liuqi.16@bytedance.com>
---
 hw/display/virtio-gpu-3d.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c
index 96621576c2..1bd33d7aed 100644
--- a/hw/display/virtio-gpu-3d.c
+++ b/hw/display/virtio-gpu-3d.c
@@ -595,7 +595,7 @@ void virtio_gpu_virgl_reset(VirtIOGPU *g)
 {
     int i;
 
-    /* virgl_renderer_reset() ??? */
+    virgl_renderer_reset();
     for (i = 0; i < g->parent_obj.conf.max_outputs; i++) {
         if (i != 0) {
             dpy_gfx_replace_surface(g->parent_obj.scanout[i].con, NULL);
-- 
2.24.3 (Apple Git-128)

Re: [PATCH] virtio-gpu-3d: fix abnormal display after a warm reboot

[no-reply]

Patchew URL: https://patchew.org/QEMU/20200918111632.37354-1-zhangguoqing.kernel@bytedance.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

N/A. Internal error while reading log file



The full log is available at
http://patchew.org/logs/20200918111632.37354-1-zhangguoqing.kernel@bytedance.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [PATCH] virtio-gpu-3d: fix abnormal display after a warm reboot

[no-reply]

Patchew URL: https://patchew.org/QEMU/20200918111632.37354-1-zhangguoqing.kernel@bytedance.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.






The full log is available at
http://patchew.org/logs/20200918111632.37354-1-zhangguoqing.kernel@bytedance.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [PATCH] virtio-gpu-3d: fix abnormal display after a warm reboot

[Guoqing Zhang]

[-- Attachment #1: Type: text/plain, Size: 1074 bytes --]

hello Gerd and Michael   Michael S. Tsirkin

ping

http://patchwork.ozlabs.org/project/qemu-devel/list/?series=202680

On Fri, Sep 18, 2020 at 7:16 PM Guoqing Zhang <
zhangguoqing.kernel@bytedance.com> wrote:

> When resetting virtio-gpu, virgl_renderer_reset() should be
> called to ensure that the virglrenderer status is correct.
>
> Signed-off-by: Guoqing Zhang <zhangguoqing.kernel@bytedance.com>
> Reviewed-by: Qi Liu<liuqi.16@bytedance.com>
> ---
>  hw/display/virtio-gpu-3d.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c
> index 96621576c2..1bd33d7aed 100644
> --- a/hw/display/virtio-gpu-3d.c
> +++ b/hw/display/virtio-gpu-3d.c
> @@ -595,7 +595,7 @@ void virtio_gpu_virgl_reset(VirtIOGPU *g)
>  {
>      int i;
>
> -    /* virgl_renderer_reset() ??? */
> +    virgl_renderer_reset();
>      for (i = 0; i < g->parent_obj.conf.max_outputs; i++) {
>          if (i != 0) {
>              dpy_gfx_replace_surface(g->parent_obj.scanout[i].con, NULL);
> --
> 2.24.3 (Apple Git-128)
>
>

[-- Attachment #2: Type: text/html, Size: 1780 bytes --]

Re: [PATCH] virtio-gpu-3d: fix abnormal display after a warm reboot

[Gerd Hoffmann]

On Sun, Sep 27, 2020 at 08:17:10PM +0800, Guoqing Zhang wrote:
> hello Gerd and Michael   Michael S. Tsirkin
> 
> ping

Queued up now (not much activity for vga/ui these days ...).

> 
> http://patchwork.ozlabs.org/project/qemu-devel/list/?series=202680
> 
> On Fri, Sep 18, 2020 at 7:16 PM Guoqing Zhang <
> zhangguoqing.kernel@bytedance.com> wrote:
> 
> > When resetting virtio-gpu, virgl_renderer_reset() should be
> > called to ensure that the virglrenderer status is correct.
> >
> > Signed-off-by: Guoqing Zhang <zhangguoqing.kernel@bytedance.com>
> > Reviewed-by: Qi Liu<liuqi.16@bytedance.com>
> > ---
> >  hw/display/virtio-gpu-3d.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c
> > index 96621576c2..1bd33d7aed 100644
> > --- a/hw/display/virtio-gpu-3d.c
> > +++ b/hw/display/virtio-gpu-3d.c
> > @@ -595,7 +595,7 @@ void virtio_gpu_virgl_reset(VirtIOGPU *g)
> >  {
> >      int i;
> >
> > -    /* virgl_renderer_reset() ??? */
> > +    virgl_renderer_reset();
> >      for (i = 0; i < g->parent_obj.conf.max_outputs; i++) {
> >          if (i != 0) {
> >              dpy_gfx_replace_surface(g->parent_obj.scanout[i].con, NULL);
> > --
> > 2.24.3 (Apple Git-128)
> >
> >