From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CA5AC43463 for ; Fri, 18 Sep 2020 09:24:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 922AD20DD4 for ; Fri, 18 Sep 2020 09:24:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cXoB5UWG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 922AD20DD4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49262 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJCdF-0000B5-Ev for qemu-devel@archiver.kernel.org; Fri, 18 Sep 2020 05:24:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46566) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJCcG-00084Z-A7 for qemu-devel@nongnu.org; Fri, 18 Sep 2020 05:23:40 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:46893 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kJCcE-0004KZ-Cc for qemu-devel@nongnu.org; Fri, 18 Sep 2020 05:23:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600421017; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tnOqtLPUP/xruxrWs83c7sDS+5PdGCVlivzGt9V0fsI=; b=cXoB5UWG8YFvVP28zkgSQELTY0yPwtqkWDhPWgypAfDjEnrN1n8p9Sg80Dak/OG0QYLaLp cVTXAriXViYhf6+vJMVbdU8QO01TbGj4Hs0s3a+uqpGSQDsfmn840at9qWspcVHbs9WHeE C6kdc6k/jjqiSA6rCGPSCvFOUX7J3do= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-446-AF1pMi8GPfyFP7w-UbixJg-1; Fri, 18 Sep 2020 05:23:33 -0400 X-MC-Unique: AF1pMi8GPfyFP7w-UbixJg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2D5801017DD8; Fri, 18 Sep 2020 09:23:32 +0000 (UTC) Received: from gondolin (ovpn-112-191.ams2.redhat.com [10.36.112.191]) by smtp.corp.redhat.com (Postfix) with ESMTP id 822156198D; Fri, 18 Sep 2020 09:23:18 +0000 (UTC) Date: Fri, 18 Sep 2020 11:23:16 +0200 From: Cornelia Huck To: Stefano Garzarella Subject: Re: [PATCH v3 3/4] vhost-user-vsock-pci: force virtio version 1 Message-ID: <20200918112316.3987fe77.cohuck@redhat.com> In-Reply-To: <20200918074710.27810-4-sgarzare@redhat.com> References: <20200918074710.27810-1-sgarzare@redhat.com> <20200918074710.27810-4-sgarzare@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.61; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/18 05:23:37 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -50 X-Spam_score: -5.1 X-Spam_bar: ----- X-Spam_report: (-5.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.997, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Qinghua Cheng , Eduardo Habkost , "Michael S. Tsirkin" , qemu-stable@nongnu.org, David Hildenbrand , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, Richard Henderson , Qian Cai Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 18 Sep 2020 09:47:09 +0200 Stefano Garzarella wrote: > Commit 9b3a35ec82 ("virtio: verify that legacy support is not > accidentally on") added a safety check that requires to set > 'disable-legacy=on' on vhost-user-vsock-pci device: > > $ ./qemu-system-x86_64 ... \ > -chardev socket,id=char0,reconnect=0,path=/tmp/vhost4.socket \ > -device vhost-user-vsock-pci,chardev=char0 > qemu-system-x86_64: -device vhost-user-vsock-pci,chardev=char0: > device is modern-only, use disable-legacy=on > > virtio-vsock was introduced after the release of VIRTIO 1.0 > specifications, so it should be 'modern-only'. > > This patch forces virtio version 1 and removes the 'transitional_name' > property, as done for vhost-vsock-pci, removing the need to specify > 'disable-legacy=on' on vhost-user-vsock-pci device. > > Cc: qemu-stable@nongnu.org > Suggested-by: Cornelia Huck > Reviewed-by: Cornelia Huck > Signed-off-by: Stefano Garzarella > --- > v2: > - fixed commit message [Cornelia] > --- > hw/virtio/vhost-user-vsock-pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/virtio/vhost-user-vsock-pci.c b/hw/virtio/vhost-user-vsock-pci.c > index 763f89984e..14109121e2 100644 > --- a/hw/virtio/vhost-user-vsock-pci.c > +++ b/hw/virtio/vhost-user-vsock-pci.c > @@ -41,6 +41,7 @@ static void vhost_user_vsock_pci_realize(VirtIOPCIProxy *vpci_dev, Error **errp) > VHostUserVSockPCI *dev = VHOST_USER_VSOCK_PCI(vpci_dev); > DeviceState *vdev = DEVICE(&dev->vdev); > > + virtio_pci_force_virtio_1(vpci_dev); Maybe add a comment /* unlike vhost-vsock, we do not need to care about pre-5.1 compat */ to help when we look at this in the future? > qdev_realize(vdev, BUS(&vpci_dev->bus), errp); > } > > @@ -69,7 +70,6 @@ static void vhost_user_vsock_pci_instance_init(Object *obj) > static const VirtioPCIDeviceTypeInfo vhost_user_vsock_pci_info = { > .base_name = TYPE_VHOST_USER_VSOCK_PCI, > .generic_name = "vhost-user-vsock-pci", > - .transitional_name = "vhost-user-vsock-pci-transitional", > .non_transitional_name = "vhost-user-vsock-pci-non-transitional", > .instance_size = sizeof(VHostUserVSockPCI), > .instance_init = vhost_user_vsock_pci_instance_init, Otherwise, Reviewed-by: Cornelia Huck