From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
qemu-devel@nongnu.org,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH 0/3] gitlab: add jobs for checking paches
Date: Fri, 18 Sep 2020 15:15:20 +0100 [thread overview]
Message-ID: <20200918141520.GL1628512@redhat.com> (raw)
In-Reply-To: <655b71e6-da6e-38b1-2c80-5d7d9caa8770@redhat.com>
On Fri, Sep 18, 2020 at 04:07:22PM +0200, Thomas Huth wrote:
> On 18/09/2020 15.29, Daniel P. Berrangé wrote:
> > This introduces two new jobs to GitLab. The first runs "checkpatch.pl"
> > across all patches, while the second is a dedicated DCO signoff check.
>
> This feels quite redundant since we're checking the patches with Patchew
> already ... or are there plans to get rid of this check in Patchew?
patchew only runs once the contributor has sent their patches to the
mailing list, whci his too late.
We want contributors to test their series in GitLab CI ahead of sending
it, so that patchew never has to report any failure, because the code is
already perfect once on the list (except if git master has moved and
causes conflicts of course).
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2020-09-18 14:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 13:29 [PATCH 0/3] gitlab: add jobs for checking paches Daniel P. Berrangé
2020-09-18 13:29 ` [PATCH 1/3] gitlab: add a CI job for running checkpatch.pl Daniel P. Berrangé
2020-09-18 13:46 ` Philippe Mathieu-Daudé
2020-10-13 8:08 ` Thomas Huth
2020-10-13 8:09 ` Daniel P. Berrangé
2020-09-18 13:29 ` [PATCH 2/3] gitlab: add a CI job to validate the DCO sign off Daniel P. Berrangé
2020-09-18 13:29 ` [PATCH 3/3] gitlab: assign python helper files to GitLab maintainers section Daniel P. Berrangé
2020-09-18 13:47 ` Philippe Mathieu-Daudé
2020-09-18 13:36 ` [PATCH 0/3] gitlab: add jobs for checking paches no-reply
2020-09-18 13:54 ` no-reply
2020-09-18 14:07 ` Thomas Huth
2020-09-18 14:10 ` Philippe Mathieu-Daudé
2020-09-18 14:15 ` Daniel P. Berrangé [this message]
2020-09-18 14:19 ` 罗勇刚(Yonggang Luo)
2020-09-18 14:57 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200918141520.GL1628512@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).