From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDA99C43463 for ; Fri, 18 Sep 2020 14:16:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 795B22078B for ; Fri, 18 Sep 2020 14:16:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bSmHo8gE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 795B22078B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42838 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJHBy-000717-Jr for qemu-devel@archiver.kernel.org; Fri, 18 Sep 2020 10:16:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58576) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJHAx-0006WS-RP for qemu-devel@nongnu.org; Fri, 18 Sep 2020 10:15:47 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:55939 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kJHAt-0000Og-SS for qemu-devel@nongnu.org; Fri, 18 Sep 2020 10:15:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600438541; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gZSDSqr4v3NwHtcrwWKxQSNdze1ASnPuMX+HrdPFC7k=; b=bSmHo8gE11Jgl9u+cX3FBaQqpDsmTG9TpuiZPJqeGOVuA8qkuEGFJ/lHIDpt3lx1AVA43Z gGVDKHJs6hqn3XX4R/gPmQ3YFCvvbHqbZVLBVxDaee5uOzhb3ZVR25DDyDLzYsE3uQLBfP g3kg80eGwL91Qs59dkXwVbH+2Zn/Y/M= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-225-zXhwzw1kOoeMYGhNnlq5Hg-1; Fri, 18 Sep 2020 10:15:32 -0400 X-MC-Unique: zXhwzw1kOoeMYGhNnlq5Hg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 26141800471; Fri, 18 Sep 2020 14:15:31 +0000 (UTC) Received: from redhat.com (ovpn-114-199.ams2.redhat.com [10.36.114.199]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EC44D78817; Fri, 18 Sep 2020 14:15:22 +0000 (UTC) Date: Fri, 18 Sep 2020 15:15:20 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Subject: Re: [PATCH 0/3] gitlab: add jobs for checking paches Message-ID: <20200918141520.GL1628512@redhat.com> References: <20200918132903.1848939-1-berrange@redhat.com> <655b71e6-da6e-38b1-2c80-5d7d9caa8770@redhat.com> MIME-Version: 1.0 In-Reply-To: <655b71e6-da6e-38b1-2c80-5d7d9caa8770@redhat.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.81; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/18 07:01:30 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -50 X-Spam_score: -5.1 X-Spam_bar: ----- X-Spam_report: (-5.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.999, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Alex =?utf-8?Q?Benn=C3=A9e?= , qemu-devel@nongnu.org, Wainer dos Santos Moschetta , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Sep 18, 2020 at 04:07:22PM +0200, Thomas Huth wrote: > On 18/09/2020 15.29, Daniel P. Berrangé wrote: > > This introduces two new jobs to GitLab. The first runs "checkpatch.pl" > > across all patches, while the second is a dedicated DCO signoff check. > > This feels quite redundant since we're checking the patches with Patchew > already ... or are there plans to get rid of this check in Patchew? patchew only runs once the contributor has sent their patches to the mailing list, whci his too late. We want contributors to test their series in GitLab CI ahead of sending it, so that patchew never has to report any failure, because the code is already perfect once on the list (except if git master has moved and causes conflicts of course). Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|