From: Cornelia Huck <cohuck@redhat.com>
To: Auger Eric <eric.auger@redhat.com>
Cc: jean-philippe@linaro.org, thuth@redhat.com, mst@redhat.com,
qemu-devel@nongnu.org, qemu-stable@nongnu.org,
eric.auger.pro@gmail.com
Subject: Re: [PATCH v2 2/2] virtio-iommu-pci: force virtio version 1
Date: Fri, 18 Sep 2020 14:58:13 +0200 [thread overview]
Message-ID: <20200918145813.667833a0.cohuck@redhat.com> (raw)
In-Reply-To: <72eea96c-8ad0-90b0-aaa7-dabad1f118d8@redhat.com>
On Fri, 18 Sep 2020 12:24:02 +0200
Auger Eric <eric.auger@redhat.com> wrote:
> Hi Connie,
>
> On 9/18/20 11:29 AM, Cornelia Huck wrote:
> > On Tue, 8 Sep 2020 21:33:09 +0200
> > Eric Auger <eric.auger@redhat.com> wrote:
> >
> >> Commit 9b3a35ec82 ("virtio: verify that legacy support is not
> >> accidentally on") added a safety check that requires to set
> >> 'disable-legacy=on' on virtio-iommu-pci:
> >>
> >> qemu-system-aarch64: -device virtio-iommu-pci: device is modern-only,
> >> use disable-legacy=on
> >>
> >> virtio-iommu was introduced after the release of VIRTIO 1.0
> >> specifications, so it should be 'modern-only'.
> >>
> >> This patch forces virtio version 1 and removes the 'transitional_name'
> >> property removing the need to specify 'disable-legacy=on' on
> >> virtio-iommu-pci device.
> >
> > Not sure whether this patch has been queued already, and how much we
> > care about migration compatibility for virtio-iommu, but would it make
> > sense to force modern on 5.1+ compat machines only? (see
> > https://lore.kernel.org/qemu-devel/20200918074710.27810-1-sgarzare@redhat.com/)
>
> I don't think it was pulled yet.
> >
> >>
> >> Cc: qemu-stable@nongnu.org
>
> The virtio-iommu-pci device only is usable on ARM in dt mode so I don't
> think it has production users at the moment.
OK, then we can keep this patch here, I guess.
prev parent reply other threads:[~2020-09-18 13:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 19:33 [PATCH v2 0/2] virtio-iommu-pci: Advertise the device as modern-only Eric Auger
2020-09-08 19:33 ` [PATCH v2 1/2] virtio-iommu: Check gtrees are non null before destroying them Eric Auger
2020-09-08 19:33 ` [PATCH v2 2/2] virtio-iommu-pci: force virtio version 1 Eric Auger
2020-09-18 9:29 ` Cornelia Huck
2020-09-18 10:24 ` Auger Eric
2020-09-18 12:58 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200918145813.667833a0.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=jean-philippe@linaro.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).