qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PULL 0/2] Acceptance patches for 2020-09-18
@ 2020-09-18 19:18 Philippe Mathieu-Daudé
  2020-09-18 19:18 ` [PULL 1/2] tests/acceptance: Disable tests dependent of unreliable apt.armbian.com Philippe Mathieu-Daudé
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-09-18 19:18 UTC (permalink / raw)
  To: qemu-devel
  Cc: Paolo Bonzini, Philippe Mathieu-Daudé, Pavel Dovgalyuk,
	Wainer dos Santos Moschetta, Cleber Rosa

The following changes since commit 053a4177817db307ec854356e95b5b350800a216:

  Merge remote-tracking branch 'remotes/philmd-gitlab/tags/fw_cfg-20200918' i=
nto staging (2020-09-18 16:34:26 +0100)

are available in the Git repository at:

  https://gitlab.com/philmd/qemu.git tags/acceptance-next-20200918

for you to fetch changes up to b6eea069ab3926e110b8ddf037ff7ea7b2c8c1f5:

  tests/acceptance: Skip slow quanta-gsj U-boot+Linux test (2020-09-18 19:46:=
38 +0200)

----------------------------------------------------------------
Acceptance tests queue

Get GitLab CI acceptance jobs green again.

CI jobs results:
  https://gitlab.com/philmd/qemu/-/pipelines/191795388
----------------------------------------------------------------

Philippe Mathieu-Daud=C3=A9 (2):
  tests/acceptance: Disable tests dependent of unreliable
    apt.armbian.com
  tests/acceptance: Skip slow quanta-gsj U-boot+Linux test

 tests/acceptance/boot_linux_console.py | 11 +++++++++++
 tests/acceptance/replay_kernel.py      |  3 +++
 2 files changed, 14 insertions(+)

--=20
2.26.2



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PULL 1/2] tests/acceptance: Disable tests dependent of unreliable apt.armbian.com
  2020-09-18 19:18 [PULL 0/2] Acceptance patches for 2020-09-18 Philippe Mathieu-Daudé
@ 2020-09-18 19:18 ` Philippe Mathieu-Daudé
  2020-09-18 19:18 ` [PULL 2/2] tests/acceptance: Skip slow quanta-gsj U-boot+Linux test Philippe Mathieu-Daudé
  2020-09-21 16:41 ` [PULL 0/2] Acceptance patches for 2020-09-18 Peter Maydell
  2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-09-18 19:18 UTC (permalink / raw)
  To: qemu-devel
  Cc: Thomas Huth, Wainer dos Santos Moschetta, Willian Rampazzo,
	Gerd Hoffmann, Pavel Dovgalyuk, Cleber Rosa, Paolo Bonzini,
	Philippe Mathieu-Daudé

Armbian servers are not very reliable and confused the GitLab CI
users a few times this month (path updated, archives moved, and
now the SSL: CERTIFICATE_VERIFY_FAILED "certificate has expired"
error). Time to disable these tests.
Users can still use the artifacts from the cache (or manually add
them to the cache).

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Message-Id: <20200917163954.50514-1-philmd@redhat.com>
---
 tests/acceptance/boot_linux_console.py | 10 ++++++++++
 tests/acceptance/replay_kernel.py      |  3 +++
 2 files changed, 13 insertions(+)

diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py
index 4a366ce93e4..68534693109 100644
--- a/tests/acceptance/boot_linux_console.py
+++ b/tests/acceptance/boot_linux_console.py
@@ -485,6 +485,8 @@ def test_arm_exynos4210_initrd(self):
         self.wait_for_console_pattern('Boot successful.')
         # TODO user command, for now the uart is stuck
 
+    @skipUnless(os.getenv('ARMBIAN_ARTIFACTS_CACHED'),
+                'Test artifacts fetched from unreliable apt.armbian.com')
     def test_arm_cubieboard_initrd(self):
         """
         :avocado: tags=arch:arm
@@ -525,6 +527,8 @@ def test_arm_cubieboard_initrd(self):
                                                 'system-control@1c00000')
         # cubieboard's reboot is not functioning; omit reboot test.
 
+    @skipUnless(os.getenv('ARMBIAN_ARTIFACTS_CACHED'),
+                'Test artifacts fetched from unreliable apt.armbian.com')
     def test_arm_cubieboard_sata(self):
         """
         :avocado: tags=arch:arm
@@ -651,6 +655,8 @@ def test_arm_quanta_gsj_initrd(self):
         self.wait_for_console_pattern(
                 'Give root password for system maintenance')
 
+    @skipUnless(os.getenv('ARMBIAN_ARTIFACTS_CACHED'),
+                'Test artifacts fetched from unreliable apt.armbian.com')
     def test_arm_orangepi(self):
         """
         :avocado: tags=arch:arm
@@ -676,6 +682,8 @@ def test_arm_orangepi(self):
         console_pattern = 'Kernel command line: %s' % kernel_command_line
         self.wait_for_console_pattern(console_pattern)
 
+    @skipUnless(os.getenv('ARMBIAN_ARTIFACTS_CACHED'),
+                'Test artifacts fetched from unreliable apt.armbian.com')
     def test_arm_orangepi_initrd(self):
         """
         :avocado: tags=arch:arm
@@ -718,6 +726,8 @@ def test_arm_orangepi_initrd(self):
         # Wait for VM to shut down gracefully
         self.vm.wait()
 
+    @skipUnless(os.getenv('ARMBIAN_ARTIFACTS_CACHED'),
+                'Test artifacts fetched from unreliable apt.armbian.com')
     def test_arm_orangepi_sd(self):
         """
         :avocado: tags=arch:arm
diff --git a/tests/acceptance/replay_kernel.py b/tests/acceptance/replay_kernel.py
index b79fc8daf8e..952f429cace 100644
--- a/tests/acceptance/replay_kernel.py
+++ b/tests/acceptance/replay_kernel.py
@@ -13,6 +13,7 @@
 import time
 
 from avocado import skipIf
+from avocado import skipUnless
 from avocado_qemu import wait_for_console_pattern
 from avocado.utils import archive
 from avocado.utils import process
@@ -127,6 +128,8 @@ def test_arm_virt(self):
         self.run_rr(kernel_path, kernel_command_line, console_pattern, shift=1)
 
     @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab')
+    @skipUnless(os.getenv('ARMBIAN_ARTIFACTS_CACHED'),
+                'Test artifacts fetched from unreliable apt.armbian.com')
     def test_arm_cubieboard_initrd(self):
         """
         :avocado: tags=arch:arm
-- 
2.26.2



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PULL 2/2] tests/acceptance: Skip slow quanta-gsj U-boot+Linux test
  2020-09-18 19:18 [PULL 0/2] Acceptance patches for 2020-09-18 Philippe Mathieu-Daudé
  2020-09-18 19:18 ` [PULL 1/2] tests/acceptance: Disable tests dependent of unreliable apt.armbian.com Philippe Mathieu-Daudé
@ 2020-09-18 19:18 ` Philippe Mathieu-Daudé
  2020-09-21 16:41 ` [PULL 0/2] Acceptance patches for 2020-09-18 Peter Maydell
  2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-09-18 19:18 UTC (permalink / raw)
  To: qemu-devel
  Cc: Philippe Mathieu-Daudé, Wainer dos Santos Moschetta,
	Havard Skinnemoen, Willian Rampazzo, Pavel Dovgalyuk, Cleber Rosa,
	Paolo Bonzini, Philippe Mathieu-Daudé

From: Philippe Mathieu-Daudé <f4bug@amsat.org>

The 'arm_quanta_gsj_initrd' test is timeouting on GitLab CI:
https://gitlab.com/philmd/qemu/-/jobs/745483978#L846
and also sometimes on my workstation, so proceed as with
the other slow tests: do not run it by default.
The test can still be run setting the AVOCADO_TIMEOUT_EXPECTED
environment variable.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Reviewed-by: Havard Skinnemoen <hskinnemoen@google.com>
Tested-by: Havard Skinnemoen <hskinnemoen@google.com>
Message-Id: <20200918143355.153522-1-f4bug@amsat.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 tests/acceptance/boot_linux_console.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py
index 68534693109..0118ed59156 100644
--- a/tests/acceptance/boot_linux_console.py
+++ b/tests/acceptance/boot_linux_console.py
@@ -572,6 +572,7 @@ def test_arm_cubieboard_sata(self):
                                                 'sda')
         # cubieboard's reboot is not functioning; omit reboot test.
 
+    @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout')
     def test_arm_quanta_gsj(self):
         """
         :avocado: tags=arch:arm
-- 
2.26.2



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PULL 0/2] Acceptance patches for 2020-09-18
  2020-09-18 19:18 [PULL 0/2] Acceptance patches for 2020-09-18 Philippe Mathieu-Daudé
  2020-09-18 19:18 ` [PULL 1/2] tests/acceptance: Disable tests dependent of unreliable apt.armbian.com Philippe Mathieu-Daudé
  2020-09-18 19:18 ` [PULL 2/2] tests/acceptance: Skip slow quanta-gsj U-boot+Linux test Philippe Mathieu-Daudé
@ 2020-09-21 16:41 ` Peter Maydell
  2 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2020-09-21 16:41 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé
  Cc: Paolo Bonzini, Cleber Rosa, QEMU Developers, Pavel Dovgalyuk,
	Wainer dos Santos Moschetta

On Fri, 18 Sep 2020 at 21:14, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> The following changes since commit 053a4177817db307ec854356e95b5b350800a216:
>
>   Merge remote-tracking branch 'remotes/philmd-gitlab/tags/fw_cfg-20200918' i=
> nto staging (2020-09-18 16:34:26 +0100)
>
> are available in the Git repository at:
>
>   https://gitlab.com/philmd/qemu.git tags/acceptance-next-20200918
>
> for you to fetch changes up to b6eea069ab3926e110b8ddf037ff7ea7b2c8c1f5:
>
>   tests/acceptance: Skip slow quanta-gsj U-boot+Linux test (2020-09-18 19:46:=
> 38 +0200)
>
> ----------------------------------------------------------------
> Acceptance tests queue
>
> Get GitLab CI acceptance jobs green again.
>
> CI jobs results:
>   https://gitlab.com/philmd/qemu/-/pipelines/191795388
> ----------------------------------------------------------------
>
> Philippe Mathieu-Daud=C3=A9 (2):

Something in your workflow is mangling UTF-8. (The actual
commits in the pull look OK.)


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/5.2
for any user-visible changes.

-- PMM


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-09-21 16:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-18 19:18 [PULL 0/2] Acceptance patches for 2020-09-18 Philippe Mathieu-Daudé
2020-09-18 19:18 ` [PULL 1/2] tests/acceptance: Disable tests dependent of unreliable apt.armbian.com Philippe Mathieu-Daudé
2020-09-18 19:18 ` [PULL 2/2] tests/acceptance: Skip slow quanta-gsj U-boot+Linux test Philippe Mathieu-Daudé
2020-09-21 16:41 ` [PULL 0/2] Acceptance patches for 2020-09-18 Peter Maydell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).