qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Greg Kurz" <groug@kaod.org>
Subject: [PULL 07/17] qom: Correct error values in two contracts
Date: Fri, 18 Sep 2020 16:47:04 -0400	[thread overview]
Message-ID: <20200918204714.27276-8-ehabkost@redhat.com> (raw)
In-Reply-To: <20200918204714.27276-1-ehabkost@redhat.com>

From: Markus Armbruster <armbru@redhat.com>

object_property_get_bool()'s contract claims it returns NULL on error.
Pasto; it returns false.

object_property_get_int()'s contract claims it returns "negative".  It
actually returns -1.  All the other object_property_get_FOO()
contracts specify the exact error value, so do the same here.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20200917125540.597786-3-armbru@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 include/qom/object.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/qom/object.h b/include/qom/object.h
index 494827b4d1..32524d72cc 100644
--- a/include/qom/object.h
+++ b/include/qom/object.h
@@ -1624,7 +1624,7 @@ bool object_property_set_bool(Object *obj, const char *name,
  * @name: the name of the property
  * @errp: returns an error if this function fails
  *
- * Returns: the value of the property, converted to a boolean, or NULL if
+ * Returns: the value of the property, converted to a boolean, or false if
  * an error occurs (including when the property value is not a bool).
  */
 bool object_property_get_bool(Object *obj, const char *name,
@@ -1649,7 +1649,7 @@ bool object_property_set_int(Object *obj, const char *name,
  * @name: the name of the property
  * @errp: returns an error if this function fails
  *
- * Returns: the value of the property, converted to an integer, or negative if
+ * Returns: the value of the property, converted to an integer, or -1 if
  * an error occurs (including when the property value is not an integer).
  */
 int64_t object_property_get_int(Object *obj, const char *name,
-- 
2.26.2



  parent reply	other threads:[~2020-09-18 20:59 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-18 20:46 [PULL 00/17] QOM queue, 2020-09-18 Eduardo Habkost
2020-09-18 20:46 ` [PULL 01/17] sifive_e: Rename memmap enum constants Eduardo Habkost
2020-09-18 20:46 ` [PULL 02/17] sifive_u: " Eduardo Habkost
2020-09-18 20:47 ` [PULL 03/17] sifive: Move QOM typedefs and add missing includes Eduardo Habkost
2020-09-18 20:47 ` [PULL 04/17] sifive: Use DECLARE_*CHECKER* macros Eduardo Habkost
2020-09-18 20:47 ` [PULL 05/17] qom: Correct object_class_dynamic_cast_assert() documentation Eduardo Habkost
2020-09-18 20:47 ` [PULL 06/17] qom: Clean up object_property_get_enum()'s error value Eduardo Habkost
2020-09-18 20:47 ` Eduardo Habkost [this message]
2020-09-18 20:47 ` [PULL 08/17] qom: Allow objects to be allocated with increased alignment Eduardo Habkost
2020-09-18 20:47 ` [PULL 09/17] target/arm: Set instance_align on CPUARM TypeInfo Eduardo Habkost
2020-09-18 20:47 ` [PULL 10/17] target/ppc: Set instance_align on PowerPCCPU TypeInfo Eduardo Habkost
2020-09-18 20:47 ` [PULL 11/17] target/riscv: Set instance_align on RISCVCPU TypeInfo Eduardo Habkost
2020-09-18 20:47 ` [PULL 12/17] target/s390x: Set instance_align on S390CPU TypeInfo Eduardo Habkost
2020-09-18 20:47 ` [PULL 13/17] scripts/codeconverter: Update to latest version Eduardo Habkost
2020-09-18 20:47 ` [PULL 14/17] qom: Remove ParentClassType argument from OBJECT_DECLARE_SIMPLE_TYPE Eduardo Habkost
2020-09-18 20:47 ` [PULL 15/17] qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros Eduardo Habkost
2020-09-18 20:47 ` [PULL 16/17] Use OBJECT_DECLARE_TYPE when possible Eduardo Habkost
2020-09-18 20:47 ` [PULL 17/17] Use OBJECT_DECLARE_SIMPLE_TYPE " Eduardo Habkost
2020-09-18 22:35 ` [PULL 00/17] QOM queue, 2020-09-18 no-reply
2020-09-18 23:23 ` no-reply
2020-09-18 23:43 ` no-reply
2020-09-19  0:23 ` no-reply
2020-09-19  0:43 ` no-reply
2020-09-19  1:32 ` no-reply
2020-09-19  1:43 ` no-reply
2020-09-19  1:57 ` no-reply
2020-09-19  2:36 ` no-reply
2020-09-22 14:42 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200918204714.27276-8-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=groug@kaod.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).