qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [PULL 23/57] hw/char/serial: Remove old DEBUG_SERIAL commented code
Date: Sat, 19 Sep 2020 11:58:42 -0400	[thread overview]
Message-ID: <20200919155916.1046398-24-pbonzini@redhat.com> (raw)
In-Reply-To: <20200919155916.1046398-1-pbonzini@redhat.com>

From: Philippe Mathieu-Daudé <f4bug@amsat.org>

All useful DPRINTF() calls have been converted to trace
events.  Remove a pointless one in the IOEventHandler,
and drop the DEBUG_SERIAL ifdef'ry.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20200907015535.827885-4-f4bug@amsat.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/char/serial.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/hw/char/serial.c b/hw/char/serial.c
index e8029f840a..26f7fa8a21 100644
--- a/hw/char/serial.c
+++ b/hw/char/serial.c
@@ -36,8 +36,6 @@
 #include "trace.h"
 #include "hw/qdev-properties.h"
 
-//#define DEBUG_SERIAL
-
 #define UART_LCR_DLAB	0x80	/* Divisor latch access bit */
 
 #define UART_IER_MSI	0x08	/* Enable Modem status interrupt */
@@ -102,14 +100,6 @@
 
 #define MAX_XMIT_RETRY      4
 
-#ifdef DEBUG_SERIAL
-#define DPRINTF(fmt, ...) \
-do { fprintf(stderr, "serial: " fmt , ## __VA_ARGS__); } while (0)
-#else
-#define DPRINTF(fmt, ...) \
-do {} while (0)
-#endif
-
 static void serial_receive1(void *opaque, const uint8_t *buf, int size);
 static void serial_xmit(SerialState *s);
 
@@ -636,7 +626,6 @@ static void serial_receive1(void *opaque, const uint8_t *buf, int size)
 static void serial_event(void *opaque, QEMUChrEvent event)
 {
     SerialState *s = opaque;
-    DPRINTF("event %x\n", event);
     if (event == CHR_EVENT_BREAK)
         serial_receive_break(s);
 }
-- 
2.26.2




  parent reply	other threads:[~2020-09-19 16:18 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-19 15:58 [PULL 00/57] Misc patches for 2020-09-19 Paolo Bonzini
2020-09-19 15:58 ` [PULL 01/57] tests: add missing genh dependency Paolo Bonzini
2020-09-19 15:58 ` [PULL 02/57] iotests: Work around failing readlink -f Paolo Bonzini
2020-09-19 15:58 ` [PULL 03/57] meson: clean up build_by_default Paolo Bonzini
2020-09-19 15:58 ` [PULL 04/57] ninjatool: rebuild multi-output targets if outputs are missing Paolo Bonzini
2020-09-19 15:58 ` [PULL 05/57] meson: fix MSI rule Paolo Bonzini
2020-09-19 15:58 ` [PULL 06/57] meson: error out if qemu_suffix starts with / Paolo Bonzini
2020-09-19 15:58 ` [PULL 07/57] WHPX: vmware cpuid leaf for tsc and apic frequency Paolo Bonzini
2020-09-19 15:58 ` [PULL 08/57] configure: Do not intent to build WHPX on 32-bit host Paolo Bonzini
2020-09-19 15:58 ` [PULL 09/57] MAINTAINERS: add Paolo Bonzini as RCU maintainer Paolo Bonzini
2020-09-19 15:58 ` [PULL 10/57] target/i386: support KVM_FEATURE_ASYNC_PF_INT Paolo Bonzini
2020-09-19 15:58 ` [PULL 11/57] memory: Convert IOMMUMemoryRegionClass doc comment to kernel-doc Paolo Bonzini
2020-09-19 15:58 ` [PULL 12/57] vhost-scsi: support inflight io track Paolo Bonzini
2020-09-19 15:58 ` [PULL 13/57] Simplify the .gitignore file Paolo Bonzini
2020-09-19 15:58 ` [PULL 14/57] acpi: i386: Move VMBus DSDT entry to SB Paolo Bonzini
2020-09-19 15:58 ` [PULL 15/57] numa: drop support for '-numa node' (without memory specified) Paolo Bonzini
2020-09-19 15:58 ` [PULL 16/57] doc: Cleanup "'-mem-path' fallback to RAM" deprecation text Paolo Bonzini
2020-09-19 15:58 ` [PULL 17/57] numa: remove fixup numa_state->num_nodes to MAX_NODES Paolo Bonzini
2020-09-19 15:58 ` [PULL 18/57] hw/mips/mipssim: Use MMIO serial device on fake ISA I/O Paolo Bonzini
2020-09-19 15:58 ` [PULL 19/57] hw/char/serial: Remove TYPE_SERIAL_IO Paolo Bonzini
2020-09-19 15:58 ` [PULL 20/57] configure: rename QEMU_GA_MSI_ENABLED to CONFIG_QGA_MSI Paolo Bonzini
2020-09-19 15:58 ` [PULL 21/57] hw/char/serial: Assert serial_ioport_read/write offset fits 8 bytes Paolo Bonzini
2020-09-19 15:58 ` [PULL 22/57] hw/char/serial: Replace commented DPRINTF() by trace event Paolo Bonzini
2020-09-19 15:58 ` Paolo Bonzini [this message]
2020-09-19 15:58 ` [PULL 24/57] hw/char/serial: Rename I/O read/write trace events Paolo Bonzini
2020-09-19 15:58 ` [PULL 25/57] hw/char/serial: Make 'wakeup' property boolean Paolo Bonzini
2020-09-19 15:58 ` [PULL 26/57] hw/char/serial-{isa, pci}: Alias QDEV properties from generic serial object Paolo Bonzini
2020-09-19 15:58 ` [PULL 27/57] scsi-generic: Fix HM-zoned device scan Paolo Bonzini
2020-09-19 15:58 ` [PULL 28/57] hw: megasas: return -1 when 'megasas_map_sgl' fails Paolo Bonzini
2020-09-19 15:58 ` [PULL 29/57] hw: megasas: consider 'iov_count=0' is an error in megasas_map_sgl Paolo Bonzini
2020-09-19 15:58 ` [PULL 30/57] i386/cpu: Clear FEAT_XSAVE_COMP_{LO, HI} when XSAVE is not available Paolo Bonzini
2020-09-19 15:58 ` [PULL 31/57] meson: move libudev test Paolo Bonzini
2020-09-19 15:58 ` [PULL 32/57] meson: move libmpathpersist test Paolo Bonzini
2020-09-19 15:58 ` [PULL 33/57] meson: extend libmpathpersist test for static linking Paolo Bonzini
2020-09-19 15:58 ` [PULL 34/57] configure: move malloc_trim/tcmalloc/jemalloc to meson Paolo Bonzini
2020-09-19 15:58 ` [PULL 35/57] configure: fix --meson=/path/to/meson Paolo Bonzini
2020-09-19 15:58 ` [PULL 36/57] configure: move cocoa option to Meson Paolo Bonzini
2020-09-19 15:58 ` [PULL 37/57] configure: do not limit Hypervisor.framework test to Darwin Paolo Bonzini
2020-09-19 15:58 ` [PULL 38/57] meson: qtest: set "depends" correctly Paolo Bonzini
2020-09-19 15:58 ` [PULL 39/57] mtest2make: add support for introspected test dependencies Paolo Bonzini
2020-09-19 15:58 ` [PULL 40/57] meson: report accelerator support Paolo Bonzini
2020-09-19 15:59 ` [PULL 41/57] oslib: do not call g_strdup from qemu_get_exec_dir Paolo Bonzini
2020-09-19 15:59 ` [PULL 42/57] fuzz: use qemu_get_exec_dir Paolo Bonzini
2020-09-19 15:59 ` [PULL 43/57] oslib-posix: default exec_dir to bindir Paolo Bonzini
2020-09-19 15:59 ` [PULL 44/57] cutils: introduce get_relocated_path Paolo Bonzini
2020-09-19 15:59 ` [PULL 45/57] oslib-posix: relocate path to /var Paolo Bonzini
2020-09-19 15:59 ` [PULL 46/57] module: relocate path to modules Paolo Bonzini
2020-09-19 15:59 ` [PULL 47/57] net: relocate paths to helpers and scripts Paolo Bonzini
2020-09-19 15:59 ` [PULL 48/57] vl: relocate paths to data directories Paolo Bonzini
2020-09-19 15:59 ` [PULL 49/57] vl: relocate path to configuration file Paolo Bonzini
2020-09-19 15:59 ` [PULL 50/57] qemu-bridge-helper: relocate path to default ACL Paolo Bonzini
2020-09-19 15:59 ` [PULL 51/57] qga: relocate path to default configuration and hook Paolo Bonzini
2020-09-19 15:59 ` [PULL 52/57] ui: relocate paths to icons and translations Paolo Bonzini
2020-09-19 15:59 ` [PULL 53/57] configure: use a platform-neutral prefix Paolo Bonzini
2020-09-19 15:59 ` [PULL 54/57] hw/i386/q35: Remove unreachable Xen code on Q35 machine Paolo Bonzini
2020-09-19 15:59 ` [PULL 55/57] exec: Remove MemoryRegion::global_locking field Paolo Bonzini
2020-09-19 15:59 ` [PULL 56/57] checkpatch: avoid error on cover letter files Paolo Bonzini
2020-09-19 15:59 ` [PULL 57/57] meson: fix installation of keymaps Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200919155916.1046398-24-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).