From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Sunil Muthuswamy <sunilmut@microsoft.com>
Subject: [PULL 07/57] WHPX: vmware cpuid leaf for tsc and apic frequency
Date: Sat, 19 Sep 2020 11:58:26 -0400 [thread overview]
Message-ID: <20200919155916.1046398-8-pbonzini@redhat.com> (raw)
In-Reply-To: <20200919155916.1046398-1-pbonzini@redhat.com>
From: Sunil Muthuswamy <sunilmut@microsoft.com>
Newer versions of WHPX provide the capability to query the tsc
and apic frequency. Expose these through the vmware cpuid leaf.
This patch doesnt support setting the tsc frequency; that will
come as a separate fix.
Signed-off-by: Sunil Muthuswamy <sunilmut@microsoft.com>
Message-Id: <SN4PR2101MB08808DFDDC3F442BBEAADFF4C0710@SN4PR2101MB0880.namprd21.prod.outlook.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
target/i386/whp-dispatch.h | 3 +-
target/i386/whpx-all.c | 96 +++++++++++++++++++++++++++++++++-----
2 files changed, 87 insertions(+), 12 deletions(-)
diff --git a/target/i386/whp-dispatch.h b/target/i386/whp-dispatch.h
index e4695c349f..b18aba20ed 100644
--- a/target/i386/whp-dispatch.h
+++ b/target/i386/whp-dispatch.h
@@ -2,10 +2,11 @@
#define WHP_DISPATCH_H
#include <windows.h>
-
#include <WinHvPlatform.h>
#include <WinHvEmulation.h>
+#define WHV_E_UNKNOWN_CAPABILITY 0x80370300L
+
#define LIST_WINHVPLATFORM_FUNCTIONS(X) \
X(HRESULT, WHvGetCapability, (WHV_CAPABILITY_CODE CapabilityCode, VOID* CapabilityBuffer, UINT32 CapabilityBufferSizeInBytes, UINT32* WrittenSizeInBytes)) \
X(HRESULT, WHvCreatePartition, (WHV_PARTITION_HANDLE* Partition)) \
diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c
index c78baac6df..3fad7928e8 100644
--- a/target/i386/whpx-all.c
+++ b/target/i386/whpx-all.c
@@ -27,6 +27,8 @@
#include <WinHvPlatform.h>
#include <WinHvEmulation.h>
+#define HYPERV_APIC_BUS_FREQUENCY (200000000ULL)
+
struct whpx_state {
uint64_t mem_quota;
WHV_PARTITION_HANDLE partition;
@@ -1061,6 +1063,18 @@ static int whpx_vcpu_run(CPUState *cpu)
cpu_x86_cpuid(env, cpuid_fn, 0, (UINT32 *)&rax, (UINT32 *)&rbx,
(UINT32 *)&rcx, (UINT32 *)&rdx);
switch (cpuid_fn) {
+ case 0x40000000:
+ /* Expose the vmware cpu frequency cpuid leaf */
+ rax = 0x40000010;
+ rbx = rcx = rdx = 0;
+ break;
+
+ case 0x40000010:
+ rax = env->tsc_khz;
+ rbx = env->apic_bus_freq / 1000; /* Hz to KHz */
+ rcx = rdx = 0;
+ break;
+
case 0x80000001:
/* Remove any support of OSVW */
rcx &= ~CPUID_EXT3_OSVW;
@@ -1191,8 +1205,12 @@ int whpx_init_vcpu(CPUState *cpu)
{
HRESULT hr;
struct whpx_state *whpx = &whpx_global;
- struct whpx_vcpu *vcpu;
+ struct whpx_vcpu *vcpu = NULL;
Error *local_error = NULL;
+ struct CPUX86State *env = (CPUArchState *)(cpu->env_ptr);
+ X86CPU *x86_cpu = X86_CPU(cpu);
+ UINT64 freq = 0;
+ int ret;
/* Add migration blockers for all unsupported features of the
* Windows Hypervisor Platform
@@ -1207,7 +1225,8 @@ int whpx_init_vcpu(CPUState *cpu)
error_report_err(local_error);
migrate_del_blocker(whpx_migration_blocker);
error_free(whpx_migration_blocker);
- return -EINVAL;
+ ret = -EINVAL;
+ goto error;
}
}
@@ -1215,7 +1234,8 @@ int whpx_init_vcpu(CPUState *cpu)
if (!vcpu) {
error_report("WHPX: Failed to allocte VCPU context.");
- return -ENOMEM;
+ ret = -ENOMEM;
+ goto error;
}
hr = whp_dispatch.WHvEmulatorCreateEmulator(
@@ -1224,8 +1244,8 @@ int whpx_init_vcpu(CPUState *cpu)
if (FAILED(hr)) {
error_report("WHPX: Failed to setup instruction completion support,"
" hr=%08lx", hr);
- g_free(vcpu);
- return -EINVAL;
+ ret = -EINVAL;
+ goto error;
}
hr = whp_dispatch.WHvCreateVirtualProcessor(
@@ -1234,17 +1254,72 @@ int whpx_init_vcpu(CPUState *cpu)
error_report("WHPX: Failed to create a virtual processor,"
" hr=%08lx", hr);
whp_dispatch.WHvEmulatorDestroyEmulator(vcpu->emulator);
- g_free(vcpu);
- return -EINVAL;
+ ret = -EINVAL;
+ goto error;
}
- vcpu->interruptable = true;
+ /*
+ * vcpu's TSC frequency is either specified by user, or use the value
+ * provided by Hyper-V if the former is not present. In the latter case, we
+ * query it from Hyper-V and record in env->tsc_khz, so that vcpu's TSC
+ * frequency can be migrated later via this field.
+ */
+ if (!env->tsc_khz) {
+ hr = whp_dispatch.WHvGetCapability(
+ WHvCapabilityCodeProcessorClockFrequency, &freq, sizeof(freq),
+ NULL);
+ if (hr != WHV_E_UNKNOWN_CAPABILITY) {
+ if (FAILED(hr)) {
+ printf("WHPX: Failed to query tsc frequency, hr=0x%08lx\n", hr);
+ } else {
+ env->tsc_khz = freq / 1000; /* Hz to KHz */
+ }
+ }
+ }
+ env->apic_bus_freq = HYPERV_APIC_BUS_FREQUENCY;
+ hr = whp_dispatch.WHvGetCapability(
+ WHvCapabilityCodeInterruptClockFrequency, &freq, sizeof(freq), NULL);
+ if (hr != WHV_E_UNKNOWN_CAPABILITY) {
+ if (FAILED(hr)) {
+ printf("WHPX: Failed to query apic bus frequency hr=0x%08lx\n", hr);
+ } else {
+ env->apic_bus_freq = freq;
+ }
+ }
+
+ /*
+ * If the vmware cpuid frequency leaf option is set, and we have a valid
+ * tsc value, trap the corresponding cpuid's.
+ */
+ if (x86_cpu->vmware_cpuid_freq && env->tsc_khz) {
+ UINT32 cpuidExitList[] = {1, 0x80000001, 0x40000000, 0x40000010};
+
+ hr = whp_dispatch.WHvSetPartitionProperty(
+ whpx->partition,
+ WHvPartitionPropertyCodeCpuidExitList,
+ cpuidExitList,
+ RTL_NUMBER_OF(cpuidExitList) * sizeof(UINT32));
+
+ if (FAILED(hr)) {
+ error_report("WHPX: Failed to set partition CpuidExitList hr=%08lx",
+ hr);
+ ret = -EINVAL;
+ goto error;
+ }
+ }
+
+ vcpu->interruptable = true;
cpu->vcpu_dirty = true;
cpu->hax_vcpu = (struct hax_vcpu_state *)vcpu;
qemu_add_vm_change_state_handler(whpx_cpu_update_state, cpu->env_ptr);
return 0;
+
+error:
+ g_free(vcpu);
+
+ return ret;
}
int whpx_vcpu_exec(CPUState *cpu)
@@ -1493,6 +1568,7 @@ static int whpx_accel_init(MachineState *ms)
WHV_CAPABILITY whpx_cap;
UINT32 whpx_cap_size;
WHV_PARTITION_PROPERTY prop;
+ UINT32 cpuidExitList[] = {1, 0x80000001};
whpx = &whpx_global;
@@ -1551,7 +1627,6 @@ static int whpx_accel_init(MachineState *ms)
goto error;
}
- UINT32 cpuidExitList[] = {1, 0x80000001};
hr = whp_dispatch.WHvSetPartitionProperty(
whpx->partition,
WHvPartitionPropertyCodeCpuidExitList,
@@ -1579,14 +1654,13 @@ static int whpx_accel_init(MachineState *ms)
printf("Windows Hypervisor Platform accelerator is operational\n");
return 0;
- error:
+error:
if (NULL != whpx->partition) {
whp_dispatch.WHvDeletePartition(whpx->partition);
whpx->partition = NULL;
}
-
return ret;
}
--
2.26.2
next prev parent reply other threads:[~2020-09-19 16:07 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-19 15:58 [PULL 00/57] Misc patches for 2020-09-19 Paolo Bonzini
2020-09-19 15:58 ` [PULL 01/57] tests: add missing genh dependency Paolo Bonzini
2020-09-19 15:58 ` [PULL 02/57] iotests: Work around failing readlink -f Paolo Bonzini
2020-09-19 15:58 ` [PULL 03/57] meson: clean up build_by_default Paolo Bonzini
2020-09-19 15:58 ` [PULL 04/57] ninjatool: rebuild multi-output targets if outputs are missing Paolo Bonzini
2020-09-19 15:58 ` [PULL 05/57] meson: fix MSI rule Paolo Bonzini
2020-09-19 15:58 ` [PULL 06/57] meson: error out if qemu_suffix starts with / Paolo Bonzini
2020-09-19 15:58 ` Paolo Bonzini [this message]
2020-09-19 15:58 ` [PULL 08/57] configure: Do not intent to build WHPX on 32-bit host Paolo Bonzini
2020-09-19 15:58 ` [PULL 09/57] MAINTAINERS: add Paolo Bonzini as RCU maintainer Paolo Bonzini
2020-09-19 15:58 ` [PULL 10/57] target/i386: support KVM_FEATURE_ASYNC_PF_INT Paolo Bonzini
2020-09-19 15:58 ` [PULL 11/57] memory: Convert IOMMUMemoryRegionClass doc comment to kernel-doc Paolo Bonzini
2020-09-19 15:58 ` [PULL 12/57] vhost-scsi: support inflight io track Paolo Bonzini
2020-09-19 15:58 ` [PULL 13/57] Simplify the .gitignore file Paolo Bonzini
2020-09-19 15:58 ` [PULL 14/57] acpi: i386: Move VMBus DSDT entry to SB Paolo Bonzini
2020-09-19 15:58 ` [PULL 15/57] numa: drop support for '-numa node' (without memory specified) Paolo Bonzini
2020-09-19 15:58 ` [PULL 16/57] doc: Cleanup "'-mem-path' fallback to RAM" deprecation text Paolo Bonzini
2020-09-19 15:58 ` [PULL 17/57] numa: remove fixup numa_state->num_nodes to MAX_NODES Paolo Bonzini
2020-09-19 15:58 ` [PULL 18/57] hw/mips/mipssim: Use MMIO serial device on fake ISA I/O Paolo Bonzini
2020-09-19 15:58 ` [PULL 19/57] hw/char/serial: Remove TYPE_SERIAL_IO Paolo Bonzini
2020-09-19 15:58 ` [PULL 20/57] configure: rename QEMU_GA_MSI_ENABLED to CONFIG_QGA_MSI Paolo Bonzini
2020-09-19 15:58 ` [PULL 21/57] hw/char/serial: Assert serial_ioport_read/write offset fits 8 bytes Paolo Bonzini
2020-09-19 15:58 ` [PULL 22/57] hw/char/serial: Replace commented DPRINTF() by trace event Paolo Bonzini
2020-09-19 15:58 ` [PULL 23/57] hw/char/serial: Remove old DEBUG_SERIAL commented code Paolo Bonzini
2020-09-19 15:58 ` [PULL 24/57] hw/char/serial: Rename I/O read/write trace events Paolo Bonzini
2020-09-19 15:58 ` [PULL 25/57] hw/char/serial: Make 'wakeup' property boolean Paolo Bonzini
2020-09-19 15:58 ` [PULL 26/57] hw/char/serial-{isa, pci}: Alias QDEV properties from generic serial object Paolo Bonzini
2020-09-19 15:58 ` [PULL 27/57] scsi-generic: Fix HM-zoned device scan Paolo Bonzini
2020-09-19 15:58 ` [PULL 28/57] hw: megasas: return -1 when 'megasas_map_sgl' fails Paolo Bonzini
2020-09-19 15:58 ` [PULL 29/57] hw: megasas: consider 'iov_count=0' is an error in megasas_map_sgl Paolo Bonzini
2020-09-19 15:58 ` [PULL 30/57] i386/cpu: Clear FEAT_XSAVE_COMP_{LO, HI} when XSAVE is not available Paolo Bonzini
2020-09-19 15:58 ` [PULL 31/57] meson: move libudev test Paolo Bonzini
2020-09-19 15:58 ` [PULL 32/57] meson: move libmpathpersist test Paolo Bonzini
2020-09-19 15:58 ` [PULL 33/57] meson: extend libmpathpersist test for static linking Paolo Bonzini
2020-09-19 15:58 ` [PULL 34/57] configure: move malloc_trim/tcmalloc/jemalloc to meson Paolo Bonzini
2020-09-19 15:58 ` [PULL 35/57] configure: fix --meson=/path/to/meson Paolo Bonzini
2020-09-19 15:58 ` [PULL 36/57] configure: move cocoa option to Meson Paolo Bonzini
2020-09-19 15:58 ` [PULL 37/57] configure: do not limit Hypervisor.framework test to Darwin Paolo Bonzini
2020-09-19 15:58 ` [PULL 38/57] meson: qtest: set "depends" correctly Paolo Bonzini
2020-09-19 15:58 ` [PULL 39/57] mtest2make: add support for introspected test dependencies Paolo Bonzini
2020-09-19 15:58 ` [PULL 40/57] meson: report accelerator support Paolo Bonzini
2020-09-19 15:59 ` [PULL 41/57] oslib: do not call g_strdup from qemu_get_exec_dir Paolo Bonzini
2020-09-19 15:59 ` [PULL 42/57] fuzz: use qemu_get_exec_dir Paolo Bonzini
2020-09-19 15:59 ` [PULL 43/57] oslib-posix: default exec_dir to bindir Paolo Bonzini
2020-09-19 15:59 ` [PULL 44/57] cutils: introduce get_relocated_path Paolo Bonzini
2020-09-19 15:59 ` [PULL 45/57] oslib-posix: relocate path to /var Paolo Bonzini
2020-09-19 15:59 ` [PULL 46/57] module: relocate path to modules Paolo Bonzini
2020-09-19 15:59 ` [PULL 47/57] net: relocate paths to helpers and scripts Paolo Bonzini
2020-09-19 15:59 ` [PULL 48/57] vl: relocate paths to data directories Paolo Bonzini
2020-09-19 15:59 ` [PULL 49/57] vl: relocate path to configuration file Paolo Bonzini
2020-09-19 15:59 ` [PULL 50/57] qemu-bridge-helper: relocate path to default ACL Paolo Bonzini
2020-09-19 15:59 ` [PULL 51/57] qga: relocate path to default configuration and hook Paolo Bonzini
2020-09-19 15:59 ` [PULL 52/57] ui: relocate paths to icons and translations Paolo Bonzini
2020-09-19 15:59 ` [PULL 53/57] configure: use a platform-neutral prefix Paolo Bonzini
2020-09-19 15:59 ` [PULL 54/57] hw/i386/q35: Remove unreachable Xen code on Q35 machine Paolo Bonzini
2020-09-19 15:59 ` [PULL 55/57] exec: Remove MemoryRegion::global_locking field Paolo Bonzini
2020-09-19 15:59 ` [PULL 56/57] checkpatch: avoid error on cover letter files Paolo Bonzini
2020-09-19 15:59 ` [PULL 57/57] meson: fix installation of keymaps Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200919155916.1046398-8-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sunilmut@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).