From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, "Michael Tokarev" <mjt@tls.msk.ru>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Laurent Vivier" <laurent@vivier.eu>,
"Cédric Le Goater" <clg@kaod.org>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: [PULL 02/17] hw/ppc/ppc4xx_pci: Replace magic value by the PCI_NUM_PINS definition
Date: Sat, 19 Sep 2020 20:44:36 +0200 [thread overview]
Message-ID: <20200919184451.2129349-3-laurent@vivier.eu> (raw)
In-Reply-To: <20200919184451.2129349-1-laurent@vivier.eu>
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
Replace the magic '4' value by the PCI_NUM_PINS definition.
Suggested-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200910072325.439344-3-f4bug@amsat.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/ppc/ppc4xx_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ppc/ppc4xx_pci.c b/hw/ppc/ppc4xx_pci.c
index c24bac96c32f..ca2553bf8b75 100644
--- a/hw/ppc/ppc4xx_pci.c
+++ b/hw/ppc/ppc4xx_pci.c
@@ -56,7 +56,7 @@ struct PPC4xxPCIState {
struct PCIMasterMap pmm[PPC4xx_PCI_NR_PMMS];
struct PCITargetMap ptm[PPC4xx_PCI_NR_PTMS];
- qemu_irq irq[4];
+ qemu_irq irq[PCI_NUM_PINS];
MemoryRegion container;
MemoryRegion iomem;
--
2.26.2
next prev parent reply other threads:[~2020-09-19 18:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-19 18:44 [PULL 00/17] Trivial branch for 5.2 patches Laurent Vivier
2020-09-19 18:44 ` [PULL 01/17] hw/gpio/max7310: Remove impossible check Laurent Vivier
2020-09-19 18:44 ` Laurent Vivier [this message]
2020-09-19 18:44 ` [PULL 03/17] ui/spice-input: Remove superfluous forward declaration Laurent Vivier
2020-09-19 18:44 ` [PULL 04/17] manual: escape backslashes in "parsed-literal" blocks Laurent Vivier
2020-09-19 18:44 ` [PULL 05/17] meson: remove empty else and duplicated gio deps Laurent Vivier
2020-09-19 18:44 ` [PULL 06/17] hw/timer/hpet: Remove unused functions hpet_ram_readb, hpet_ram_readw Laurent Vivier
2020-09-19 18:44 ` [PULL 07/17] hw/timer/hpet: Fix debug format strings Laurent Vivier
2020-09-19 18:44 ` [PULL 08/17] scripts/git.orderfile: Display meson files along with buildsys ones Laurent Vivier
2020-09-19 18:44 ` [PULL 09/17] qemu/: fix some comment spelling errors Laurent Vivier
2020-09-19 18:44 ` [PULL 10/17] migration/: " Laurent Vivier
2020-09-19 18:44 ` [PULL 11/17] docs/: " Laurent Vivier
2020-09-19 18:44 ` [PULL 12/17] scripts/: " Laurent Vivier
2020-09-19 18:44 ` [PULL 13/17] util/: " Laurent Vivier
2020-09-19 18:44 ` [PULL 14/17] linux-user/: " Laurent Vivier
2020-09-19 18:44 ` [PULL 15/17] disas/: " Laurent Vivier
2020-09-19 18:44 ` [PULL 16/17] qapi/: " Laurent Vivier
2020-09-19 18:44 ` [PULL 17/17] contrib/: " Laurent Vivier
2020-09-19 19:10 ` [PULL 00/17] Trivial branch for 5.2 patches no-reply
2020-09-22 15:40 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200919184451.2129349-3-laurent@vivier.eu \
--to=laurent@vivier.eu \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=f4bug@amsat.org \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).