qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Dov Murik" <dovmurik@linux.vnet.ibm.com>,
	"Michael Tokarev" <mjt@tls.msk.ru>,
	"Laurent Vivier" <laurent@vivier.eu>
Subject: [PULL 07/17] hw/timer/hpet: Fix debug format strings
Date: Sat, 19 Sep 2020 20:44:41 +0200	[thread overview]
Message-ID: <20200919184451.2129349-8-laurent@vivier.eu> (raw)
In-Reply-To: <20200919184451.2129349-1-laurent@vivier.eu>

From: Dov Murik <dovmurik@linux.vnet.ibm.com>

Fix compiler errors when compiling with -DHPET_DEBUG due to mismatch
between format string token "%x" and the argument type uint64_t.

Also "%#x" is replaced by "0x%" PRIx64 according to the coding style.

Signed-off-by: Dov Murik <dovmurik@linux.vnet.ibm.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200909083650.46771-3-dovmurik@linux.vnet.ibm.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 hw/timer/hpet.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c
index 07ff82b33358..edaa5a0adfb5 100644
--- a/hw/timer/hpet.c
+++ b/hw/timer/hpet.c
@@ -498,7 +498,8 @@ static void hpet_ram_write(void *opaque, hwaddr addr,
     HPETState *s = opaque;
     uint64_t old_val, new_val, val, index;
 
-    DPRINTF("qemu: Enter hpet_ram_writel at %" PRIx64 " = %#x\n", addr, value);
+    DPRINTF("qemu: Enter hpet_ram_writel at %" PRIx64 " = 0x%" PRIx64 "\n",
+            addr, value);
     index = addr;
     old_val = hpet_ram_read(opaque, addr, 4);
     new_val = value;
@@ -508,7 +509,7 @@ static void hpet_ram_write(void *opaque, hwaddr addr,
         uint8_t timer_id = (addr - 0x100) / 0x20;
         HPETTimer *timer = &s->timer[timer_id];
 
-        DPRINTF("qemu: hpet_ram_writel timer_id = %#x\n", timer_id);
+        DPRINTF("qemu: hpet_ram_writel timer_id = 0x%x\n", timer_id);
         if (timer_id > s->num_timers) {
             DPRINTF("qemu: timer id out of range\n");
             return;
@@ -640,8 +641,8 @@ static void hpet_ram_write(void *opaque, hwaddr addr,
             }
             s->hpet_counter =
                 (s->hpet_counter & 0xffffffff00000000ULL) | value;
-            DPRINTF("qemu: HPET counter written. ctr = %#x -> %" PRIx64 "\n",
-                    value, s->hpet_counter);
+            DPRINTF("qemu: HPET counter written. ctr = 0x%" PRIx64 " -> "
+                    "%" PRIx64 "\n", value, s->hpet_counter);
             break;
         case HPET_COUNTER + 4:
             if (hpet_enabled(s)) {
@@ -649,8 +650,8 @@ static void hpet_ram_write(void *opaque, hwaddr addr,
             }
             s->hpet_counter =
                 (s->hpet_counter & 0xffffffffULL) | (((uint64_t)value) << 32);
-            DPRINTF("qemu: HPET counter + 4 written. ctr = %#x -> %" PRIx64 "\n",
-                    value, s->hpet_counter);
+            DPRINTF("qemu: HPET counter + 4 written. ctr = 0x%" PRIx64 " -> "
+                    "%" PRIx64 "\n", value, s->hpet_counter);
             break;
         default:
             DPRINTF("qemu: invalid hpet_ram_writel\n");
-- 
2.26.2



  parent reply	other threads:[~2020-09-19 19:00 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-19 18:44 [PULL 00/17] Trivial branch for 5.2 patches Laurent Vivier
2020-09-19 18:44 ` [PULL 01/17] hw/gpio/max7310: Remove impossible check Laurent Vivier
2020-09-19 18:44 ` [PULL 02/17] hw/ppc/ppc4xx_pci: Replace magic value by the PCI_NUM_PINS definition Laurent Vivier
2020-09-19 18:44 ` [PULL 03/17] ui/spice-input: Remove superfluous forward declaration Laurent Vivier
2020-09-19 18:44 ` [PULL 04/17] manual: escape backslashes in "parsed-literal" blocks Laurent Vivier
2020-09-19 18:44 ` [PULL 05/17] meson: remove empty else and duplicated gio deps Laurent Vivier
2020-09-19 18:44 ` [PULL 06/17] hw/timer/hpet: Remove unused functions hpet_ram_readb, hpet_ram_readw Laurent Vivier
2020-09-19 18:44 ` Laurent Vivier [this message]
2020-09-19 18:44 ` [PULL 08/17] scripts/git.orderfile: Display meson files along with buildsys ones Laurent Vivier
2020-09-19 18:44 ` [PULL 09/17] qemu/: fix some comment spelling errors Laurent Vivier
2020-09-19 18:44 ` [PULL 10/17] migration/: " Laurent Vivier
2020-09-19 18:44 ` [PULL 11/17] docs/: " Laurent Vivier
2020-09-19 18:44 ` [PULL 12/17] scripts/: " Laurent Vivier
2020-09-19 18:44 ` [PULL 13/17] util/: " Laurent Vivier
2020-09-19 18:44 ` [PULL 14/17] linux-user/: " Laurent Vivier
2020-09-19 18:44 ` [PULL 15/17] disas/: " Laurent Vivier
2020-09-19 18:44 ` [PULL 16/17] qapi/: " Laurent Vivier
2020-09-19 18:44 ` [PULL 17/17] contrib/: " Laurent Vivier
2020-09-19 19:10 ` [PULL 00/17] Trivial branch for 5.2 patches no-reply
2020-09-22 15:40 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200919184451.2129349-8-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=dovmurik@linux.vnet.ibm.com \
    --cc=mjt@tls.msk.ru \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).