* [PATCH] timer: Fix timer_mod_anticipate() documentation
@ 2020-09-20 15:50 Philippe Mathieu-Daudé
2020-09-20 22:57 ` Richard Henderson
2020-09-23 17:13 ` Laurent Vivier
0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-09-20 15:50 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Paolo Bonzini, Philippe Mathieu-Daudé
timer_mod_anticipate() will be scaled to the timer unit,
which is not always nanosecond. Fix the documentation.
Fixes: add40e9777d ("timer: add timer_mod_anticipate*")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
include/qemu/timer.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/qemu/timer.h b/include/qemu/timer.h
index 6a8b48b5a9d..1dc880e94e7 100644
--- a/include/qemu/timer.h
+++ b/include/qemu/timer.h
@@ -679,7 +679,7 @@ void timer_mod(QEMUTimer *ts, int64_t expire_timer);
/**
* timer_mod_anticipate:
* @ts: the timer
- * @expire_time: the expiry time in nanoseconds
+ * @expire_time: the expire time in the units associated with the timer
*
* Modify a timer to expire at @expire_time or the current time, whichever
* comes earlier, taking into account the scale associated with the timer.
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] timer: Fix timer_mod_anticipate() documentation
2020-09-20 15:50 [PATCH] timer: Fix timer_mod_anticipate() documentation Philippe Mathieu-Daudé
@ 2020-09-20 22:57 ` Richard Henderson
2020-09-23 17:13 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2020-09-20 22:57 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: qemu-trivial, Paolo Bonzini
On 9/20/20 8:50 AM, Philippe Mathieu-Daudé wrote:
> timer_mod_anticipate() will be scaled to the timer unit,
> which is not always nanosecond. Fix the documentation.
>
> Fixes: add40e9777d ("timer: add timer_mod_anticipate*")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> include/qemu/timer.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] timer: Fix timer_mod_anticipate() documentation
2020-09-20 15:50 [PATCH] timer: Fix timer_mod_anticipate() documentation Philippe Mathieu-Daudé
2020-09-20 22:57 ` Richard Henderson
@ 2020-09-23 17:13 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2020-09-23 17:13 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: qemu-trivial, Paolo Bonzini
Le 20/09/2020 à 17:50, Philippe Mathieu-Daudé a écrit :
> timer_mod_anticipate() will be scaled to the timer unit,
> which is not always nanosecond. Fix the documentation.
>
> Fixes: add40e9777d ("timer: add timer_mod_anticipate*")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> include/qemu/timer.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/qemu/timer.h b/include/qemu/timer.h
> index 6a8b48b5a9d..1dc880e94e7 100644
> --- a/include/qemu/timer.h
> +++ b/include/qemu/timer.h
> @@ -679,7 +679,7 @@ void timer_mod(QEMUTimer *ts, int64_t expire_timer);
> /**
> * timer_mod_anticipate:
> * @ts: the timer
> - * @expire_time: the expiry time in nanoseconds
> + * @expire_time: the expire time in the units associated with the timer
> *
> * Modify a timer to expire at @expire_time or the current time, whichever
> * comes earlier, taking into account the scale associated with the timer.
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-23 17:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-20 15:50 [PATCH] timer: Fix timer_mod_anticipate() documentation Philippe Mathieu-Daudé
2020-09-20 22:57 ` Richard Henderson
2020-09-23 17:13 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).