From: "Richard W.M. Jones" <rjones@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: mdroth@linux.vnet.ibm.com, marcandre.lureau@gmail.com,
Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v5 1/8] qemu-options: New -compat to set policy for deprecated interfaces
Date: Mon, 21 Sep 2020 13:01:54 +0100 [thread overview]
Message-ID: <20200921120154.GA27434@redhat.com> (raw)
In-Reply-To: <f17c7dcf-9b37-dd2e-072d-1fd47bba9222@redhat.com>
On Mon, Sep 14, 2020 at 10:08:50AM -0500, Eric Blake wrote:
> On 9/14/20 3:47 AM, Markus Armbruster wrote:
> >Policy is separate for input and output.
> >
> >Input policy can be "accept" (accept silently), or "reject" (reject
> >the request with an error).
> >
> >Output policy can be "accept" (pass on unchanged), or "hide" (filter
> >out the deprecated parts).
> >
> >Default is "accept". Policies other than "accept" are implemented
> >later in this series.
> >
> >For now, -compat covers only syntactic aspects of QMP, i.e. stuff
> >tagged with feature 'deprecated'. We may want to extend it to cover
> >semantic aspects, CLI, and experimental features.
> >
> >The option is experimental.
> >
> >Signed-off-by: Markus Armbruster <armbru@redhat.com>
> >---
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> But as Peter points out, where is the introspection for whether this
> command line argument exists?
FWIW libguestfs still tests some qemu features by grepping -help
output. That's actually what I'm intending to do with this one, at
least for now.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW
next prev parent reply other threads:[~2020-09-21 12:03 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 8:47 [PATCH v5 0/8] Configurable policy for handling deprecated interfaces Markus Armbruster
2020-09-14 8:47 ` [PATCH v5 1/8] qemu-options: New -compat to set policy for " Markus Armbruster
2020-09-14 11:50 ` Peter Krempa
2020-09-21 14:35 ` Markus Armbruster
2020-09-14 15:08 ` Eric Blake
2020-09-21 12:01 ` Richard W.M. Jones [this message]
2020-09-14 8:47 ` [PATCH v5 2/8] qapi: Implement deprecated-output=hide for QMP command results Markus Armbruster
2020-09-14 8:47 ` [PATCH v5 3/8] qapi: Implement deprecated-output=hide for QMP events Markus Armbruster
2020-09-14 15:19 ` Eric Blake
2020-09-14 8:47 ` [PATCH v5 4/8] qapi: Implement deprecated-output=hide for QMP event data Markus Armbruster
2020-09-14 15:35 ` Eric Blake
2020-09-14 8:47 ` [PATCH v5 5/8] qapi: Implement deprecated-output=hide for QMP introspection Markus Armbruster
2020-09-14 15:43 ` Eric Blake
2020-09-21 14:41 ` Markus Armbruster
2020-09-14 8:48 ` [PATCH v5 6/8] qapi: Implement deprecated-input=reject for QMP commands Markus Armbruster
2020-09-14 15:45 ` Eric Blake
2020-09-14 8:48 ` [PATCH v5 7/8] qapi: Implement deprecated-input=reject for QMP command arguments Markus Armbruster
2020-09-14 15:57 ` Eric Blake
2020-09-14 8:48 ` [PATCH v5 8/8] qapi: New -compat deprecated-input=crash Markus Armbruster
2020-09-14 15:58 ` Eric Blake
2020-09-21 14:42 ` Markus Armbruster
2020-09-21 12:45 ` [PATCH v5 0/8] Configurable policy for handling deprecated interfaces Richard W.M. Jones
2020-09-21 12:54 ` Peter Krempa
2020-09-21 12:58 ` Richard W.M. Jones
2020-09-21 12:56 ` Peter Maydell
2020-09-21 14:58 ` Markus Armbruster
2020-09-21 16:28 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200921120154.GA27434@redhat.com \
--to=rjones@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).