[PATCH 0/1] block: future of sheepdog storage driver ?

[PATCH 0/1] block: future of sheepdog storage driver ?

[Daniel P. Berrangé]

2 years back I proposed dropping the sheepdog mailing list from the
MAINTAINERS file, but somehow the patch never got picked up:

  https://lists.gnu.org/archive/html/qemu-block/2018-03/msg01048.html

So here I am with the same patch again.

I further looked at the sheepdog project though, and I'm wondering
if we actually want to keep the sheepdog storage driver at all.

This thread from a little over a year ago:

  http://lists.wpkg.org/pipermail/sheepdog/2019-March/thread.html

clearly states that sheepdog is no longer actively developed. The only
mentioned users are some companies who are said to have it for legacy
reasons with plans to replace it by Ceph. There is talk about cutting
out existing features to turn it into a simple demo of how to write a
distributed block service. There is no evidence of anyone working on
that idea.

  https://github.com/sheepdog/sheepdog/commits/master

No real commits to git since Jan 2018 and that's just dealing with
technical debt.

There is essentially no activity on the mailing list aside from
patches to QEMU that get CC'd due to our MAINTAINERS entry, if and
when someone processes the moderator queue.

Fedora packages for sheepdog failed to build from upstream source
because of the more strict linker that no longer merges duplicate
global symbols. So we patch it to add the missing "extern" annotations.
Upstream source remains broken for everyone else.

AFAIK, none of our containers or VMs include the sheepdog server
packages, so we have no testing coverage for it in CI that I see.

Does someone have a compelling reason for QEMU to keep supporting
this driver, other than the fact that it already exists ?

If not, it looks like a candidate for deprecating in QEMU with a
view to later removing it.

Daniel P. Berrangé (1):
  block: drop moderated sheepdog mailing list from MAINTAINERS file

 MAINTAINERS | 1 -
 1 file changed, 1 deletion(-)

-- 
2.26.2

[PATCH 1/1] block: drop moderated sheepdog mailing list from MAINTAINERS file

[Daniel P. Berrangé]

The sheepdog mailing list is setup to stop and queue messages from
non-subscribers, pending moderator approval. Unfortunately it seems
that the moderation queue is not actively dealt with. Even when messages
are approved, the sender is never added to the whitelist, so every
future mail from the same sender continues to get stopped for moderation.

MAINTAINERS entries should be responsive and not uneccessarily block
mails from QEMU contributors, so drop the sheepdog mailing list.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 MAINTAINERS | 1 -
 1 file changed, 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 3d17cad19a..8e8a4fb0a8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2852,7 +2852,6 @@ F: block/rbd.c
 Sheepdog
 M: Liu Yuan <namei.unix@gmail.com>
 L: qemu-block@nongnu.org
-L: sheepdog@lists.wpkg.org
 S: Odd Fixes
 F: block/sheepdog.c
 
-- 
2.26.2

Re: [PATCH 1/1] block: drop moderated sheepdog mailing list from MAINTAINERS file

[Philippe Mathieu-Daudé]

On 9/22/20 11:01 AM, Daniel P. Berrangé wrote:
> The sheepdog mailing list is setup to stop and queue messages from
> non-subscribers, pending moderator approval. Unfortunately it seems
> that the moderation queue is not actively dealt with. Even when messages
> are approved, the sender is never added to the whitelist, so every
> future mail from the same sender continues to get stopped for moderation.
> 
> MAINTAINERS entries should be responsive and not uneccessarily block

Typo "unnecessarily".

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> mails from QEMU contributors, so drop the sheepdog mailing list.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  MAINTAINERS | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3d17cad19a..8e8a4fb0a8 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2852,7 +2852,6 @@ F: block/rbd.c
>  Sheepdog
>  M: Liu Yuan <namei.unix@gmail.com>
>  L: qemu-block@nongnu.org
> -L: sheepdog@lists.wpkg.org
>  S: Odd Fixes
>  F: block/sheepdog.c
>  
> 

Re: [PATCH 0/1] block: future of sheepdog storage driver ?

[Thomas Huth]

On 22/09/2020 11.01, Daniel P. Berrangé wrote:
[...]
> Does someone have a compelling reason for QEMU to keep supporting
> this driver, other than the fact that it already exists ?
> 
> If not, it looks like a candidate for deprecating in QEMU with a
> view to later removing it.

I think you gave enough examples why this is a good candidate for
deprecation. So I'd say: Simply send a patch to deprecate it. That's
what's our deprecation process is good for. If someone still cares for
sheepdog, they then can speak up and we can revert the patch that put it
on the deprecation list.

 Thomas

Re: [PATCH 0/1] block: future of sheepdog storage driver ?

[Markus Armbruster]

Thomas Huth <thuth@redhat.com> writes:

> On 22/09/2020 11.01, Daniel P. Berrangé wrote:
> [...]
>> Does someone have a compelling reason for QEMU to keep supporting
>> this driver, other than the fact that it already exists ?
>> 
>> If not, it looks like a candidate for deprecating in QEMU with a
>> view to later removing it.
>
> I think you gave enough examples why this is a good candidate for
> deprecation. So I'd say: Simply send a patch to deprecate it. That's
> what's our deprecation process is good for. If someone still cares for
> sheepdog, they then can speak up and we can revert the patch that put it
> on the deprecation list.

Concur.