From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: "Daniel P . Berrangé" <berrange@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
"Greg Kurz" <groug@kaod.org>,
qemu-devel@nongnu.org, "Andrea Bolognani" <abologna@redhat.com>,
"David Gibson" <dgibson@redhat.com>,
"Frediano Ziglio" <fziglio@redhat.com>
Subject: Re: [PATCH] migration: increase max-bandwidth to 128 MiB/s (1 Gib/s)
Date: Tue, 22 Sep 2020 13:11:43 +0100 [thread overview]
Message-ID: <20200922121143.GG2836@work-vm> (raw)
In-Reply-To: <20200921144957.979989-1-lvivier@redhat.com>
* Laurent Vivier (lvivier@redhat.com) wrote:
> max-bandwidth is set by default to 32 MiB/s (256 Mib/s)
> since 2008 (5bb7910af031c).
>
> Most of the CPUs can dirty memory faster than that now,
> and this is clearly a problem with POWER where the page
> size is 64 kiB and not 4 KiB.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Thanks,
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
in another 12 years we can increase it by 8x again!
> ---
> migration/migration.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 58a5452471f9..1c4174947181 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -57,7 +57,7 @@
> #include "qemu/queue.h"
> #include "multifd.h"
>
> -#define MAX_THROTTLE (32 << 20) /* Migration transfer speed throttling */
> +#define MAX_THROTTLE (128 << 20) /* Migration transfer speed throttling */
>
> /* Amount of time to allocate to each "chunk" of bandwidth-throttled
> * data. */
> --
> 2.26.2
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2020-09-22 12:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 14:49 [PATCH] migration: increase max-bandwidth to 128 MiB/s (1 Gib/s) Laurent Vivier
2020-09-22 0:46 ` David Gibson
2020-09-22 7:02 ` Greg Kurz
2020-09-22 12:11 ` Dr. David Alan Gilbert [this message]
2020-09-23 19:02 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922121143.GG2836@work-vm \
--to=dgilbert@redhat.com \
--cc=abologna@redhat.com \
--cc=berrange@redhat.com \
--cc=dgibson@redhat.com \
--cc=fziglio@redhat.com \
--cc=groug@kaod.org \
--cc=lvivier@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).