From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4212C4363D for ; Tue, 22 Sep 2020 17:34:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E13D22206 for ; Tue, 22 Sep 2020 17:34:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="L7AtcTmn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E13D22206 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53588 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKmBm-00063N-Ua for qemu-devel@archiver.kernel.org; Tue, 22 Sep 2020 13:34:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41614) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKm7D-0002dC-5n for qemu-devel@nongnu.org; Tue, 22 Sep 2020 13:30:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:46080) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kKm7A-0002EJ-M5 for qemu-devel@nongnu.org; Tue, 22 Sep 2020 13:30:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600795803; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VoL/ln2QuoXK503EZAMFsnvAwBTaN8EYTxWC42SMf/Y=; b=L7AtcTmnrBNVj5lY3HGuNqukAJ9KRJV+JlH85KZHJE3+78HPEoJ52QpkPCb7Wc9XH2jgsG EV12oqxIJTkiUOlTjRQtWllOwJnwHaw3qHzfgHGgHUj/lCv1SWq2ty+A3Pur+/Cx4Zn0eR vGGiToz7Xe7P78WZhAj7bvTHfZiUaEs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-100-_CCmEvDRNGiBfMQib4PNlA-1; Tue, 22 Sep 2020 13:29:58 -0400 X-MC-Unique: _CCmEvDRNGiBfMQib4PNlA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C353A10BBEE8; Tue, 22 Sep 2020 17:29:57 +0000 (UTC) Received: from horse.redhat.com (ovpn-116-78.rdu2.redhat.com [10.10.116.78]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9D8177882A; Tue, 22 Sep 2020 17:29:57 +0000 (UTC) Received: by horse.redhat.com (Postfix, from userid 10451) id 1A3D8223B13; Tue, 22 Sep 2020 13:29:57 -0400 (EDT) Date: Tue, 22 Sep 2020 13:29:57 -0400 From: Vivek Goyal To: Miklos Szeredi Subject: Re: [PATCH] virtiofsd: Used glib "shared" thread pool Message-ID: <20200922172957.GB57620@redhat.com> References: <20200921213216.GE13362@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vgoyal@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=vgoyal@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/22 02:07:04 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.455, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: virtio-fs-list , qemu-devel@nongnu.org, Stefan Hajnoczi , "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Sep 22, 2020 at 02:03:18PM +0200, Miklos Szeredi wrote: > On Mon, Sep 21, 2020 at 11:32 PM Vivek Goyal wrote: > > > glib offers thread pools and it seems to support "exclusive" and "shared" > > thread pools. > > > > > > https://developer.gnome.org/glib/stable/glib-Thread-Pools.html#g-thread-pool-new > > > > Currently we use "exlusive" thread pools but its performance seems to be > > poor. I tried using "shared" thread pools and performance seems much > > better. I posted performance results here. > > > > https://www.redhat.com/archives/virtio-fs/2020-September/msg00080.html > > > > So lets switch to shared thread pools. We can think of making it optional > > once somebody can show in what cases exclusive thread pools offer better > > results. For now, my simple performance tests across the board see > > better results with shared thread pools. > > > > Needs this as well: I was wondering why I did not face this issue. I think my glib is old (glib2, 2.58.3) from fedora 29 and this change about sched_getattr seems relatively recent. commit 8aeca4fa647bfd0f35c4a86b1e6ca6e955519ca5 Author: Sebastian Dröge Date: Tue Dec 24 15:33:30 2019 +0200 GThreadPool - Don't inherit thread priorities when creating new threads I think my glib2 does not have this change and probably that's why seccomp did not trigger. Vivek > > --- qemu.orig/tools/virtiofsd/passthrough_seccomp.c 2020-09-16 > 20:21:13.168686176 +0200 > +++ qemu/tools/virtiofsd/passthrough_seccomp.c 2020-09-22 > 14:01:38.499164501 +0200 > @@ -94,6 +94,8 @@ static const int syscall_whitelist[] = { > SCMP_SYS(rt_sigaction), > SCMP_SYS(rt_sigprocmask), > SCMP_SYS(rt_sigreturn), > + SCMP_SYS(sched_getattr), > + SCMP_SYS(sched_setattr), > SCMP_SYS(sendmsg), > SCMP_SYS(setresgid), > SCMP_SYS(setresuid), > > Thanks, > Miklos