qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Alistair Francis" <alistair.francis@wdc.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PULL 11/11] sifive_u: Register "start-in-flash" as class property
Date: Tue, 22 Sep 2020 18:25:42 -0400	[thread overview]
Message-ID: <20200922222542.2354748-12-ehabkost@redhat.com> (raw)
In-Reply-To: <20200922222542.2354748-1-ehabkost@redhat.com>

Class properties make QOM introspection simpler and easier, as
they don't require an object to be instantiated.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20200921221045.699690-25-ehabkost@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 hw/riscv/sifive_u.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c
index a97637fb333..6ad975d6923 100644
--- a/hw/riscv/sifive_u.c
+++ b/hw/riscv/sifive_u.c
@@ -568,14 +568,6 @@ static void sifive_u_machine_instance_init(Object *obj)
     SiFiveUState *s = RISCV_U_MACHINE(obj);
 
     s->start_in_flash = false;
-    object_property_add_bool(obj, "start-in-flash",
-                             sifive_u_machine_get_start_in_flash,
-                             sifive_u_machine_set_start_in_flash);
-    object_property_set_description(obj, "start-in-flash",
-                                    "Set on to tell QEMU's ROM to jump to "
-                                    "flash. Otherwise QEMU will jump to DRAM "
-                                    "or L2LIM depending on the msel value");
-
     s->msel = 0;
     object_property_add(obj, "msel", "uint32",
                         sifive_u_machine_get_uint32_prop,
@@ -599,6 +591,14 @@ static void sifive_u_machine_class_init(ObjectClass *oc, void *data)
     mc->max_cpus = SIFIVE_U_MANAGEMENT_CPU_COUNT + SIFIVE_U_COMPUTE_CPU_COUNT;
     mc->min_cpus = SIFIVE_U_MANAGEMENT_CPU_COUNT + 1;
     mc->default_cpus = mc->min_cpus;
+
+    object_class_property_add_bool(oc, "start-in-flash",
+                                   sifive_u_machine_get_start_in_flash,
+                                   sifive_u_machine_set_start_in_flash);
+    object_class_property_set_description(oc, "start-in-flash",
+                                          "Set on to tell QEMU's ROM to jump to "
+                                          "flash. Otherwise QEMU will jump to DRAM "
+                                          "or L2LIM depending on the msel value");
 }
 
 static const TypeInfo sifive_u_machine_typeinfo = {
-- 
2.26.2



  parent reply	other threads:[~2020-09-22 22:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-22 22:25 [PULL 00/11] machine + QOM queue, 2020-09-22 Eduardo Habkost
2020-09-22 22:25 ` [PULL 01/11] qom: simplify object_find_property / object_class_find_property Eduardo Habkost
2020-09-22 22:25 ` [PULL 02/11] smp: drop support for deprecated (invalid topologies) Eduardo Habkost
2020-09-22 22:25 ` [PULL 03/11] cryptodev-vhost-user: Register "chardev" as class property Eduardo Habkost
2020-09-22 22:25 ` [PULL 04/11] cryptodev-backend: " Eduardo Habkost
2020-09-22 22:25 ` [PULL 05/11] s390x: Register all CPU properties as class properties Eduardo Habkost
2020-09-22 22:25 ` [PULL 06/11] cpu/core: Register core-id and nr-threads " Eduardo Habkost
2020-09-22 22:25 ` [PULL 07/11] xlnx-zcu102: Register properties " Eduardo Habkost
2020-09-22 22:25 ` [PULL 08/11] machine: Register "memory-backend" as class property Eduardo Habkost
2020-09-22 22:25 ` [PULL 09/11] i440fx: Register i440FX-pcihost properties as class properties Eduardo Habkost
2020-09-22 22:25 ` [PULL 10/11] sifive_e: Register "revb" as class property Eduardo Habkost
2020-09-22 22:25 ` Eduardo Habkost [this message]
2020-09-24 16:22 ` [PULL 00/11] machine + QOM queue, 2020-09-22 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200922222542.2354748-12-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=alistair.francis@wdc.com \
    --cc=berrange@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).