From: Gerd Hoffmann <kraxel@redhat.com>
To: "Volker Rümelin" <vr_qemu@t-online.de>
Cc: qemu-devel <qemu-devel@nongnu.org>,
"Zoltán Kővágó" <dirty.ice.hu@gmail.com>
Subject: Re: [PATCH 8/9] audio: restore mixing-engine playback buffer size
Date: Wed, 23 Sep 2020 08:36:05 +0200 [thread overview]
Message-ID: <20200923063605.hatwdgbnvaxcgmn7@sirius.home.kraxel.org> (raw)
In-Reply-To: <20200920171729.15861-8-vr_qemu@t-online.de>
> diff --git a/audio/sdlaudio.c b/audio/sdlaudio.c
> index 21b7a0484b..cb931d0fda 100644
> --- a/audio/sdlaudio.c
> +++ b/audio/sdlaudio.c
> @@ -253,6 +253,7 @@ static void sdl_callback (void *opaque, Uint8 *buf, int len)
> return ret; \
> }
>
> +SDL_WRAPPER_FUNC(buffer_get_free, size_t, (HWVoiceOut *hw), (hw))
> SDL_WRAPPER_FUNC(get_buffer_out, void *, (HWVoiceOut *hw, size_t *size),
> (hw, size), *size = 0, sdl_unlock)
> SDL_WRAPPER_FUNC(put_buffer_out, size_t,
Compiling C object libcommon.fa.p/audio_sdlaudio.c.o
../../audio/sdlaudio.c:256:65: error: macro "SDL_WRAPPER_FUNC" requires 6 arguments, but only 4 given
256 | SDL_WRAPPER_FUNC(buffer_get_free, size_t, (HWVoiceOut *hw), (hw))
| ^
../../audio/sdlaudio.c:243: note: macro "SDL_WRAPPER_FUNC" defined here
243 | #define SDL_WRAPPER_FUNC(name, ret_type, args_decl, args, fail, unlock) \
|
../../audio/sdlaudio.c:256:17: error: expected ‘;’ before ‘static’
256 | SDL_WRAPPER_FUNC(buffer_get_free, size_t, (HWVoiceOut *hw), (hw))
| ^
| ;
../../audio/sdlaudio.c:355:24: error: ‘sdl_buffer_get_free’ undeclared here (not in a function)
355 | .buffer_get_free = sdl_buffer_get_free,
| ^~~~~~~~~~~~~~~~~~~
make: *** [Makefile.ninja:1113: libcommon.fa.p/audio_sdlaudio.c.o] Error 1
(I think coreaudio has the same problem ...).
take care,
Gerd
next prev parent reply other threads:[~2020-09-23 6:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-20 17:14 [PATCH 0/9] Audio fixes and improvements Volker Rümelin
2020-09-20 17:17 ` [PATCH 1/9] audio: handle buf == NULL in put_buffer_out() Volker Rümelin
2020-09-20 17:17 ` [PATCH 2/9] audio/audio: fix video playback slowdown with spiceaudio Volker Rümelin
2020-09-20 17:17 ` [PATCH 3/9] audio/spiceaudio: always rate limit playback stream Volker Rümelin
2020-09-20 17:17 ` [PATCH 4/9] audio: align audio_generic_read with audio_pcm_hw_run_in Volker Rümelin
2020-09-20 17:17 ` [PATCH 5/9] audio: remove unnecessary calls to put_buffer_in Volker Rümelin
2020-09-20 17:17 ` [PATCH 6/9] audio: align audio_generic_write with audio_pcm_hw_run_out Volker Rümelin
2020-09-20 17:17 ` [PATCH 7/9] audio: run downstream playback queue unconditionally Volker Rümelin
2020-09-20 17:17 ` [PATCH 8/9] audio: restore mixing-engine playback buffer size Volker Rümelin
2020-09-23 6:36 ` Gerd Hoffmann [this message]
2020-09-24 17:42 ` Volker Rümelin
2020-09-20 17:17 ` [PATCH 9/9] audio: revert tests for pcm_ops table Volker Rümelin
2020-09-23 9:07 ` [PATCH 0/9] Audio fixes and improvements Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200923063605.hatwdgbnvaxcgmn7@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=dirty.ice.hu@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=vr_qemu@t-online.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).