qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Volker Rümelin" <vr_qemu@t-online.de>,
	"Gerd Hoffmann" <kraxel@redhat.com>
Subject: [PULL 3/9] audio/spiceaudio: always rate limit playback stream
Date: Wed, 23 Sep 2020 11:09:55 +0200	[thread overview]
Message-ID: <20200923091001.20814-4-kraxel@redhat.com> (raw)
In-Reply-To: <20200923091001.20814-1-kraxel@redhat.com>

From: Volker Rümelin <vr_qemu@t-online.de>

The playback rate with the spiceaudio backend is currently too
fast if there's no spice client connected or the spice client
can't play audio. Rate limit the audio playback stream in all
cases. To calculate the rate correctly the limiter has to know
the maximum buffer size.

Fixes: 8c198ff065 ("spiceaudio: port to the new audio backend api")
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-id: 20200920171729.15861-3-vr_qemu@t-online.de
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 audio/audio.c      |  3 ++-
 audio/spiceaudio.c | 10 ++++------
 2 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/audio/audio.c b/audio/audio.c
index 7b660dd0c4d0..d5891e1928bc 100644
--- a/audio/audio.c
+++ b/audio/audio.c
@@ -1089,7 +1089,8 @@ static size_t audio_pcm_hw_run_out(HWVoiceOut *hw, size_t live)
     size_t clipped = 0;
 
     while (live) {
-        size_t size, decr, proc;
+        size_t size = live * hw->info.bytes_per_frame;
+        size_t decr, proc;
         void *buf = hw->pcm_ops->get_buffer_out(hw, &size);
 
         if (size == 0) {
diff --git a/audio/spiceaudio.c b/audio/spiceaudio.c
index c8d81ba44290..c062742622e4 100644
--- a/audio/spiceaudio.c
+++ b/audio/spiceaudio.c
@@ -130,13 +130,11 @@ static void *line_out_get_buffer(HWVoiceOut *hw, size_t *size)
     }
 
     if (out->frame) {
-        *size = audio_rate_get_bytes(
-            &hw->info, &out->rate,
-            (out->fsize - out->fpos) * hw->info.bytes_per_frame);
-    } else {
-        audio_rate_start(&out->rate);
-        *size = LINE_OUT_SAMPLES << 2;
+        *size = MIN((out->fsize - out->fpos) << 2, *size);
     }
+
+    *size = audio_rate_get_bytes(&hw->info, &out->rate, *size);
+
     return out->frame + out->fpos;
 }
 
-- 
2.27.0



  parent reply	other threads:[~2020-09-23  9:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-23  9:09 [PULL 0/9] Audio 20200923 patches Gerd Hoffmann
2020-09-23  9:09 ` [PULL 1/9] audio: handle buf == NULL in put_buffer_out() Gerd Hoffmann
2020-09-23  9:09 ` [PULL 2/9] audio/audio: fix video playback slowdown with spiceaudio Gerd Hoffmann
2020-09-23  9:09 ` Gerd Hoffmann [this message]
2020-09-23  9:09 ` [PULL 4/9] audio: align audio_generic_read with audio_pcm_hw_run_in Gerd Hoffmann
2020-09-23  9:09 ` [PULL 5/9] audio: remove unnecessary calls to put_buffer_in Gerd Hoffmann
2020-09-23  9:09 ` [PULL 6/9] audio: align audio_generic_write with audio_pcm_hw_run_out Gerd Hoffmann
2020-09-23  9:09 ` [PULL 7/9] audio: run downstream playback queue unconditionally Gerd Hoffmann
2020-09-23  9:10 ` [PULL 8/9] audio: remove qemu_spice_audio_init() Gerd Hoffmann
2020-09-23  9:10 ` [PULL 9/9] audio: build spiceaudio as module Gerd Hoffmann
2020-09-24 17:48 ` [PULL 0/9] Audio 20200923 patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200923091001.20814-4-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=vr_qemu@t-online.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).