qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/4] configure: bugfixes and cleanups for CFLAGS
@ 2020-09-23  9:26 Paolo Bonzini
  2020-09-23  9:26 ` [PATCH v2 1/4] configure: cleanup invocation of submodule Make Paolo Bonzini
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Paolo Bonzini @ 2020-09-23  9:26 UTC (permalink / raw)
  To: qemu-devel

Meson is placing -pie after -shared rather than before, and this
causes linking to fail while building the ArchLinux package for
QEMU.

But why is -pie ending up in the flags?  Because LDFLAGS is an
environment variable, and changes to environment variables propagate
when configure does

  LDFLAGS="-pie $LDFLAGS"

This happens without having to export the env. var again.

The solution is to simply rename the CFLAGS and LDFLAGS variables
used for flags that Meson takes care of by itself.  The CFLAGS
variable was previously used for submodules as well, so patches
1 and 2 fix that as well.

I'm keeping Richard's reviewed-by since the changes are pretty
obvious from v1.

v1->v2: include -fno-pie flags as well, since tests/tcg needs them
	handle empty CFLAGS and LDFLAGS too
	place flags in the built-in options section of the cross file

Paolo Bonzini (4):
  configure: cleanup invocation of submodule Make
  configure: cleanup CFLAGS and LDFLAGS for submodules
  configure: do not clobber environment CFLAGS/CXXFLAGS/LDFLAGS
  configure: consistently pass CFLAGS/CXXFLAGS/LDFLAGS to meson

 Makefile    | 23 +++++++++-------
 configure   | 75 ++++++++++++++++++++++++++++++++++-------------------
 meson.build | 13 +++++++++-
 3 files changed, 74 insertions(+), 37 deletions(-)

-- 
2.26.2



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-09-23  9:42 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-23  9:26 [PATCH v2 0/4] configure: bugfixes and cleanups for CFLAGS Paolo Bonzini
2020-09-23  9:26 ` [PATCH v2 1/4] configure: cleanup invocation of submodule Make Paolo Bonzini
2020-09-23  9:26 ` [PATCH v2 2/4] configure: cleanup CFLAGS and LDFLAGS for submodules Paolo Bonzini
2020-09-23  9:26 ` [PATCH v2 3/4] configure: do not clobber environment CFLAGS/CXXFLAGS/LDFLAGS Paolo Bonzini
2020-09-23  9:26 ` [PATCH v2 4/4] configure: consistently pass CFLAGS/CXXFLAGS/LDFLAGS to meson Paolo Bonzini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).